xazax.hun added a comment.

Shouldn't there be a functionality to invalidate all the globals at every 
function call by default?



================
Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:141
+    // Global vars are already initialized in `Environment`.
+    if (D.hasGlobalStorage())
+      return;
----------------
Do we expect to ever see a global declaration in a transfer function? Or is 
this for static locals? If it is for the latter, I'd adjust the comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120149/new/

https://reviews.llvm.org/D120149

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to