zahiraam updated this revision to Diff 409678.
zahiraam marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120066/new/
https://reviews.llvm.org/D120066
Files:
clang/test/CodeGenCXX/debug-info-hotpatch.cpp
Index: clang/test/CodeGenCXX/debug-info-hotpatch.c
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
Feel free to commit with the suggestions I added above.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120066/new/
https://reviews.llvm.o
erichkeane added a comment.
Commit message isn't particularly good either.
Perhaps something like:
> [NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue
>
> In our downstream, we discovered that the that the `.*` wildcard
> in debug-info-hotpatch.cpp (added https://reviews.l
zahiraam created this revision.
zahiraam added a reviewer: erichkeane.
zahiraam requested review of this revision.
Herald added a project: clang.
We found that on Windows the regular expression used to describe the link
command from the last RUN command of the LIT test debug-info-hotpatch.cpp, is
