[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

2022-01-31 Thread Ties Stuij via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6b1e844b69f1: [ARM] Add Cortex-X1C Support for Clang and LLVM (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117202/new/ https://reviews

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

2022-01-21 Thread Dave Green via Phabricator via cfe-commits
dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117202/new/ https://reviews.llvm.org/D117202 _

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

2022-01-21 Thread Ties Stuij via Phabricator via cfe-commits
stuij updated this revision to Diff 401936. stuij marked an inline comment as done. stuij added a comment. Herald added a subscriber: dexonsmith. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117202/new/ https://reviews.ll

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

2022-01-21 Thread Ties Stuij via Phabricator via cfe-commits
stuij marked 2 inline comments as done. stuij added a comment. > Thanks for the update. Same(ish) questions for the Arm side. Otherwise this > LGTM Ai, thanks. Should have checked Arm as well. > Oh, also is there an ID for this CPU that is worth adding to > getHostCPUNameForARM in Host.cpp? Y

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

2022-01-20 Thread Dave Green via Phabricator via cfe-commits
dmgreen added a comment. Oh, also is there an ID for this CPU that is worth adding to getHostCPUNameForARM in Host.cpp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117202/new/ https://reviews.llvm.org/D117202 ___

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

2022-01-20 Thread Dave Green via Phabricator via cfe-commits
dmgreen added a comment. Thanks for the update. Same(ish) questions for the Arm side. Otherwise this LGTM Comment at: llvm/include/llvm/Support/ARMTargetParser.def:332 +ARM_CPU_NAME("cortex-x1c", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false, + ARM::AEK_RAS) ARM_CPU_NAM

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

2022-01-20 Thread Ties Stuij via Phabricator via cfe-commits
stuij updated this revision to Diff 401569. stuij marked an inline comment as done. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117202/new/ https://reviews.llvm.org/D117202 Files: clang/test/Dri

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

2022-01-20 Thread Ties Stuij via Phabricator via cfe-commits
stuij marked 2 inline comments as done. stuij added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:205 +AARCH64_CPU_NAME("cortex-x1c", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false, + (AArch64::AEK_RAS)) AARCH64_CPU_NAME("cortex-x2", AR

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

2022-01-13 Thread Dave Green via Phabricator via cfe-commits
dmgreen added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:205 +AARCH64_CPU_NAME("cortex-x1c", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false, + (AArch64::AEK_RAS)) AARCH64_CPU_NAME("cortex-x2", ARMV9A, FK_NEON_FP_ARMV8, false, ---

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

2022-01-13 Thread Ties Stuij via Phabricator via cfe-commits
stuij created this revision. Herald added subscribers: hiraditya, kristof.beyls. stuij requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch upstreams support for the Arm-v8 Cortex-X1C processor for AArch64 and ARM.