stuij marked 2 inline comments as done. stuij added a comment. > Thanks for the update. Same(ish) questions for the Arm side. Otherwise this > LGTM
Ai, thanks. Should have checked Arm as well. > Oh, also is there an ID for this CPU that is worth adding to > getHostCPUNameForARM in Host.cpp? Yup, thanks. Added. ================ Comment at: llvm/lib/Target/ARM/ARM.td:1446 +def : ProcNoItin<"cortex-x1c", [ARMv82a, + FeatureHWDivThumb, ---------------- dmgreen wrote: > Should this have ProcX1C added? yes :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117202/new/ https://reviews.llvm.org/D117202 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
