This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5653d127d7c4: [docs] Give the reason why the support for
coroutine is partial (authored by ChuanqiXu).
Repository:
rG LLVM Github Monorepo
CHANGE
ChuanqiXu updated this revision to Diff 394529.
ChuanqiXu added a comment.
Address comments. Thanks for reviewing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115778/new/
https://reviews.llvm.org/D115778
Files:
clang/www/cxx_status.html
Inde
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a minor wording fix. Thank you for this!
Comment at: clang/www/cxx_status.html:1206-1207
+ `__attribute__((const))` attribute correctly. There
ChuanqiXu added inline comments.
Comment at: clang/www/cxx_status.html:1267-1270
+(12): The optimizer couldn't handle TLS with
+ `__attribute__((const))` attribute correctly. It implies that there would
+ be problems if the coroutine is possible to resume on a different thread.
ChuanqiXu updated this revision to Diff 394527.
ChuanqiXu added a comment.
Address comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115778/new/
https://reviews.llvm.org/D115778
Files:
clang/www/cxx_status.html
Index: clang/www/cxx_status.html
aaron.ballman added a comment.
Thanks for this!
Comment at: clang/www/cxx_status.html:1202
https://wg21.link/p0912r5";>P0912R5
- Partial
+ Partial (12)
Rather than following this approach, it'd be nice to have the information
provided di
ChuanqiXu created this revision.
ChuanqiXu added reviewers: aaron.ballman, jyknight.
ChuanqiXu added a project: clang.
ChuanqiXu requested review of this revision.
Herald added a subscriber: cfe-commits.
See https://lists.llvm.org/pipermail/cfe-dev/2021-December/069608.html. We
couldn't mark coro
