ChuanqiXu added inline comments.

================
Comment at: clang/www/cxx_status.html:1267-1270
+<span id="CoroPartialReason">(12): The optimizer couldn't handle TLS with
+  `__attribute__((const))` attribute correctly. It implies that there would
+  be problems if the coroutine is possible to resume on a different thread.
+</span>
----------------
aaron.ballman wrote:
> Also, when moving it to be a detail of the current row, I'd drop the `(12): ` 
> from the text.
> 
> I think we should also add some words to the effect of "This feature was 
> implemented based on the Coroutines TS and requires further analysis to 
> determine what support remains to be added." This should hopefully make it 
> clear that the list of issues found is not exhaustive and that investigative 
> work is still needed.
The current implementation have some minor differences with coroutines TS 
already. So I chose the wording Richard gives in the mailing list. I think it 
is proper.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115778/new/

https://reviews.llvm.org/D115778

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to