This revision was automatically updated to reflect the committed changes.
Closed by commit rG6e1aaf18af6c: [PowerPC] Mark splat immediate instructions as
rematerializable (authored by NeHuang).
Changed prior to commit:
https://reviews.llvm.org/D108823?vs=369101&id=374892#toc
Repository:
rG L
lei accepted this revision as: lei.
lei added a comment.
This revision is now accepted and ready to land.
LGTM
Thx.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108823/new/
https://reviews.llvm.org/D108823
amyk added a comment.
A question I have is, I noticed there are some test case changes involving
`xxspltidp` and `xxsplti32dx`, but are additional tests needed for `xxspltiw`?
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:1887
// XXSPLI32DX needs extra flags to make
NeHuang created this revision.
NeHuang added reviewers: nemanjai, stefanp, lei, PowerPC.
NeHuang added a project: LLVM.
Herald added subscribers: shchenz, kbarton, hiraditya, qcolombet.
NeHuang requested review of this revision.
This patch marks splat immediate instructions `XXSPLTIDP` and `XXSPLT