[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

jansvoboda11 added a comment. In D108366#3188028 , @mgorny wrote: > This change causes a test regression on Gentoo (where > `CLANG_RESOURCE_DIR="../../../../lib/clang/${clang_version}"`): Thanks for reporting this. Should be fixed in D115628

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

mgorny added a comment. This change causes a test regression on Gentoo (where `CLANG_RESOURCE_DIR="../../../../lib/clang/${clang_version}"`): FAIL: Clang :: ClangScanDeps/resource_directory.c (1961 of 29550) TEST 'Clang :: ClangScanDeps/resource_directory.c' FAILED

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8b14b682c33: [clang][deps] Make resource directory deduction configurable (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108366/n

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

jansvoboda11 updated this revision to Diff 381210. jansvoboda11 added a comment. Add `REQUIRES: shell` to the test, rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108366/new/ https://reviews.llvm.org/D108366 Files: clang/test/ClangScanDep

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/ClangScanDeps/resource_directory.c:3 +// RUN: cp %S/Inputs/resource_directory/* %t +// RUN: sed -e "s|CLANG|/our/custom/bin/clang|g" -e "

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/resource_directory.c:3 +// RUN: cp %S/Inputs/resource_directory/* %t +// RUN: sed -e "s|CLANG|/our/custom/bin/clang|g" -e "s|DIR|%/t|g" %S/Inputs/resource_directory/cdb_tu.json > %t/cdb.json + -

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

jansvoboda11 updated this revision to Diff 371597. jansvoboda11 added a comment. Fix CI pls? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108366/new/ https://reviews.llvm.org/D108366 Files: clang/test/ClangScanDeps/Inputs/resource_directory/cdb

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

jansvoboda11 updated this revision to Diff 371568. jansvoboda11 added a comment. Attempt to fix CI again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108366/new/ https://reviews.llvm.org/D108366 Files: clang/test/ClangScanDeps/Inputs/resource_d

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

jansvoboda11 updated this revision to Diff 370931. jansvoboda11 added a comment. Attempt to fix tests in CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108366/new/ https://reviews.llvm.org/D108366 Files: clang/test/ClangScanDeps/Inputs/resourc

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

jansvoboda11 added a comment. @dexonsmith I have incorporated your suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108366/new/ https://reviews.llvm.org/D108366 ___ cfe-commits mailing list cfe