mgorny added a comment.

This change causes a test regression on Gentoo (where 
`CLANG_RESOURCE_DIR="../../../../lib/clang/${clang_version}"`):

  FAIL: Clang :: ClangScanDeps/resource_directory.c (1961 of 29550)
  ******************** TEST 'Clang :: ClangScanDeps/resource_directory.c' 
FAILED ********************
  Script:
  --
  : 'RUN: at line 3';   rm -rf 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp
 && mkdir 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp
  : 'RUN: at line 4';   cp 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/clang/test/ClangScanDeps/Inputs/resource_directory/*
 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp
  : 'RUN: at line 8';   sed -e "s|CLANG|/our/custom/bin/clang|g" -e 
"s|DIR|/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp|g"
    
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/clang/test/ClangScanDeps/Inputs/resource_directory/cdb.json.template
 > 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp/cdb_path.json
  : 'RUN: at line 10';   
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/bin/clang-scan-deps
 -compilation-database 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp/cdb_path.json
 --format experimental-full    --resource-dir-recipe modify-compiler-path > 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp/result_path.json
  : 'RUN: at line 12';   cat 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp/result_path.json
 | sed 's:\\\\\?:/:g' | /usr/lib/llvm/14/bin/FileCheck 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/clang/test/ClangScanDeps/resource_directory.c
 --check-prefix=CHECK-PATH
  : 'RUN: at line 18';   chmod +x 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp/compiler
  : 'RUN: at line 19';   sed -e 
"s|CLANG|/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp/compiler|g"
 -e 
"s|DIR|/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp|g"
    
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/clang/test/ClangScanDeps/Inputs/resource_directory/cdb.json.template
 > 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp/cdb_invocation.json
  : 'RUN: at line 21';   
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/bin/clang-scan-deps
 -compilation-database 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp/cdb_invocation.json
 --format experimental-full    --resource-dir-recipe invoke-compiler > 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp/result_invocation.json
  : 'RUN: at line 23';   cat 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp/result_invocation.json
 | sed 's:\\\\\?:/:g' | /usr/lib/llvm/14/bin/FileCheck 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/clang/test/ClangScanDeps/resource_directory.c
 --check-prefix=CHECK-INVOCATION
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  + : 'RUN: at line 3'
  + rm -rf 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp
  + mkdir 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp
  + : 'RUN: at line 4'
  + cp 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/clang/test/ClangScanDeps/Inputs/resource_directory/cdb.json.template
 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/clang/test/ClangScanDeps/Inputs/resource_directory/compiler
 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/clang/test/ClangScanDeps/Inputs/resource_directory/mod.h
 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/clang/test/ClangScanDeps/Inputs/resource_directory/module.modulemap
 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/clang/test/ClangScanDeps/Inputs/resource_directory/tu.c
 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp
  + : 'RUN: at line 8'
  + sed -e 's|CLANG|/our/custom/bin/clang|g' -e 
's|DIR|/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp|g'
 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/clang/test/ClangScanDeps/Inputs/resource_directory/cdb.json.template
  + : 'RUN: at line 10'
  + 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/bin/clang-scan-deps
 -compilation-database 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp/cdb_path.json
 --format experimental-full --resource-dir-recipe modify-compiler-path
  + : 'RUN: at line 12'
  + /usr/lib/llvm/14/bin/FileCheck 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/clang/test/ClangScanDeps/resource_directory.c
 --check-prefix=CHECK-PATH
  + sed 's:\\\\\?:/:g'
  + cat 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp/result_path.json
  
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/clang/test/ClangScanDeps/resource_directory.c:14:21:
 error: CHECK-PATH-NEXT: expected string not found in input
  // CHECK-PATH-NEXT: "/our/custom/lib{{.*}}"
                      ^
  <stdin>:21:17: note: scanning from here
   "-resource-dir",
                  ^
  <stdin>:22:2: note: possible intended match here
   "/our/custom/bin/../../../../lib/clang/14.0.0",
   ^
  
  Input file: <stdin>
  Check file: 
/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/clang/test/ClangScanDeps/resource_directory.c
  
  -dump-input=help explains the following input dump.
  
  Input was:
  <<<<<<
             .
             .
             .
            16:  "generic", 
            17:  "-triple", 
            18:  "i686-pc-linux-gnu", 
            19:  "-fmodules-validate-system-headers", 
            20:  "-fimplicit-module-maps", 
            21:  "-resource-dir", 
  next:14'0                     X~ error: no match found
            22:  "/our/custom/bin/../../../../lib/clang/14.0.0", 
  next:14'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  next:14'1      ?                                                possible 
intended match
            23:  "-fmodule-format=obj", 
  next:14'0     ~~~~~~~~~~~~~~~~~~~~~~~~
            24:  "-fmodules-strict-context-hash", 
  next:14'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            25:  
"-fmodules-cache-path=/var/tmp/portage/sys-devel/clang-14.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/ClangScanDeps/Output/resource_directory.c.tmp/cache",
 
  next:14'0     
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            26:  "-isystem", 
  next:14'0     ~~~~~~~~~~~~~
            27:  "/our/custom/bin/../../../../lib/clang/14.0.0/include", 
  next:14'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             .
             .
             .
  >>>>>>
  
  --
  
  ********************


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108366/new/

https://reviews.llvm.org/D108366

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D108366: [clang][de... Michał Górny via Phabricator via cfe-commits

Reply via email to