[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5c288948844: [NFC][clang] Use X86 Features declaration from X86TargetParser (authored by a.elovikov). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

a.elovikov updated this revision to Diff 368164. a.elovikov added a comment. Address Erich's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108151/new/ https://reviews.llvm.org/D108151 Files: clang/include/clang/Basic/X86Target.def cla

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108151/new/ https://reviews.llvm.org/D108151 ___ cfe-commits mailing list cfe-commits

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 2 nits, give Craig a day or two to =1 as well please, particularly since he's the code-owner here. Comment at: clang/lib/Basic/Targets/X86.cpp:1063 +#ifndef NDEBUG +

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

a.elovikov marked an inline comment as done. a.elovikov added a comment. Hi guys, do you want me to fix anything else? I think I've addressed what I could. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108151/new/ https://reviews.llvm.org/D108151

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

a.elovikov marked 3 inline comments as done. a.elovikov added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1071 +assert(llvm::is_contained(Priorities, Priority) && + "Priorites don't form consequtive range!"); + } erichkeane wrote:

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

a.elovikov updated this revision to Diff 367640. a.elovikov added a comment. Apply reviewers' suggestions. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108151/new/ https://reviews.llvm.org/D108151 Files: clang/include/clang/Basic/X86Tar

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

erichkeane added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1071 +assert(llvm::is_contained(Priorities, Priority) && + "Priorites don't form consequtive range!"); + } erichkeane wrote: > craig.topper wrote: > > erichkeane wrote: >

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

erichkeane added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1071 +assert(llvm::is_contained(Priorities, Priority) && + "Priorites don't form consequtive range!"); + } craig.topper wrote: > erichkeane wrote: > > If all you care abo

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1071 +assert(llvm::is_contained(Priorities, Priority) && + "Priorites don't form consequtive range!"); + } erichkeane wrote: > If all you care about is whether they are

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

erichkeane added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1071 +assert(llvm::is_contained(Priorities, Priority) && + "Priorites don't form consequtive range!"); + } If all you care about is whether they are a consecutive range,

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1061 static unsigned getFeaturePriority(llvm::X86::ProcessorFeatures Feat) { - enum class FeatPriority { -#define FEATURE(FEAT) FEAT, -#include "clang/Basic/X86Target.def" + // Check that priorites

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

a.elovikov updated this revision to Diff 366760. a.elovikov added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Another version. My main goal here is to gradually move more stuff from clang/ to llvm/ so I'm open to other suggestions in doing so. Repository:

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

craig.topper added a comment. The order in X86Parser.def is determined by how bits are allocated in to feature vector in libgcc. They're not in any priority order that I know of. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108151/new/ https://re

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

erichkeane added a comment. Are these in the same order in X86TargetParser.Def? Can we make some comment in that file to make sure that we keep them in the order (see comment in original x86Target.def)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

a.elovikov created this revision. a.elovikov added reviewers: erichkeane, craig.topper. Herald added a subscriber: pengfei. a.elovikov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...instead of redeclaring them in clang's own X86Target.d