Re: [PATCH] D10732: [OPENMP 4.0] Initial support for array sections.

This revision was automatically updated to reflect the committed changes. ABataev marked an inline comment as done. Closed by commit rL245937: [OPENMP 4.0] Initial support for array sections. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D10732?vs=32974&id=33077#toc R

Re: [PATCH] D10732: [OPENMP 4.0] Initial support for array sections.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Comment at: lib/Sema/SemaExpr.cpp:4035 @@ +4034,3 @@ + // Build an unanalyzed expression if either operand is type-dependent. + if (Base->isTypeDependent() ||

Re: [PATCH] D10732: [OPENMP 4.0] Initial support for array sections.

ABataev updated this revision to Diff 32974. ABataev marked 10 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D10732 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def include/clang/AST/DataRecu

Re: [PATCH] D10732: [OPENMP 4.0] Initial support for array sections.

ABataev marked 15 inline comments as done. ABataev added a comment. Richard, thanks for the review! Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7680 @@ +7679,3 @@ +def err_omp_section_length_undefined : Error< + "section length is unspecified, but subscripted value i

Re: [PATCH] D10732: [OPENMP 4.0] Initial support for array sections.

rsmith added a comment. Thanks for the rework, the general approach here seems reasonable. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7680 @@ +7679,3 @@ +def err_omp_section_length_undefined : Error< + "section length is unspecified, but subscripted value is not an

Re: [PATCH] D10732: [OPENMP 4.0] Initial support for array sections.

ABataev added a comment. Richard, any comments? http://reviews.llvm.org/D10732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits