rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land.
Thanks, LGTM! ================ Comment at: lib/Sema/SemaExpr.cpp:4035 @@ +4034,3 @@ + // Build an unanalyzed expression if either operand is type-dependent. + if (Base->isTypeDependent() || Base->isValueDependent() || + (LowerBound && ---------------- I don't think you need to care whether `Base` is value-dependent here, because you don't care whether you can evaluate it. ================ Comment at: lib/Sema/SemaExpr.cpp:4088 @@ +4087,3 @@ + // C++ [expr.sub]p1: The type "T" shall be a completely-defined object + // type. Note that Functions are not objects, and that (in C99 parlance) + // incomplete types are not object types. ---------------- Functions -> functions http://reviews.llvm.org/D10732 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
