[PATCH] D105091: [RISCV] Pass -u to linker correctly.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5635d2a56dab: [RISCV] Pass -u to linker correctly. (authored by Kito Cheng ). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

kito-cheng updated this revision to Diff 358494. kito-cheng added a comment. Changes: - Update testcase again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105091/new/ https://reviews.llvm.org/D105091 Files: clang/lib/Driver/ToolChains/RISCVTo

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

MaskRay added a comment. The update was not what expected. I said that there should be just one RUN line and you can place -T, -u, --defsym and all linker options on that line. Each new RUN line consumes some resources on testing machines. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

kito-cheng updated this revision to Diff 358314. kito-cheng added a comment. Changes: - Add 2 testcases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105091/new/ https://reviews.llvm.org/D105091 Files: clang/lib/Driver/ToolChains/RISCVToolchain

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

MaskRay added inline comments. Comment at: clang/test/Driver/riscv-args.c:5 // RUN: %clang -### -target riscv32 \ // RUN: --gcc-toolchain= -Xlinker --defsym=FOO=10 -T a.lds %s 2>&1 \ // RUN: | FileCheck -check-prefix=CHECK-LD %s kito-cheng wrote: > MaskRay

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

kito-cheng updated this revision to Diff 357152. kito-cheng added a comment. Update testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105091/new/ https://reviews.llvm.org/D105091 Files: clang/lib/Driver/ToolChains/RISCVToolchain.cpp clan

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

kito-cheng added inline comments. Comment at: clang/test/Driver/riscv-args.c:5 // RUN: %clang -### -target riscv32 \ // RUN: --gcc-toolchain= -Xlinker --defsym=FOO=10 -T a.lds %s 2>&1 \ // RUN: | FileCheck -check-prefix=CHECK-LD %s MaskRay wrote: > MaskRay

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

MaskRay added inline comments. Comment at: clang/test/Driver/riscv-args.c:5 // RUN: %clang -### -target riscv32 \ // RUN: --gcc-toolchain= -Xlinker --defsym=FOO=10 -T a.lds %s 2>&1 \ // RUN: | FileCheck -check-prefix=CHECK-LD %s MaskRay wrote: > Just place

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

kito-cheng updated this revision to Diff 355783. kito-cheng added a comment. Address @MaskRay's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105091/new/ https://reviews.llvm.org/D105091 Files: clang/lib/Driver/ToolChains/RISCVToolchain.

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. > -u is a linker option used to pretend a symbol is undefined, this option are > common used for force pull-in weak symbol. for forcing archive member extraction. weak symbols are

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

kito-cheng created this revision. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, sabuasal, simoncook, johnrusso,