[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbdf31471c76b: [Analyzer][solver] Add dump methods for (dis)equality classes. (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong added a comment. In D103967#2864229 , @steakhal wrote: > AFAICT this patch does not introduce significant overhead to the exploded > graph DOT dumps. > Before the patch, an exploded graph took 12G and about 55 secs for a single > top-level funct

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

steakhal added a comment. AFAICT this patch does not introduce significant overhead to the exploded graph DOT dumps. Before the patch, an exploded graph took 12G and about 55 secs for a single top-level function. After the patch, it increased to 13G, and the runtime remained the same as expecte

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong updated this revision to Diff 356504. martong added a comment. - Use std::set for ordering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintMan

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2583 + + llvm::SmallSet MembersStr; + for (std::pair ClassToSymbolSet : Members) Ah, `SmallSet` is not sorted :( I am gonna have to change this to either `std::

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong updated this revision to Diff 356502. martong added a comment. Herald added a subscriber: mgrang. - Change the dump methods to order the equivalence classes and the disequality info available before printing them out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong reopened this revision. martong added a comment. This revision is now accepted and ready to land. I have changed the dump methods to order the equivalence classes and the disequality info available before printing them out. The ordering is done based on their string representation. This

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

thakis added a comment. (here's another flaky failure that was due to this: http://45.33.8.238/mac/33008/step_7.txt ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967 _

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

thakis added a comment. Reverted for now in d5402a2fee5d860e20378f819e200865af3a6113 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

thakis added a comment. Cool, can we revert this for now then? Flakily failing on my m1 bot too: http://45.33.8.238/macm1/12514/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

vsavchenko added a comment. In D103967#2844140 , @thakis wrote: > Thanks. Looks like it flakily fails on mac too every now and then: > http://45.33.8.238/mac/33005/step_7.txt > > Maybe you print something in nondeterministic iteration order? Yes, I thin

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

thakis added a comment. Thanks. Looks like it flakily fails on mac too every now and then: http://45.33.8.238/mac/33005/step_7.txt Maybe you print something in nondeterministic iteration order? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong added a comment. Thanks for the report @thakis ! This seems to be b/c of the different newline handling in windows. I've committed a change that disables the tests on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/40864/step_7.txt Please take a look, and please revert if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f3b775c3e9c: [Analyzer][solver] Add dump methods for (dis)equality classes. (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Awesome, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967 ___

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong added a comment. In D103967#2822287 , @steakhal wrote: > I suspect that the exploded-graph-rewriter should be updated as well so that > the HTML dumps also carry this information. I've put that into a separate patch because that change has its o

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

steakhal added a comment. I suspect that the exploded-graph-rewriter should be updated as well so that the HTML dumps also carry this information. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong added a comment. In D103967#2809590 , @NoQ wrote: > Yes we should definitely have as much as possible in the state dump. Okay, I've updated likewise and added two test files to check them in State->dump. Repository: rG LLVM Github Monorepo

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong updated this revision to Diff 352464. martong added a comment. - Extend printJson to handle equivalency info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967 Files: clang/lib/StaticAnalyzer/Core/

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

NoQ added a comment. Yes we should definitely have as much as possible in the state dump. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967 ___ cfe-commits mailin

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

vsavchenko added a comment. This is definitely useful! Thanks! I was just wondering if we should add it into the state printer instead. @NoQ what's your take on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong updated this revision to Diff 350905. martong added a comment. - Change comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong created this revision. martong added reviewers: vsavchenko, NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus.