martong added a comment.

In D103967#2864229 <https://reviews.llvm.org/D103967#2864229>, @steakhal wrote:

> AFAICT this patch does not introduce significant overhead to the exploded 
> graph DOT dumps.
> Before the patch, an exploded graph took 12G and about 55 secs for a single 
> top-level function.
> After the patch, it increased to 13G, and the runtime remained the same as 
> expected.
>
> Which is about a 1.5 % increase in size in total. TBH I expected slightly 
> higher numbers.
>
> This benchmark was done using a release build with dumps, asserts, and 
> expensive checks.

Thanks Balázs for the benchmark, this makes me confident to commit. Hopefully 
this time the tests won't be flaky.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103967/new/

https://reviews.llvm.org/D103967

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to