[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

This revision was automatically updated to reflect the committed changes. Closed by commit rGa42739055835: [OpenCL] Add support of __opencl_c_images feature macro (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103911/new/ htt

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103911/new/ https://reviews.llvm.org/D103911 __

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

azabaznov updated this revision to Diff 352681. azabaznov added a comment. Set SPIR target for added test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103911/new/ https://reviews.llvm.org/D103911 Files: clang/lib/Sema/SemaType.cpp clang/test/

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/unsupported-image.cl:1 +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=-__opencl_c_images %s +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=+__opencl_c_images %s azabaznov wrote: > Anastasia

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

azabaznov added inline comments. Comment at: clang/test/SemaOpenCL/unsupported-image.cl:1 +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=-__opencl_c_images %s +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=+__opencl_c_images %s Anastasia wrote: > svenvh wro

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/unsupported-image.cl:1 +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=-__opencl_c_images %s +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=+__opencl_c_images %s svenvh wrote: > Should we add

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

svenvh added inline comments. Comment at: clang/test/SemaOpenCL/unsupported-image.cl:1 +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=-__opencl_c_images %s +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=+__opencl_c_images %s Should we add `-triple spir`, as

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o