[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx updated this revision to Diff 413212. ksyx added a comment. Fix patch apply failed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c llvm/lib/Support/RISCVISAInfo

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx updated this revision to Diff 413211. ksyx added a comment. Herald added a subscriber: jdoerfert. Rebase and adapt to new ISAInfo module. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 Files: clang/lib/Basic/Targets/RISCV.cpp clang/t

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

craig.topper added a comment. In D103313#3359628 , @ksyx wrote: > In D103313#3359310 , > @JiahaoChenConor wrote: > >> Hi, do you still continue working on this patch? > > In fact, not pretty sure what else I need

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx added a comment. In D103313#3359310 , @JiahaoChenConor wrote: > Hi, do you still continue working on this patch? In fact, not pretty sure what else I need to improve on this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ http

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

JiahaoChenConor added a comment. Herald added subscribers: pcwang-thead, eopXD, VincentWu, luke957, achieveartificialintelligence. Herald added a project: All. Hi, do you still continue working on this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llv

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx updated this revision to Diff 351083. ksyx added a comment. add: zmmul arch string test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Targets/RISCV.h clang/lib/Driver/ToolCh

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

Jim added a comment. It should add arch string tests such as in clang/test/Driver/riscv-arch.c. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:38 bool HasStdExtM = false; + bool HasStdExtZmmul = false; bool HasStdExtA = false; ksyx wrote: > jrtc27 wrote: > > Ditto > The pattern here seems to be that Z* extensions is fo

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx added a comment. I have took a look into `ELFObjectFile.cpp` but I am not sure what work I need to do there since it seems other Z* extensions are not being handled there. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:38 bool HasStdExtM = false; + bool HasStdExtZ

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx updated this revision to Diff 348608. ksyx marked an inline comment as done. ksyx added a comment. - Move down zmmul lines to fit the ordering - Add Zmmul into parseDirectiveAttribute CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 Files:

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

jrtc27 added a comment. In D103313#2787326 , @jrtc27 wrote: > In D103313#2787316 , @craig.topper > wrote: > >> Do we need to add this to RISCVTargetStreamer::emitTargetAttributes? > > Yes, that, but also RISCVAsm

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

jrtc27 added a comment. In D103313#2787316 , @craig.topper wrote: > Do we need to add this to RISCVTargetStreamer::emitTargetAttributes? Yes, that, but also RISCVAsmParser::parseDirectiveAttribute and ELFObjectFileBase::getRISCVFeatures, though it seem

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

craig.topper added a comment. Do we need to add this to RISCVTargetStreamer::emitTargetAttributes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 ___ cfe-commi

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx created this revision. ksyx added reviewers: asb, craig.topper, luismarques, jrtc27, kito-cheng, rsmith, shiva0217. Herald added subscribers: vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-