jrtc27 added a comment.

In D103313#2787326 <https://reviews.llvm.org/D103313#2787326>, @jrtc27 wrote:

> In D103313#2787316 <https://reviews.llvm.org/D103313#2787316>, @craig.topper 
> wrote:
>
>> Do we need to add this to RISCVTargetStreamer::emitTargetAttributes?
>
> Yes, that, but also RISCVAsmParser::parseDirectiveAttribute and 
> ELFObjectFileBase::getRISCVFeatures, though it seems that last one has been a 
> bit neglected.

(we really need to cut down on how many places parse/produce arch strings...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103313/new/

https://reviews.llvm.org/D103313

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to