[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet abandoned this revision. gchatelet added a comment. In D102760#2802520 , @Quuxplusone wrote: > @gchatelet: Thanks for the link to D102679 > — that seems like very relevant background info I didn't have! Havi

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

Quuxplusone added a comment. @gchatelet: Thanks for the link to D102679 — that seems like very relevant background info I didn't have! Having looked through D102679 , though, I don't see how it would benefit from D102760

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet added a comment. @Quuxplusone thx a lot for the comment. It is very relevant and I agree that this addition may be dangerous. The intend was to prevent adding more constructors (and dependencies) to SmallVector in D102679 . I can try to see what it tak

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

courbet added inline comments. Comment at: clang/include/clang/Basic/Module.h:98 public: + Module(const Module &) = default; + gchatelet wrote: > gchatelet wrote: > > fhahn wrote: > > > how is this related? > > > how is this related? > > > > I'm glad you ask!

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

Quuxplusone added inline comments. Comment at: llvm/include/llvm/ADT/IterableTraits.h:17-31 +namespace detail { + +template auto is_forward_iterator(...) -> std::false_type; + +template +auto is_forward_iterator(int) -> decltype( +std::next(std::declval()),

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet updated this revision to Diff 348228. gchatelet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102760/new/ https://reviews.llvm.org/D102760 Files: clang/include/clang/Basic/Module.h llvm/include/llvm/ADT/Iter

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet added inline comments. Comment at: clang/include/clang/Basic/Module.h:98 public: + Module(const Module &) = default; + fhahn wrote: > how is this related? > how is this related? I'm glad you ask! I'm still investigating the errors that led to this ad

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

fhahn added inline comments. Comment at: clang/include/clang/Basic/Module.h:98 public: + Module(const Module &) = default; + how is this related? Comment at: llvm/tools/llvm-xray/xray-converter.cpp:161 struct StackIdData { + StackIdData(con

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet updated this revision to Diff 346669. gchatelet added a comment. - Forward argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102760/new/ https://reviews.llvm.org/D102760 Files: clang/include/clang/Basic/Module.h llvm/include/llv

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet updated this revision to Diff 346657. gchatelet added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Remove dependency on iterable_range header - Simplified implementation, added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION