Quuxplusone added a comment.

@gchatelet: Thanks for the link to D102679 <https://reviews.llvm.org/D102679> — 
that seems like very relevant background info I didn't have!  Having looked 
through D102679 <https://reviews.llvm.org/D102679>, though, I don't see how it 
would benefit from D102760 <https://reviews.llvm.org/D102760> — in fact, 
D102679 <https://reviews.llvm.org/D102679> updates some tests to wisely 
//stop// depending on the ability to construct `SmallVector` from a range (and 
goes to using begin/end pairs instead — good!).
So I think D102679 <https://reviews.llvm.org/D102679> is a good idea (modulo 
the review comments I just left), and I continue to think that this D102760 
<https://reviews.llvm.org/D102760> is a bad idea that should be abandoned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102760/new/

https://reviews.llvm.org/D102760

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to