[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

hubert.reinterpretcast added a comment. In D102723#2790047 , @bjope wrote: > I relaxed the checks a bit again here: https://reviews.llvm.org/rGf0e10cc91bc4 > But it looks like the workers here > (https://lab.llvm.org/staging/#/workers/109) are paused so

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

hubert.reinterpretcast added a subscriber: gkistanova. hubert.reinterpretcast added a comment. In D102723#2790047 , @bjope wrote: > But it looks like the workers here > (https://lab.llvm.org/staging/#/workers/109) are paused so hard to tell if it > help

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

bjope added a comment. I relaxed the checks a bit again here: https://reviews.llvm.org/rGf0e10cc91bc4 But it looks like the workers here (https://lab.llvm.org/staging/#/workers/109) are paused so hard to tell if it helped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

yaxunl added a comment. In D102723#2789610 , @bjope wrote: > In D102723#2789537 , @yaxunl wrote: > >> It seems we cannot introduce `ROOT` by line 19 since it is not used in other >> lines in situations where work

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

bjope added a comment. In D102723#2789537 , @yaxunl wrote: > It seems we cannot introduce `ROOT` by line 19 since it is not used in other > lines in situations where working directories have sym links. > > Instead, we just change `{{.*}}clang/` to `{{.*}

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

yaxunl added a comment. It seems we cannot introduce `ROOT` by line 19 since it is not used in other lines in situations where working directories have sym links. Instead, we just change `{{.*}}clang/` to `{{.*}}/lib/clang/` in other lines. Hopefully this will still work. Repository: rG LLV

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

hubert.reinterpretcast added a comment. This change is causing failures when the build is done from a working directory that has symlinks: https://lab.llvm.org/staging/#/builders/126/builds/529/steps/5/logs/FAIL__Clang__hip-include-path_hip Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

This revision was automatically updated to reflect the committed changes. Closed by commit rG722c39fef5ab: [HIP] Tighten checks in hip-include-path.hip test case (authored by bjope). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102723/new/ https://

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102723/new/ https://reviews.llvm.org/D102723 __

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

bjope created this revision. bjope added reviewers: yaxunl, tra, zhuhan0. bjope requested review of this revision. Herald added a project: clang. The checks (both positive and negative checks) in the test case hip-include-path.hip could mistakenly end up matching the string "clang" from the Instal