bjope added a comment.

In D102723#2789537 <https://reviews.llvm.org/D102723#2789537>, @yaxunl wrote:

> It seems we cannot introduce `ROOT` by line 19 since it is not used in other 
> lines in situations where working directories have sym links.
>
> Instead, we just change `{{.*}}clang/` to `{{.*}}/lib/clang/` in other lines. 
> Hopefully this will still work.

Ok. That probably works.

A bit surprised though. I found checks using InstalledDir in other test cases 
such as clang/test/Friver/stdlibxx-isystem.cpp, so I figured it would be safe 
to use that also in this test case. So I wonder how other tests that captures 
InstalledDir could work for the symlink-bots.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102723/new/

https://reviews.llvm.org/D102723

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to