[PATCH] D101516: Introduce clangd-server-monitor tool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34593ae9982a: Introduce clangd-server-monitor tool (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D101516: Introduce clangd-server-monitor tool

kbobyrev updated this revision to Diff 342693. kbobyrev added a comment. Remove leftover --with-monitor from the lit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101516/new/ https://reviews.llvm.org/D101516 Files: clang-tools-extra/clangd

[PATCH] D101516: Introduce clangd-server-monitor tool

kbobyrev updated this revision to Diff 342692. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve post-LGTM comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101516/new/ https://reviews.llvm.org/D101516 Files: cla

[PATCH] D101516: Introduce clangd-server-monitor tool

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, let's ship it! Comment at: clang-tools-extra/clangd/index/remote/monitor/Monitor.cpp:15 +#include "llvm/Support/CommandLine.h" +#include "llvm/Support/FormatVaria

[PATCH] D101516: Introduce clangd-server-monitor tool

kbobyrev updated this revision to Diff 342689. kbobyrev added a comment. Remove (now) unused Python JSON import. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101516/new/ https://reviews.llvm.org/D101516 Files: clang-tools-extra/clangd/index/rem

[PATCH] D101516: Introduce clangd-server-monitor tool

kbobyrev updated this revision to Diff 342688. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101516/new/ https://reviews.llvm.org/D101516 Files: clang-t

[PATCH] D101516: Introduce clangd-server-monitor tool

kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:77 + index_server_monitor_process.wait() + for line in index_server_monitor_process.stderr: +args.server_log.write(line) logs for index-server and moni

[PATCH] D101516: Introduce clangd-server-monitor tool

kbobyrev updated this revision to Diff 341925. kbobyrev added a comment. Inline gRPC deadline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101516/new/ https://reviews.llvm.org/D101516 Files: clang-tools-extra/clangd/index/remote/CMakeLists.txt

[PATCH] D101516: Introduce clangd-server-monitor tool

kbobyrev updated this revision to Diff 341922. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101516/new/ https://reviews.llvm.org/D101516 Files: clang-

[PATCH] D101516: Introduce clangd-server-monitor tool

kadircet added a comment. thanks for doing this! can we also have a lit test? we already have some tests spinning up an index-server, i suppose we can make an extra rpc to those and ensure we get a success response? Comment at: clang-tools-extra/clangd/index/remote/monitor/CM

[PATCH] D101516: Introduce clangd-server-monitor tool

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, mgorny. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Gi