kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, let's ship it!
================
Comment at: clang-tools-extra/clangd/index/remote/monitor/Monitor.cpp:15
+#include "llvm/Support/CommandLine.h"
+#include "llvm/Support/FormatVariadic.h"
+#include "llvm/Support/Signals.h"
----------------
nit: this is probably not needed now as we dropped formatv
================
Comment at: clang-tools-extra/clangd/index/remote/monitor/Monitor.cpp:72
+ Response.DebugString(), JsonStatus.error_code(),
+ JsonStatus.error_message());
+ return -1;
----------------
nit: i am not sure if this really compiles (was testing it for status-updater
patch on gcp). as this is a stringpiece, so you might wanna call
ToString/as_string on it.
================
Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:33
parser.add_argument('--server-log', nargs='?', type=argparse.FileType('wb'),
default=os.devnull)
+ parser.add_argument('--with-monitor', action='store_true')
----------------
nit: as discussed offline this is only to save some runtime on tests that don't
care about it. I'd probably drop this and add later if we feel the need, but up
to you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101516/new/
https://reviews.llvm.org/D101516
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
