zahiraam wrote:
> Aldo, update OpenMPSupport page
Question about this. I see that the table for `OpenMP 6.0 Implementation
Details` chapter has an entry for `Loop transformation constructs`. Should the
`#pragma omp stripe` be listed here as a bullet item? Do you have a preference
of how this
zahiraam wrote:
> Please resolve open feedback items before the next round of reviews. Thanks.
Sorry I might have been ahead of myself!
I think this time I might have gotten it.
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing
@@ -19,6 +19,8 @@ typedef void *omp_depend_t;
void foo() {}
void tmainc(){
omp_depend_t obj;
+ int omp_all_memory;
zahiraam wrote:
Removed.
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits maili
zahiraam wrote:
@alexey-bataev, @kparzysz can you please review this? Thanks.
https://github.com/llvm/llvm-project/pull/119891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
@mjklemm, @saiislam can you please review this? Thanks.
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5621,6 +5623,81 @@ class OMPTileDirective final : public
OMPLoopTransformationDirective {
}
};
+class OMPStripeDirective final : public OMPLoopTransformationDirective {
+ friend class ASTStmtReader;
+ friend class OMPExecutableDirective;
+
+ /// Default list of offse
@@ -68,15 +70,15 @@ int fun(int arg) {
{}
#pragma omp target map(mapper(aa :vv) //
expected-error {{use of undeclared identifier 'aa'}} expected-error {{expected
')'}} expected-error {{call to undeclared function 'mapper'}} expected-note
@@ -68,15 +70,15 @@ int fun(int arg) {
{}
#pragma omp target map(mapper(aa :vv) //
expected-error {{use of undeclared identifier 'aa'}} expected-error {{expected
')'}} expected-error {{call to undeclared function 'mapper'}} expected-note
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/122339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
@mjklemm and @saiislam would you mind taking a look at this please? Thanks.
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/122339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/122339
None
>From d8268afeafb61f95f1fa917ab26214e84372eba3 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 9 Jan 2025 10:58:29 -0800
Subject: [PATCH] Initialize value.
---
.../clang-tidy/modernize/Use
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> Not sure this level of support is enough to make 6.0 the default version.
> We're missing support for some 5.2 features still
That's what I thought! So the macro should continue being set to `202011?
https://github.com/llvm/llvm-project/pull/122108
___
@@ -1179,6 +1179,13 @@ def OMP_Tile : Directive<"tile"> {
let association = AS_Loop;
let category = CA_Executable;
}
+def OMP_Stripe : Directive<"stripe"> {
+ let allowedOnceClauses = [
+VersionedClause,
zahiraam wrote:
@alexey-bataev draft PR for thi
zahiraam wrote:
@alexey-bataev Can you please take a look at this draft PR? I think there are
still some LIT tests failing but I want to make sure the changes I am proposing
are correct before making further changes. I am not sure if the macro `_OPENMP`
should be set to `202411` or if it shoul
https://github.com/zahiraam converted_to_draft
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5621,6 +5623,81 @@ class OMPTileDirective final : public
OMPLoopTransformationDirective {
}
};
+class OMPStripeDirective final : public OMPLoopTransformationDirective {
+ friend class ASTStmtReader;
+ friend class OMPExecutableDirective;
+
+ /// Default list of offse
@@ -5621,6 +5623,81 @@ class OMPTileDirective final : public
OMPLoopTransformationDirective {
}
};
+class OMPStripeDirective final : public OMPLoopTransformationDirective {
+ friend class ASTStmtReader;
+ friend class OMPExecutableDirective;
+
+ /// Default list of offse
@@ -1179,6 +1179,13 @@ def OMP_Tile : Directive<"tile"> {
let association = AS_Loop;
let category = CA_Executable;
}
+def OMP_Stripe : Directive<"stripe"> {
+ let allowedOnceClauses = [
+VersionedClause,
zahiraam wrote:
I see. In this case I think it
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/119891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1179,6 +1179,13 @@ def OMP_Tile : Directive<"tile"> {
let association = AS_Loop;
let category = CA_Executable;
}
+def OMP_Stripe : Directive<"stripe"> {
+ let allowedOnceClauses = [
+VersionedClause,
zahiraam wrote:
I have set it to `51` but I thi
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/119891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/119891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/119741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/119741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/119741
None
>From 440554df79ebc7c8971c4af928f623b13c95c6ee Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 4 Dec 2024 12:54:41 -0800
Subject: [PATCH 1/2] [NFC] Use a move instead of a copy to optimize
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/119741
>From 440554df79ebc7c8971c4af928f623b13c95c6ee Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 4 Dec 2024 12:54:41 -0800
Subject: [PATCH 1/3] [NFC] Use a move instead of a copy to optimize
perfor
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/118664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -501,6 +501,7 @@ class PreambleThread {
}
{
+std::unique_lock Lock(Mutex);
WithContext Guard(std::move(CurrentReq->Ctx));
zahiraam wrote:
Thanks @tahonermann. I had forgotten about it. Closing it.
https://github.com/llvm/llvm-
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/118699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/118655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
Thanks @AaronBallman . I think it makes more sense to have `=delete` instead of
`=default`. I changed them. @HerrCai0907 what do you think of these changes? If
you think they are useless we can consider these a false positive from the
analyzer and ignore them all together.
htt
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/118655
>From 3b93252fa52c4055e8c294784056697e92299b9b Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 4 Dec 2024 07:24:20 -0800
Subject: [PATCH 1/3] [NFC] Complete proper copying and resource cleanup in
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/118699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/118324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/118664
>From 35f795549d25ec1358b54ebd3f2176cf8e49aeff Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 4 Dec 2024 08:23:12 -0800
Subject: [PATCH 1/2] [NFC] Avoid data race condition.
---
clang-tools-ext
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/118699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/118699
None
>From 440554df79ebc7c8971c4af928f623b13c95c6ee Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 4 Dec 2024 12:54:41 -0800
Subject: [PATCH] [NFC] Use a move instead of a copy to optimize perfo
@@ -58,10 +58,10 @@ getDerivedParameter(const ClassTemplateSpecializationDecl
*CRTP,
Arg.getAsType()->getAsCXXRecordDecl() == Derived;
});
- return AnyOf ? CRTP->getSpecializedTemplate()
- ->getTemplateParameters()
-
@@ -58,10 +58,10 @@ getDerivedParameter(const ClassTemplateSpecializationDecl
*CRTP,
Arg.getAsType()->getAsCXXRecordDecl() == Derived;
});
- return AnyOf ? CRTP->getSpecializedTemplate()
- ->getTemplateParameters()
-
zahiraam wrote:
> _ No description provided. _
https://github.com/llvm/llvm-project/pull/118528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/118528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
@HighCommander4 Is that good as a change? Do you still want an issue to be
opened?
@tahonermann can you please review? Thanks.
https://github.com/llvm/llvm-project/pull/118324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/118655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/118655
None
>From 3b93252fa52c4055e8c294784056697e92299b9b Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 4 Dec 2024 07:24:20 -0800
Subject: [PATCH] [NFC] Complete proper copying and resource cleanup i
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/118664
None
>From 35f795549d25ec1358b54ebd3f2176cf8e49aeff Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 4 Dec 2024 08:23:12 -0800
Subject: [PATCH] [NFC] Avoid data race condition.
---
clang-tools-e
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/118655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/118655
>From 3b93252fa52c4055e8c294784056697e92299b9b Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 4 Dec 2024 07:24:20 -0800
Subject: [PATCH 1/2] [NFC] Complete proper copying and resource cleanup in
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/118528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/118528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/118528
None
>From 59904d85cece9758dbb449ae4180ee5f917d0263 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 3 Dec 2024 10:53:22 -0800
Subject: [PATCH] [NFC] Fix potential underflow constant.
---
.../bu
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/118324
>From 4142b5bd36a4f7a554196687e191a09dba9e4dcf Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 2 Dec 2024 09:09:21 -0800
Subject: [PATCH 1/4] [NFC] Fix uninitialized data member in constructor.
-
zahiraam wrote:
> idxcontents is only used when we have a set of file names available. hence
> this was only set via relevant constructors and rest of the runtime doesn't
> use the field.
>
> but we don't construct tons of new index instances every second. so it's
> totally fine to just initi
zahiraam wrote:
> Seems like `MemIndex::IdxContents` has the same issue.
>
> It's a bit suspicious to me that the other `DexIndex` and `MemIndex`
> constructors are not passing in an `IndexContents` value. Either there's a
> bug lurking there, or the field is only relevant in certain situation
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/118324
>From 4142b5bd36a4f7a554196687e191a09dba9e4dcf Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 2 Dec 2024 09:09:21 -0800
Subject: [PATCH 1/3] [NFC] Fix uninitialized data member in constructor.
-
zahiraam wrote:
> How did you decide on `IndexContents::All` as the default initialization
> value. I would be more inclined towards `IndexContents::None`.
>
> I think it would be preferred to use a member initializer in the declaration
> of `IdxContents`. That will ensure an initialization is
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/118324
None
>From 4142b5bd36a4f7a554196687e191a09dba9e4dcf Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 2 Dec 2024 09:09:21 -0800
Subject: [PATCH] [NFC] Fix uninitialized data member in constructor.
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/118324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/118324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/118324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/118324
>From 4142b5bd36a4f7a554196687e191a09dba9e4dcf Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Mon, 2 Dec 2024 09:09:21 -0800
Subject: [PATCH 1/2] [NFC] Fix uninitialized data member in constructor.
-
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/117769
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/117769
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/117769
None
>From 27925c327d9f3164e3ba966ffaed5715681480fd Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 21 Nov 2024 07:03:46 -0800
Subject: [PATCH 1/3] [NFC] Fix uninitialized pointer field.
---
cl
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/117331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/117331
None
>From 27925c327d9f3164e3ba966ffaed5715681480fd Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 21 Nov 2024 07:03:46 -0800
Subject: [PATCH 1/2] [NFC] Fix uninitialized pointer field.
---
cl
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/117173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/117173
>From 27925c327d9f3164e3ba966ffaed5715681480fd Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 21 Nov 2024 07:03:46 -0800
Subject: [PATCH 1/2] [NFC] Fix uninitialized pointer field.
---
clang-to
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/117173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/117173
None
>From 27925c327d9f3164e3ba966ffaed5715681480fd Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 21 Nov 2024 07:03:46 -0800
Subject: [PATCH] [NFC] Fix uninitialized pointer field.
---
clang-
@@ -1684,6 +1684,15 @@ class CompoundStmt final
return hasStoredFPFeatures() ? getStoredFPFeatures() : FPOptionsOverride();
}
+ /// Get FPOptions inside this statement. They may differ from the outer
+ /// options due to pragmas.
+ /// \param CurFPOptions FPOptions ou
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -ffast-math -ffp-contract=fast -emit-llvm -o - %s |
FileCheck %s
+// RUN: %clang_cc1 -ffast-math -ffp-contract=fast -emit-llvm -O2 -o - %s |
FileCheck %s
zahiraam wrote:
It seems to me that this issue exists only at O2, right
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/111654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam commented:
You seem to have some fails in the CI.
https://github.com/llvm/llvm-project/pull/111654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
Not very clear to me what the issue is. Can you please explain this in the
description. I think here the `#pragma float_control(precise, on)` should be
taking precedence over the `-ffast-math` flag and it's not. Right?
https://github.com/llvm/llvm-project/pull/105912
_
zahiraam wrote:
This is a duplicate solution of
https://github.com/llvm/llvm-project/pull/108853. Closing it if no objection
from reviewers.
https://github.com/llvm/llvm-project/pull/107598
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
https://github.com/zahiraam approved this pull request.
https://github.com/llvm/llvm-project/pull/108853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
OK. This LGTM. I guess we can adopt this PR instead of
https://github.com/llvm/llvm-project/pull/107598 unless other reviewers have
more to say.
https://github.com/llvm/llvm-project/pull/108853
___
cfe-commits mailing list
cfe-commit
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/107397
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/107397
>From 621578de568be1e71665254060956ea1971965c9 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 5 Sep 2024 05:42:26 -0700
Subject: [PATCH 1/9] [NFC] Move warning from COdeGen to Sema.
---
clang/i
zahiraam wrote:
> > Not really! int TBAA in in our downstream compiler is interpreted as
> > describing the function arguments (they are not int) and the load/store of
> > the argument before the library call are begin eliminated which result in
> > unexpected behavior.
>
> Oh wait, then you
zahiraam wrote:
> > > > > > How does this interact with #107598?
> > > > >
> > > > >
> > > > > Though this also changes things to ensure when TBAA data is set, it's
> > > > > always set on the call.
> > > >
> > > >
> > > > Wasn't already doing that? (setting the TBAA on the call?).
> > >
>
zahiraam wrote:
> > > > How does this interact with #107598?
> > >
> > >
> > > Though this also changes things to ensure when TBAA data is set, it's
> > > always set on the call.
> >
> >
> > Wasn't already doing that? (setting the TBAA on the call?).
>
> It was setting it on `cast(Call.getS
zahiraam wrote:
> > How does this interact with #107598?
>
>Though this also changes things to ensure when TBAA data is set, it's always
>set on the call.
Wasn't already doing that? (setting the TBAA on the call?).
https://github.com/llvm/llvm-project/pull/108853
_
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/107598
>From 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 6 Sep 2024 08:01:25 -0700
Subject: [PATCH 1/7] Don't emit int TBAA metadata on more complex FP math
@@ -0,0 +1,31 @@
+// RUN: %clang_cc1 %s -O3 -fmath-errno -emit-llvm -triple
x86_64-unknown-unknown -o - %s | FileCheck %s -check-prefixes=CHECK
+// RUN: %clang_cc1 %s -O3 -fmath-errno -emit-llvm -triple x86_64-pc-win64 -o -
%s | FileCheck %s -check-prefixes=CHECK
+// RUN: %clan
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/107598
>From 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 6 Sep 2024 08:01:25 -0700
Subject: [PATCH 1/6] Don't emit int TBAA metadata on more complex FP math
@@ -7964,6 +7964,12 @@ class Sema final : public SemaBase {
/// Do an explicit extend of the given block pointer if we're in ARC.
void maybeExtendBlockObject(ExprResult &E);
+ std::vector>
+ ExcessPrecisionNotSatisfied;
+ unsigned NumExcessPrecisionNotSatisfied = 0;
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/107397
>From 621578de568be1e71665254060956ea1971965c9 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 5 Sep 2024 05:42:26 -0700
Subject: [PATCH 1/8] [NFC] Move warning from COdeGen to Sema.
---
clang/i
zahiraam wrote:
Let's see if this is better.
https://github.com/llvm/llvm-project/pull/107397
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/107397
>From 621578de568be1e71665254060956ea1971965c9 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 5 Sep 2024 05:42:26 -0700
Subject: [PATCH 1/7] [NFC] Move warning from COdeGen to Sema.
---
clang/i
@@ -21,6 +25,7 @@ void a() {
EVALF((2. + 3i) + (4. + 5i), 6. + 8i);
EVALF((2. + 3i) - (4. + 5i), -2. - 2i);
EVALF((2. + 3i) * (4. + 5i), -7. + 22i);
+ // div-precision-warning@+1 {{excess precision is requested but the target
does not support excess precision which may
@@ -21,6 +25,7 @@ void a() {
EVALF((2. + 3i) + (4. + 5i), 6. + 8i);
EVALF((2. + 3i) - (4. + 5i), -2. - 2i);
EVALF((2. + 3i) * (4. + 5i), -7. + 22i);
+ // div-precision-warning@+1 {{excess precision is requested but the target
does not support excess precision which may
@@ -6784,6 +6784,11 @@ def warn_arc_lifetime_result_type : Warning<
"ARC %select{unused|__unsafe_unretained|__strong|__weak|__autoreleasing}0 "
"lifetime qualifier on return type is ignored">,
InGroup;
+def warn_excess_precision_not_supported : Warning<
+ "excess precisi
zahiraam wrote:
> double foo();
> double d = 2.0 * foo();
That's correct. Only for division and only `-fcomplex-arithmetic=promoted` and
when the higher precision type of a target is the same than the current
precision type.
https://github.com/llvm/llvm-project/pull/107397
___
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/107598
>From 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 6 Sep 2024 08:01:25 -0700
Subject: [PATCH 1/5] Don't emit int TBAA metadata on more complex FP math
1 - 100 of 658 matches
Mail list logo
