[clang] Fix Lambda Mangling in Namespace-Scope Variable Initializers. (PR #159115)

2025-09-22 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/159115 >From b197e92e844472ccef1999cac653a76109183ee4 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 16 Sep 2025 08:47:40 -0700 Subject: [PATCH 01/10] Fix Lambda Mangling in Namespace-Scope Variable In

[clang-tools-extra] [Clangd] [NFC] Fix dereference of null value (PR #159566)

2025-09-20 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/159566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clangd] [NFC] Fix dereference of null value (PR #159566)

2025-09-20 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/159566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix Lambda Mangling in Namespace-Scope Variable Initializers. (PR #159115)

2025-09-20 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/159115 >From b197e92e844472ccef1999cac653a76109183ee4 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 16 Sep 2025 08:47:40 -0700 Subject: [PATCH 1/9] Fix Lambda Mangling in Namespace-Scope Variable Init

[clang] Fix Lambda Mangling in Namespace-Scope Variable Initializers. (PR #159115)

2025-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/159115 >From b197e92e844472ccef1999cac653a76109183ee4 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 16 Sep 2025 08:47:40 -0700 Subject: [PATCH 1/7] Fix Lambda Mangling in Namespace-Scope Variable Init

[clang] Fix Lambda Mangling in Namespace-Scope Variable Initializers. (PR #159115)

2025-09-19 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: Thanks @tahonermann for finding the solution to the issue about the missing strings! Let me know if the changes in the tests are as expected. Meanwhile I will be working on creating more tests as Richard requested. https://github.com/llvm/llvm-project/pull/159115 _

[clang] Fix Lambda Mangling in Namespace-Scope Variable Initializers. (PR #159115)

2025-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/159115 >From b197e92e844472ccef1999cac653a76109183ee4 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 16 Sep 2025 08:47:40 -0700 Subject: [PATCH 1/8] Fix Lambda Mangling in Namespace-Scope Variable Init

[clang] Fix Lambda Mangling in Namespace-Scope Variable Initializers. (PR #159115)

2025-09-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/159115 >From b197e92e844472ccef1999cac653a76109183ee4 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 16 Sep 2025 08:47:40 -0700 Subject: [PATCH 1/6] Fix Lambda Mangling in Namespace-Scope Variable Init

[clang-tools-extra] [Clangd] [NFC] Fix dereference of null value (PR #159566)

2025-09-18 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/159566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clangd] [NFC] Fix dereference of null value (PR #159566)

2025-09-18 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/159566 >From 5b78181faf98d419ad96b95c089e6046e604a104 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 18 Sep 2025 05:50:57 -0700 Subject: [PATCH 1/3] [Clangd] Fix dereference of null value --- clang-to

[clang-tools-extra] [Clangd] [NFC] Fix dereference of null value (PR #159566)

2025-09-18 Thread Zahira Ammarguellat via cfe-commits
@@ -145,8 +145,11 @@ std::string getQualification(ASTContext &Context, for (const auto *CurD : llvm::reverse(Parents)) { if (auto *TD = llvm::dyn_cast(CurD)) { QualType T; - if (const auto *RD = dyn_cast(TD); - ClassTemplateDecl *CTD = RD->getDescribed

[clang-tools-extra] [Clangd] [NFC] Fix dereference of null value (PR #159566)

2025-09-18 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/159566 >From 5b78181faf98d419ad96b95c089e6046e604a104 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 18 Sep 2025 05:50:57 -0700 Subject: [PATCH 1/2] [Clangd] Fix dereference of null value --- clang-to

[clang-tools-extra] [Clangd] Fix dereference of null value (PR #159566)

2025-09-18 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/159566 None >From 5b78181faf98d419ad96b95c089e6046e604a104 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 18 Sep 2025 05:50:57 -0700 Subject: [PATCH] [Clangd] Fix dereference of null value --- clang-

[clang-tools-extra] [Clangd] Fix dereference of null value (PR #159566)

2025-09-18 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/159566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clangd] Fix dereference of null value (PR #159566)

2025-09-18 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/159566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix Lambda Mangling in Namespace-Scope Variable Initializers. (PR #159115)

2025-09-17 Thread Zahira Ammarguellat via cfe-commits
@@ -47,7 +47,19 @@ int main() { // Make sure the following 3 are the same between the host and device compile. // Note that these are NOT the same value as each other, they differ by the // signature. - // CHECK: private unnamed_addr [[$ADDRSPACE]]constant [17 x i8] c"

[clang] Fix Lambda Mangling in Namespace-Scope Variable Initializers. (PR #159115)

2025-09-17 Thread Zahira Ammarguellat via cfe-commits
@@ -47,7 +47,19 @@ int main() { // Make sure the following 3 are the same between the host and device compile. // Note that these are NOT the same value as each other, they differ by the // signature. - // CHECK: private unnamed_addr [[$ADDRSPACE]]constant [17 x i8] c"

[clang] [flang] [clang][OpenMP] Diagnose invalid allocator in `#pragma omp allocate`; avoid null deref (PR #158146)

2025-09-17 Thread Zahira Ammarguellat via cfe-commits
@@ -0,0 +1,22 @@ +! RUN: %flang_fc1 -fopenmp -emit-hlfir %s -o - | FileCheck %s + +program p + type y3; integer, allocatable :: x; end type + type(y3) :: v + integer :: s, n, i + s = 1; n = 10 + allocate(v%x); v%x = 0 +!$omp parallel + if (.not. allocated(v%x)) print *, '101

[clang] Fix Lambda Mangling in Namespace-Scope Variable Initializers. (PR #159115)

2025-09-17 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/159115 >From b197e92e844472ccef1999cac653a76109183ee4 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 16 Sep 2025 08:47:40 -0700 Subject: [PATCH 1/2] Fix Lambda Mangling in Namespace-Scope Variable Init

[clang] Fix Lambda Mangling in Namespace-Scope Variable Initializers. (PR #159115)

2025-09-17 Thread Zahira Ammarguellat via cfe-commits
@@ -1,5 +1,5 @@ -// RUN: %clang_cc1 -triple spir64-unknown-unknown -aux-triple x86_64-pc-windows-msvc -fsycl-is-device -disable-llvm-passes -emit-llvm %s -o - | FileCheck %s '-D$ADDRSPACE=addrspace(1) ' -// RUN: %clang_cc1 -triple x86_64-pc-windows-msvc -fsycl-is-host -disable-

[clang] [flang] [clang][OpenMP] Diagnose invalid allocator in `#pragma omp allocate`; avoid null deref (PR #158146)

2025-09-17 Thread Zahira Ammarguellat via cfe-commits
@@ -0,0 +1,13 @@ +// RUN: %clang_cc1 -fopenmp -verify %s +// No ; forge a typedef. +typedef enum omp_allocator_handle_t { + omp_default_mem_alloc = 1, + __omp_allocator_handle_t_max__ = __UINTPTR_MAX__ +} omp_allocator_handle_t; + +void foo(void) { + omp_allocator_handle_t my_h

[clang] Fix Lambda Mangling in Namespace-Scope Variable Initializers. (PR #159115)

2025-09-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/159115 This PR addresses an issue with the mangling of lambdas used as initializers for global variables within namespaces. According to the `Itanium C++ AB`I, lambdas should be uniquely mangled based on their contex

[clang] [clang][driver] Improve warning message for complex range overrides (PR #154899)

2025-09-04 Thread Zahira Ammarguellat via cfe-commits
@@ -2730,17 +2730,38 @@ static void CollectArgsForIntegratedAssembler(Compilation &C, } } -static std::string ComplexArithmeticStr(LangOptions::ComplexRangeKind Range) { - return (Range == LangOptions::ComplexRangeKind::CX_None) - ? "" - : "-fcomple

[clang] [clang][driver] Improve warning message for complex range overrides (PR #154899)

2025-09-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam approved this pull request. https://github.com/llvm/llvm-project/pull/154899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][driver] Improve warning message for complex range overrides (PR #154899)

2025-09-02 Thread Zahira Ammarguellat via cfe-commits
@@ -2730,17 +2730,38 @@ static void CollectArgsForIntegratedAssembler(Compilation &C, } } -static std::string ComplexArithmeticStr(LangOptions::ComplexRangeKind Range) { - return (Range == LangOptions::ComplexRangeKind::CX_None) - ? "" - : "-fcomple

[clang] [Clang][OpenMP] Fixing Clang error for metadirective with multiple when clauses and no otherwise (PR #148583)

2025-08-05 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam approved this pull request. Looks good. Thanks. https://github.com/llvm/llvm-project/pull/148583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Trying to fix undefined symbol error caused by iterator variable (PR #141507)

2025-07-25 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: The reproducer is passing with clang. See https://godbolt.org/z/adnjMndGq https://github.com/llvm/llvm-project/pull/141507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [Clang][OpenMP] Fixing Clang error for metadirective with multiple when clauses and no otherwise (PR #148583)

2025-07-21 Thread Zahira Ammarguellat via cfe-commits
@@ -108,6 +108,12 @@ void foo1(void) { : parallel) otherwise(parallel for) for (int i=0; i<10; i++) ; + +#pragma omp metadirective when(user = {condition(1)} \ + : parallel for)

[clang] [Clang][OpenMP] Fixing Clang error for metadirective with multiple when clauses and no otherwise (PR #148583)

2025-07-17 Thread Zahira Ammarguellat via cfe-commits
@@ -108,6 +108,12 @@ void foo1(void) { : parallel) otherwise(parallel for) for (int i=0; i<10; i++) ; + +#pragma omp metadirective when(user = {condition(1)} \ + : parallel for)

[clang] [clang][driver] Improve warning message for complex range overrides and GCC incompatibility (PR #149028)

2025-07-16 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: **IMHO** this is going to be way too complicated, and we should stick to have the last command wins in clang even when incompatibility with GCC occurs. IIRC GCC is not even consistent with the combination of these flags. Adding the `-ffast-math` flag on top of all this, will de

[clang] [Clang] Fix clang crash for fopenmp statement(parallel for) inside lambda function (PR #146772)

2025-07-07 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: The test in issue https://github.com/llvm/llvm-project/issues/146335 doesn't seem to be crashing for me! You are using it as a LIT test for the patch. Shouldn't there be a use of a `parallel-for` as the issue's title suggest? https://github.com/llvm/llvm-project/pull/146772 __

[clang-tools-extra] [clang-tidy] [NFC] Potential dereference of nullptr. (PR #143145)

2025-07-07 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/143145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Potential dereference of nullptr. (PR #143145)

2025-06-06 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/143145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] [NFC] Potential dereference of nullptr. (PR #143145)

2025-06-06 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/143145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Potential dereference of nullptr (PR #143145)

2025-06-06 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/143145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] [NFC] Potential dereference of nullptr. (PR #143145)

2025-06-06 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/143145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] [NFC] Potential dereference of nullptr. (PR #143145)

2025-06-06 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/143145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Potential dereference of nullptr. (PR #143145)

2025-06-06 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam unassigned https://github.com/llvm/llvm-project/pull/143145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Potential dereference of nullptr. (PR #143145)

2025-06-06 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam unassigned https://github.com/llvm/llvm-project/pull/143145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Potential dereference of nullptr (PR #143145)

2025-06-06 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/143145 None >From 4c96c31a91a62a20b13e450cf890eea4d18fef3a Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Fri, 6 Jun 2025 07:06:49 -0700 Subject: [PATCH] [clang-tidy] Potential dereference of nullptr ---

[clang] [llvm] [CLANG] Add support of shared attribute for the pragma section. (PR #128197)

2025-05-27 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/128197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [CLANGD] [NFC] Fix proposed by static analyzer. (PR #140116)

2025-05-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/140116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [CLANGD] [NFC] Fix proposed by static analyzer. (PR #140116)

2025-05-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/140116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [CLANGD] [NFC] Fix proposed by sanitizer. (PR #140116)

2025-05-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/140116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [CLANGD] Fix proposed by sanitizer. (PR #140116)

2025-05-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/140116 This fixes an issue reported by the sanitizer with the following error message: `copy_constructor_call: IndexOpts` is passed by value as a parameter to` clang::index::IndexingOptions::IndexingOptions` instead o

[clang] [clang] rename FPOptions.def's macro to FP_OPTION (PR #138374)

2025-05-06 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam approved this pull request. Looks good. Thanks. https://github.com/llvm/llvm-project/pull/138374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] rename FPOptions.def's macro to FP_OPTION (PR #138374)

2025-05-06 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: May be an [NFC] in the title of the PR? https://github.com/llvm/llvm-project/pull/138374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Complete the revert of 1a14ef1 (PR #138341)

2025-05-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam approved this pull request. Looks good. Thanks. https://github.com/llvm/llvm-project/pull/138341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-05-02 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Two of the fixes were to code that was removed while resolving the merge > conflict on the LANG_OPT declaration, I thought with the revert of > [c2a62af](https://github.com/llvm/llvm-project/commit/c2a62af2a51d58183bcd72ee8a86c37ddd526758) > I got all the changes but I'll rec

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-05-02 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: @ojhunt I think there a more than one revert. Can you please read from https://github.com/llvm/llvm-project/issues/137600#issuecomment-2842037532 to see all the reverts that need to be done. Thanks. https://github.com/llvm/llvm-project/pull/137661 __

[clang-tools-extra] [NFC] Fix potential nullptr dereference. (PR #138283)

2025-05-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/138283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix potential nullptr dereference. (PR #138283)

2025-05-02 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: Thanks for your input. I will close this PR. https://github.com/llvm/llvm-project/pull/138283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix potential nullptr dereference. (PR #138283)

2025-05-02 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > This is not needed IMO. This is a simple matcher, `op` is expected to always > be bound. > > One might say that it can't hurt to add extra checks, but I don't think > that's good justification for adding more code / bloat, even if in this case > it's a single line. Still, 5%

[clang-tools-extra] [NFC] Fix potential nullptr dereference. (PR #138283)

2025-05-02 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Did you run code sanitizer over all clang-tidy code or you only interested in > this particular file? I think there are many more places where such `nullptr` > dereference can happen, e.g. > > https://github.com/llvm/llvm-project/blob/52d2b589b2d7adc3e2b4ea503df4131e088de61f/

[clang-tools-extra] [NFC] Fix potential nullptr dereference. (PR #138283)

2025-05-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/138283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix potential nullptr dereference. (PR #138283)

2025-05-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/138283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix potential nullptr dereference. (PR #138283)

2025-05-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/138283 A `nullptr` dereference is signaled by the code sanitizer. Adding an assert to make sure it's caught. Rate limit · GitHub body { background-color: #f6f8fa;

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-05-02 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: @ojhunt In https://github.com/llvm/llvm-project/issues/137600 there are a list of a few temporary PRs that were merged in to silence the warning. These need to be reverted after this one gets merged in. Do you want to revert them or you want me to do that? https://github.com/

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-05-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam approved this pull request. Looks good. Thanks. https://github.com/llvm/llvm-project/pull/137661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-05-02 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: @ojhunt Please go ahead and merge this in. Thanks for your patience. https://github.com/llvm/llvm-project/pull/137661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-05-01 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > I think this is a reasonable way forward for right now; we can bring back the > enumerator once we're actually using it. WDYT @zahiraam ? I tend to think so too. But I am waiting for a response from the math library people internally to make sure that we don't loose compatibi

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-04-30 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > > > > > > @zahiraam @AaronBallman a different option would be to add a signed > > > > > > vs unsigned storage option to the `OPTION` and > > > > > > `BENIGN_ENUM_LANGOPT` macros so we can store negative enumerations > > > > > > safely > > > > > > > > > > > > > > > I think I

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-04-28 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > > > @zahiraam @AaronBallman a different option would be to add a signed vs > > > unsigned storage option to the `OPTION` and `BENIGN_ENUM_LANGOPT` macros > > > so we can store negative enumerations safely > > > > > > I think I would prefer this solution. We need to be able t

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-04-28 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > @zahiraam @AaronBallman a different option would be to add a signed vs > unsigned storage option to the `OPTION` and `BENIGN_ENUM_LANGOPT` macros so > we can store negative enumerations safely I think I would prefer this solution. We need to be able to set the evaluation met

[clang] [clang] Remove FEM_Indeterminable (PR #137247)

2025-04-28 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > @zahiraam it's currently causing a warning (@Endilll asking for an update is > why I ended up looking at this on my phone) What is the warning? https://github.com/llvm/llvm-project/pull/137247 ___ cfe-commits mailing list cfe-commi

[clang] [clang] Remove FEM_Indeterminable (PR #137247)

2025-04-28 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > > I've reverted, not sure why I thought it had been reviewed? > > Thanks! And I'm happy enough blaming GitHub's poor Ux for all confusion. :-) > > @zahiraam -- any chance you can look into this? Yes I can in a couple of days. @ojhunt I hope this is OK? https://github.com/llv

[clang] [clang][OpenMP] Fix/enforce order-concurrent-nestable rules (PR #135463)

2025-04-18 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/135463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Fix/enforce order-concurrent-nestable rules (PR #135463)

2025-04-18 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/135463 >From 51a9237094437e0b9db57fd071e295939234a3ac Mon Sep 17 00:00:00 2001 From: Ernesto Su Date: Fri, 11 Apr 2025 16:12:10 -0700 Subject: [PATCH 1/2] [clang][OpenMP] Fix/enforce order-concurrent-nestable rules

[clang] [clang][OpenMP] Fix/enforce order-concurrent-nestable rules (PR #135463)

2025-04-17 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: if @alexey-bataev doesn't have additional comments, I or he can merge it in for you. https://github.com/llvm/llvm-project/pull/135463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [clang][OpenMP] Fix/enforce order-concurrent-nestable rules (PR #135463)

2025-04-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam approved this pull request. A few nit things. Looks good. Thanks. https://github.com/llvm/llvm-project/pull/135463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [clang][OpenMP] Fix/enforce order-concurrent-nestable rules (PR #135463)

2025-04-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/135463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Fix/enforce order-concurrent-nestable rules (PR #135463)

2025-04-15 Thread Zahira Ammarguellat via cfe-commits
@@ -411,9 +411,11 @@ bool isOpenMPCapturingDirective(OpenMPDirectiveKind DKind); /// directive that can be nested within region corresponding to construct /// on which order clause was specified with concurrent as ordering argument. /// \param DKind Specified directive. +/// \p

[clang] [Clang][Sema] Fix -Whigher-precision-for-complex-division (PR #131477)

2025-04-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam approved this pull request. Looks good. Just a few NIT things to edit. Thanks. https://github.com/llvm/llvm-project/pull/131477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [Clang][Sema] Fix -Whigher-precision-for-complex-division (PR #131477)

2025-04-15 Thread Zahira Ammarguellat via cfe-commits
@@ -360,6 +360,14 @@ Improvements to Clang's diagnostics - An error is now emitted when a ``musttail`` call is made to a function marked with the ``not_tail_called`` attribute. (#GH133509). +- ``-Whigher-precisision-for-complex-divison`` warns when: + + -The divisor is

[clang] [Clang][Sema] Fix -Whigher-precision-for-complex-division (PR #131477)

2025-04-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/131477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix -Whigher-precision-for-complex-division (PR #131477)

2025-04-15 Thread Zahira Ammarguellat via cfe-commits
@@ -349,6 +349,17 @@ Improvements to Clang's diagnostics - Now correctly diagnose a tentative definition of an array with static storage duration in pedantic mode in C. (#GH50661) +- ``-Whigher-precisision-for-complex-divison`` no longer incorrectly warns when the divisor i

[clang] [Clang][Sema] Fix -Whigher-precision-for-complex-division (PR #131477)

2025-04-11 Thread Zahira Ammarguellat via cfe-commits
@@ -349,6 +349,17 @@ Improvements to Clang's diagnostics - Now correctly diagnose a tentative definition of an array with static storage duration in pedantic mode in C. (#GH50661) +- ``-Whigher-precisision-for-complex-divison`` no longer incorrectly warns when the divisor i

[clang] [Clang][Sema] Fix -Whigher-precision-for-complex-division (PR #131477)

2025-04-10 Thread Zahira Ammarguellat via cfe-commits
=?utf-8?q?Mészáros?= Gergely ,Gergely Meszaros ,Gergely Meszaros Message-ID: In-Reply-To: @@ -10685,6 +10724,7 @@ QualType Sema::CheckMultiplyDivideOperands(ExprResult &LHS, ExprResult &RHS, if (compType.isNull() || !compType->isArithmeticType()) return InvalidOperand

[clang] [Clang][Sema] Fix -Whigher-precision-for-complex-division (PR #131477)

2025-04-10 Thread Zahira Ammarguellat via cfe-commits
=?utf-8?q?Mészáros?= Gergely Message-ID: In-Reply-To: @@ -10685,6 +10724,7 @@ QualType Sema::CheckMultiplyDivideOperands(ExprResult &LHS, ExprResult &RHS, if (compType.isNull() || !compType->isArithmeticType()) return InvalidOperands(Loc, LHS, RHS); if (IsDiv) { +

[clang] [Clang][Sema] Fix -Whigher-precision-for-complex-division (PR #131477)

2025-04-09 Thread Zahira Ammarguellat via cfe-commits
=?utf-8?q?Mészáros?= Gergely ,Gergely Meszaros ,Gergely Meszaros Message-ID: In-Reply-To: @@ -10685,6 +10724,7 @@ QualType Sema::CheckMultiplyDivideOperands(ExprResult &LHS, ExprResult &RHS, if (compType.isNull() || !compType->isArithmeticType()) return InvalidOperand

[clang] [Clang][Sema] Fix -Whigher-precision-for-complex-division (PR #131477)

2025-04-09 Thread Zahira Ammarguellat via cfe-commits
=?utf-8?q?Mészáros?= Gergely ,Gergely Meszaros ,Gergely Meszaros Message-ID: In-Reply-To: zahiraam wrote: > Don't know what's up with buildkite, it looks as if it doesn't like multiple > commits? The commit ID its trying to check out is the first in the series, > but `git fetch -v --prune -

[clang] [Clang][Sema] Fix -Whigher-precision-for-complex-division (PR #131477)

2025-04-09 Thread Zahira Ammarguellat via cfe-commits
=?utf-8?q?Mészáros?= Gergely ,Gergely Meszaros ,Gergely Meszaros Message-ID: In-Reply-To: @@ -0,0 +1,58 @@ +// RUN: %clang_cc1 %s -complex-range=promoted -triple x86_64-unknown-linux -verify=no-diag \ +// RUN: -DDIV_CC -DDIV_RC -DDIVASSIGN -DDIVMIXEDFD -DDIVMIXEDID + +// RUN:

[clang] [Clang][Sema] Fix -Whigher-precision-for-complex-division (PR #131477)

2025-04-08 Thread Zahira Ammarguellat via cfe-commits
=?utf-8?q?Mészáros?= Gergely Message-ID: In-Reply-To: @@ -10591,6 +10591,45 @@ static void checkArithmeticNull(Sema &S, ExprResult &LHS, ExprResult &RHS, << LHS.get()->getSourceRange() << RHS.get()->getSourceRange(); } +static void DetectPrecisionLossInComplexDivisio

[clang] [Clang][Sema] Fix -Whigher-precision-for-complex-division (PR #131477)

2025-04-08 Thread Zahira Ammarguellat via cfe-commits
=?utf-8?q?Mészáros?= Gergely Message-ID: In-Reply-To: @@ -0,0 +1,58 @@ +// RUN: %clang_cc1 %s -complex-range=promoted -triple x86_64-unknown-linux -verify=no-diag \ +// RUN: -DDIV_CC -DDIV_RC -DDIVASSIGN -DDIVMIXEDFD -DDIVMIXEDID + +// RUN: %clang_cc1 %s -complex-range=promote

[clang] Fix complex long double division with -mno-x87. (PR #133152)

2025-04-05 Thread Zahira Ammarguellat via cfe-commits
@@ -0,0 +1,49 @@ +// RUN %clang_cc1 %s -O0 -emit-llvm -triple x86_64-unknown-unknown \ +// RUN -verify -complex-range=promoted -o - | FileCheck %s + +// RUN %clang_cc1 %s -O0 -emit-llvm -triple x86_64-unknown-unknown \ +// RUN -verify=nopromotion -complex-range=promoted -target-fe

[clang] Fix complex long double division with -mno-x87. (PR #133152)

2025-04-05 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/133152 >From 56a000612da3f58928362229a46800c6f077cc71 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Wed, 26 Mar 2025 13:18:36 -0700 Subject: [PATCH 1/3] Fix complex long division with -mno-x87. --- clang/

[clang] Fix complex long double division with -mno-x87. (PR #133152)

2025-04-05 Thread Zahira Ammarguellat via cfe-commits
@@ -0,0 +1,49 @@ +// RUN %clang_cc1 %s -O0 -emit-llvm -triple x86_64-unknown-unknown \ +// RUN -verify -complex-range=promoted -o - | FileCheck %s + +// RUN %clang_cc1 %s -O0 -emit-llvm -triple x86_64-unknown-unknown \ +// RUN -verify=nopromotion -complex-range=promoted -target-fe

[clang-tools-extra] [NFC] Remove dead code detected by code sanitizer. (PR #134385)

2025-04-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/134385 >From 02ae197808f19541127b3e80448aa8034a8e8b1d Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Fri, 4 Apr 2025 07:05:26 -0700 Subject: [PATCH 1/2] [NFC] Remove dead code detected by code santizer. ---

[clang-tools-extra] [Clang-tidy][NFC] Remove dead code detected by code sanitizer. (PR #134385)

2025-04-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/134385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clang-tidy][NFC] Remove dead code detected by code sanitizer. (PR #134385)

2025-04-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/134385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Remove dead code detected by code sanitizer. (PR #134385)

2025-04-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/134385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Remove dead code detected by code sanitizer. (PR #134385)

2025-04-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/134385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Remove dead code detected by code sanitizer. (PR #134385)

2025-04-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/134385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Remove dead code detected by code santizer. (PR #134385)

2025-04-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/134385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Remove dead code detected by code santizer. (PR #134385)

2025-04-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/134385 None >From 02ae197808f19541127b3e80448aa8034a8e8b1d Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Fri, 4 Apr 2025 07:05:26 -0700 Subject: [PATCH] [NFC] Remove dead code detected by code santizer. -

[clang-tools-extra] [NFC] Fixes proposed by code sanitizer. (PR #134138)

2025-04-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/134138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fixes proposed by code sanitizer. (PR #134138)

2025-04-04 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > In general, I don't fully understand the scope of this patch. Surely, there's > thousands of things that could be improved in the codebase. Which of those > belong to this patch? Reviewers can always point out things that could be > improved ad infinitum, leading to a patch w

[clang-tools-extra] [NFC] Fixes proposed by code sanitizer. (PR #134138)

2025-04-03 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/134138 >From 608f5827cedbbc65441cefab80fbcdba7a053933 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Wed, 2 Apr 2025 11:52:13 -0700 Subject: [PATCH 1/4] [NFC] Fixes proposed by code sanitizer. --- .../bugp

[clang-tools-extra] [NFC] Fixes proposed by code sanitizer. (PR #134138)

2025-04-03 Thread Zahira Ammarguellat via cfe-commits
@@ -260,7 +260,7 @@ static IntegerRange createFromType(const ASTContext &Context, llvm::APSInt LowerValue(PrecisionBits + 2, /*isUnsigned*/ false); LowerValue.setBit(PrecisionBits); LowerValue.setSignBit(); -return {LowerValue, UpperValue}; +return {std::mo

[clang-tools-extra] [NFC] Fixes proposed by code sanitizer. (PR #134138)

2025-04-03 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > The changes to the clang-tidy check should be reverted IMO. > > Also, please provide more information. What do you mean by "code sanitizer", > what is the exact error message, etc. Please see above the error message from sanitizer. I can revert the change if you think the do

  1   2   3   4   5   6   7   8   9   >