zahiraam wrote:

> How did you decide on `IndexContents::All` as the default initialization 
> value. I would be more inclined towards `IndexContents::None`.
> 
> I think it would be preferred to use a member initializer in the declaration 
> of `IdxContents`. That will ensure an initialization is performed if 
> additional constructors are added.

Actually that makes more sense and it will obviously be assigned to 
`IndexContents::None`, which after thoughts seems more correct.

https://github.com/llvm/llvm-project/pull/118324
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to