[PATCH] D119530: [RISCV] Add combination crypto extensions in ISAInfo

eopXD added a comment. Friendly ping @VincentWu ;) Any comments to the latest response? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119530/new/ https://reviews.llvm.org/D119530 ___ cfe-commits mailing

[PATCH] D119530: [RISCV] Add combination crypto extensions in ISAInfo

eopXD updated this revision to Diff 411014. eopXD added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add test for clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119530/new/ https://reviews.llvm.org/D119530

[PATCH] D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics.

eopXD added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:180 + // The nomask intrinsic IR have the passthru operand. + bit HasNoMaskPassThru = false; eopXD wrote: > Nit: V-spec prefers to call instructions without masking operands "u

[PATCH] D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics.

eopXD added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:180 + // The nomask intrinsic IR have the passthru operand. + bit HasNoMaskPassThru = false; Nit: V-spec prefers to call instructions without masking operands "unmasked instru

[PATCH] D120297: [Driver][RISCV] Add missing rv64 test case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b62f19f27d4: [Driver][RISCV] Add missing rv64 test case (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/test/Driver/riscv-default-features.c:4 +// RV32: "target-features"="+a,+c,+m,+relax,-save-restore" +// RV64: "target-features"="+64bit,+a,+c,+m,+relax,-save-restore" + rogfer01

[PATCH] D120297: [Driver][RISCV] Add missing rv64 test case

eopXD created this revision. eopXD added a reviewer: rogfer01. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jone

[PATCH] D119210: [RISCV] Recover the implication between Zve* extensions and the V extension.

eopXD added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119210/new/ https://reviews.llvm.org/D119210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D119210: [RISCV] Recover the implication between Zve* extensions and the V extension.

eopXD added a comment. Kindly reverse ping. May you land this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119210/new/ https://reviews.llvm.org/D119210 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f51a9e2730e: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after… (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

eopXD updated this revision to Diff 407852. eopXD added a comment. Add testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119541/new/ https://reviews.llvm.org/D119541 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-defaul

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-isa features back after implication

eopXD created this revision. eopXD added reviewers: junparser, craig.topper, asb, frasercrmck. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMo

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

eopXD added a comment. In D113336#3313909 , @junparser wrote: > @eopXD, hi, this patch make us lost +relax and -save-restore by default, > would you please fix it? Sure, let me look into it. Do you have an existing test case for your situation? (Or I

[PATCH] D119210: [RISCV] Recover the implication between Zve* extensions and the V extension.

eopXD accepted this revision. eopXD added a comment. This revision is now accepted and ready to land. LGTM. For the record the implication in this patch correspond to the note under v-spec

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

eopXD added a comment. Not sure if this simplifies things. Users and the compiler can use the macro __riscv_v_elen and __riscv_v_elen_fp to do things to the vector-related target feature. Other than that I dont hold any strong objection to this refactoring. Repository: rG LLVM Github Monor

[PATCH] D117860: [RISCV] Remove experimental prefix from rvv-related extensions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cf15af2daa9: [RISCV] Remove experimental prefix from rvv-related extensions. (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117860/new/

[PATCH] D117913: [Clang][RISCV] Guard vmulh, vsmul correctly

eopXD added a comment. In D117913#3263493 , @khchen wrote: > why the new test filename extension is `.c.c`? Thanks for the reminder. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117913/new/ https://revie

[PATCH] D117860: [RISCV] Remove experimental prefix from rvv-related extensions.

eopXD updated this revision to Diff 402192. eopXD added a comment. Rebase. Resolve conflict due to addition of zbkc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117860/new/ https://reviews.llvm.org/D117860 Files: clang/test/CodeGen/RISCV/riscv

[PATCH] D117854: [RISCV] Refactor Zve* extensions.

eopXD added a comment. Maybe change the title to address more specifically of what this patch does? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.org/D117854 ___ cfe-comm

[PATCH] D117920: [RISCV] Decouple V and Zve64*

eopXD abandoned this revision. eopXD added a comment. In D117920#3263202 , @jacquesguan wrote: > I did some similar change in my revision https://reviews.llvm.org/D117854. Yeah I guess we can do that all in one commit. Thank you for doing it. Reposito

[PATCH] D117920: [RISCV] Decouple V and Zve64*

eopXD updated this revision to Diff 402172. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117920/new/ https://reviews.llvm.org/D117920 Files: llvm/lib/Support/RISCVISAInfo.cpp llvm/test/MC/RISCV/attribute-ar

[PATCH] D117920: [RISCV] Decouple V and Zve64*

eopXD updated this revision to Diff 402170. eopXD added a comment. Update code: adjust testcase due to change of implication. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117920/new/ https://reviews.llvm.org/D117920 Files: llvm/lib/Support/RISC

[PATCH] D117920: [RISCV] Decouple V and Zve64*

eopXD updated this revision to Diff 402085. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117920/new/ https://reviews.llvm.org/D117920 Files: llvm/lib/Support/RISCVISAInfo.cpp Index: llvm/lib/Support/RISCVIS

[PATCH] D117920: [RISCV] Decouple V and Zve64*

eopXD updated this revision to Diff 402080. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117920/new/ https://reviews.llvm.org/D117920 Files: clang/lib/Basic/Targets/RISCV.cpp llvm/lib/Support/RISCVISAInfo.c

[PATCH] D117920: [RISCV] Decouple V and Zve64*

eopXD created this revision. eopXD added reviewers: craig.topper, asb. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogf

[PATCH] D117913: [Clang][RISCV] Guard vmulh, vsmul correctly

eopXD added a comment. I changed the test commands in `vmul.c` and `vsmul.c` to use `zve64d` to make sure I don't miss anything I should move to the created files - `vmul-eew64.c` and `vsmul-eew64.c` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D117860: [RISCV] Remove experimental prefix from rvv-related extensions.

eopXD added a comment. In D117860#3261453 , @frasercrmck wrote: > Thanks for the patch! Not sure the best way to review this. The tests are > passing, which is a good sign. One option could be to split the "meaningful" > changes into a separate diff fo

[PATCH] D112986: [Clang][RISCV] Restrict rvv builtins with zve macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6ceec9c1d19: [Clang][RISCV] Restrict rvv builtins with zve macros (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D112986: [Clang][RISCV] Restrict rvv builtins with zve macros

eopXD added a comment. In D112986#3261933 , @frasercrmck wrote: > LGTM too. Though the commit title and message has hyphens in places I > wouldn't expect them. `macros` and `builtins` is fine. Thank you to also drop by and take a look :) ===

[PATCH] D112986: [Clang][RISCV] Restrict rvv builtin-s with zve macro-s

eopXD updated this revision to Diff 402036. eopXD marked an inline comment as done. eopXD added a comment. Cleanup unused enum. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112986/new/ https://reviews.llvm.org/D112986 Files: clang/utils/TableGe

[PATCH] D117860: [RISCV] Remove experimental prefix from rvv-related extensions.

eopXD updated this revision to Diff 402034. eopXD added a comment. Cleanup redundant code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117860/new/ https://reviews.llvm.org/D117860 Files: clang/test/CodeGen/RISCV/riscv-attr-builtin-alias-err.c

[PATCH] D117860: [RISCV] Remove experimental prefix from rvv-related extensions.

eopXD created this revision. eopXD added reviewers: craig.topper, asb, frasercrmck. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, armkevincheng, eric-k256, vkmr, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, a

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6de53b4de4a: [RISCV] Bump rvv-related extensions from 0.10 to 1.0 (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112987/new/ https://re

[PATCH] D112986: [Clang][RISCV] Restrict rvv builtin-s with zve macro-s

eopXD updated this revision to Diff 401870. eopXD added a comment. Follow clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112986/new/ https://reviews.llvm.org/D112986 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index: clang/utils/

[PATCH] D112986: [Clang][RISCV] Restrict rvv builtin-s with zve macro-s

eopXD added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:149 RV64 = 1 << 5, + VectorMaxELen32 = 1 << 6, + VectorMaxELen64 = 1 << 7, craig.topper wrote: > Do we need VectorMaxELen32 isn't that the minimum? Yes you are correct. We don't

[PATCH] D112986: [Clang][RISCV] Restrict rvv builtin-s with zve macro-s

eopXD updated this revision to Diff 401862. eopXD marked 2 inline comments as done. eopXD added a comment. Rebase and addres comments. Resolve conflcits due to zvlsseg removal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112986/new/ https://revie

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

eopXD updated this revision to Diff 401861. eopXD added a comment. Rebase. Resolve conflict due to zvlsseg removal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112987/new/ https://reviews.llvm.org/D112987 Files: clang/test/Driver/riscv-arch.c

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

eopXD updated this revision to Diff 401700. eopXD marked an inline comment as done. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112987/new/ https://reviews.llvm.org/D112987 Files: clang/test/Driver/riscv-arch.c

[PATCH] D117808: [NFC][RISCV] Add end-of-line symbol in target-feature testcases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb58cc9fb2348: [NFC][RISCV] Add end-of-line symbol in target-feature testcases (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D117808: [NFC][RISCV] Add end-of-line symbol in target-feature testcases

eopXD added a comment. Missed test case for zfh is found by adding end-of-lines ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117808/new/ https://reviews.llvm.org/D117808 ___ cfe-commits mailing list

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:221 // RUN: -o - | FileCheck --check-prefix=CHECK-V-EXT %s -// CHECK-V-EXT: __riscv_v 1 +// CHECK-V-EXT: __riscv_v 100 // CHECK-V-EXT: __risc

[PATCH] D117808: [NFC][RISCV] Add end-of-line symbol in target-feature testcases

eopXD created this revision. eopXD added a reviewer: craig.topper. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01

[PATCH] D112986: [Clang][RISCV] Restrict rvv builtin-s with zve macro-s

eopXD updated this revision to Diff 401687. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112986/new/ https://reviews.llvm.org/D112986 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index: clang/utils/TableGen

[PATCH] D112986: [Clang][RISCV] Restrict rvv builtin-s with zve macro-s

eopXD updated this revision to Diff 401684. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112986/new/ https://reviews.llvm.org/D112986 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index: clang/utils/TableGen

[PATCH] D112613: [Clang][RISCV] Change TARGET_BUILTIN to require zve32x for vector instruction

This revision was automatically updated to reflect the committed changes. Closed by commit rG14c5fd920b0e: [Clang][RISCV] Change TARGET_BUILTIN to require zve32x for vector instruction (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D112986: [RISCV] Restrict zvamo, zvlsseg with zve macro-s

eopXD reclaimed this revision. eopXD added a comment. This was closed by my misunderstanding. For clang we still need to do some restrictions based on ELEN. Reopening. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112986/new/ https://reviews.llvm.o

[PATCH] D112613: [RISCV] Change TARGET_BUILTIN to require zve32x for vector instruction

eopXD added a comment. Apply @frasercrmck 's suggested title, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112613/new/ https://reviews.llvm.org/D112613 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

eopXD updated this revision to Diff 401564. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112987/new/ https://reviews.llvm.org/D112987 Files: clang/test/Driver/riscv-arch.c clang/test/Preprocessor/riscv-targ

[PATCH] D112613: [RISCV] Change TARGET_BUILTIN require to zve32x for vector instruction

eopXD updated this revision to Diff 401554. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112613/new/ https://reviews.llvm.org/D112613 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index: clang/utils/TableGen/RIS

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

This revision was automatically updated to reflect the committed changes. Closed by commit rG60b6e73769f8: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ htt

[PATCH] D112613: [RISCV] Change TARGET_BUILTIN require to zve32x for vector instruction

eopXD updated this revision to Diff 401549. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112613/new/ https://reviews.llvm.org/D112613 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index: clang/utils/TableGen/RIS

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

eopXD updated this revision to Diff 401546. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112987/new/ https://reviews.llvm.org/D112987 Files: clang/lib/Basic/Targets/RISCV.cpp clang/utils/TableGen/RISCVVEmitter.c

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

eopXD updated this revision to Diff 401541. eopXD marked an inline comment as done. eopXD added a comment. Update code based on @kito-cheng 's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ https://reviews.llvm.org/D113336 File

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

eopXD added a comment. This patch needs to be landed before D112613 because clang_cc1 needs to do correct implication from `v`, `zve32f`, `zve64f` and `zve64d` and this patch fixes the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

eopXD updated this revision to Diff 401525. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ https://reviews.llvm.org/D113336 Files: clang/lib/Basic/Targets/RISCV.cpp llvm/include/llvm/Sup

[PATCH] D112986: [RISCV] Restrict zvamo, zvlsseg with zve macro-s

eopXD abandoned this revision. eopXD added a comment. This revision is no longer needed as zvamo and zvlsseg will be removed from arch string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112986/new/ https://reviews.llvm.org/D112986

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

eopXD added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vloxseg-rv32.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py -; RUN: llc -mtriple=riscv32 -mattr=+d,+experimental-zvlsseg,+zfh \ +; RUN: llc -mtriple=riscv32 -mattr=+experimen

[PATCH] D117724: [RISCV] Remove Zvlsseg extension.

eopXD added a comment. Thank you for doing this patch, I was about to do it after I land zve. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117724/new/ https://reviews.llvm.org/D117724 ___ cfe-commits ma

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:1499 foreach nf=2-8 in { +// Vector Unit-strided Segment Instructions +def VLSEG#nf#E64_V : craig.topper wrote: > The unit-stride and strided with EEW=64 don't require RV

[PATCH] D112408: [RISCV][MC] Add the zve extension according to the v1.0 spec

eopXD added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:184 Builder.defineMacro("__riscv_v_min_vlen", Twine(MinVLen)); +Builder.defineMacro("__riscv_v_max_eew", Twine(MaxEew)); +Builder.defineMacro("__riscv_v_max_eew_fp", Twine(MaxEewFp));

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

eopXD added a comment. We can land non-macro related code for zve first and continue on proceeding patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112408/new/ https://reviews.llvm.org/D112408 ___

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

eopXD marked an inline comment as not done. eopXD added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:184 Builder.defineMacro("__riscv_v_min_vlen", Twine(MinVLen)); +Builder.defineMacro("__riscv_v_max_eew", Twine(MaxEew)); +Builder.defineMacro("__ris

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

eopXD marked 7 inline comments as done. eopXD added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:184 Builder.defineMacro("__riscv_v_min_vlen", Twine(MinVLen)); +Builder.defineMacro("__riscv_v_max_eew", Twine(MaxEew)); +Builder.defineMacro("__riscv_v

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26bb1b1dab8b: [RISCV] Add the zvl extension according to the v1.0 spec (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 400238. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/ris

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 400111. eopXD added a comment. Rebase to latest main. Resolve test case conflicts due to Zvamo removal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/l

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:155-187 +def FeatureStdExtZvl64b : SubtargetFeature<"experimental-zvl64b", "ZvlLen", "ExtZvl::Zvl64b", + "'Zvl' (Minimum Vector Length) 64", + [FeatureStdExtZvl32b

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 400098. eopXD marked 8 inline comments as done. eopXD added a comment. Address comments. Thanks for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files:

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added a comment. ping again, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:741-751 +{{"zvl1024b"}, {ImpliedExtsZvl1024b}}, +{{"zvl128b"}, {ImpliedExtsZvl128b}}, +{{"zvl16384b"}, {ImpliedExtsZvl16384b}}, +{{"zvl2048b"}, {ImpliedExtsZvl2048b}}, +{{"zvl256b"}, {I

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 396505. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c cla

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added a comment. Ping, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 394739. eopXD marked 2 inline comments as done. eopXD added a comment. Address comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/B

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 394471. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/ris

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:230 +// RUN: | FileCheck --check-prefix=CHECK-V-MINVLEN %s +// CHECK-V-MINVLEN: __riscv_v_min_vlen 128 frasercrmck wrote: > Are we able to test non-default values of `__riscv

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 394454. eopXD marked 3 inline comments as done. eopXD added a comment. Rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/B

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:134 "maximum!"); + assert(RVVVectorBitsMin >= ZvlLen && + "Minimum V extension vector length should be at least the length " eopXD wrote: > eopXD wrote: > > craig

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 394119. eopXD marked 8 inline comments as done. eopXD added a comment. Rebase and address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Ba

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:782 +if (IsZvlExt) { + ExtName.consume_back("b"); + unsigned ZvlLen; craig.topper wrote: > craig.topper wrote: > > I think we should check the return value from consume_back

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4bf1b449dc0: [RISCV] Unify depedency check and extension implication parsing logics (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11235

[PATCH] D109215: [RISCV] Fix arch string parsing for multi-character extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rGe308b8e0c71b: [RISCV] Fix arch string parsing for multi-character extensions (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109215/new/

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 393185. eopXD added a comment. Rebase now since the preceeding patches are accepted. This patch is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Fil

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 393181. eopXD added a comment. One last rebase before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c clan

[PATCH] D109215: [RISCV] Fix arch string parsing for multi-character extensions

eopXD updated this revision to Diff 393174. eopXD added a comment. One last rebase before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109215/new/ https://reviews.llvm.org/D109215 Files: clang/test/Driver/riscv-arch.c llvm/lib/Suppor

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 390187. eopXD added a comment. - Update code (zfh have been added recently. - Added test case `attribute-arch-invalid.s` to show that experimental extensions need to specify the version explicitly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD added a comment. ping, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D109215: [RISCV] Fix arch string parsing for multi-character extensions

eopXD updated this revision to Diff 385329. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109215/new/ https://reviews.llvm.org/D109215 Files: clang/test/Driver/riscv-arch.c llvm/lib/Support/RISCVISAInfo.cpp Ind

[PATCH] D112613: [RISCV] Change TARGET_BUILTIN require to zve32x for vector instruction

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vaadd.c:3 // REQUIRES: riscv-registered-target -// RUN: %clang_cc1 -triple riscv64 -target-feature +experimental-v -disable-O0-optnone -emit-llvm

[PATCH] D112613: [RISCV] Change TARGET_BUILTIN require to zve32x for vector instruction

eopXD updated this revision to Diff 385278. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112613/new/ https://reviews.llvm.org/D112613 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index: clang/utils/TableGe

[PATCH] D113336: [RISCV] Let clang_cc1 be able to imply features

eopXD updated this revision to Diff 385277. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ https://reviews.llvm.org/D113336 Files: clang/lib/Basic/Targets/RISCV.cpp llvm/include/llvm/Support/RISCVISAIn

[PATCH] D112613: [RISCV] Change TARGET_BUILTIN require to zve32x for vector instruction

eopXD updated this revision to Diff 385276. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112613/new/ https://reviews.llvm.org/D112613 Files: clang/lib/Basic/Targets/RISCV.cpp clang/utils/TableGen/RISCVVEmitter.c

[PATCH] D113336: [RISCV] Let clang_cc1 be able to imply features

eopXD updated this revision to Diff 385275. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ https://reviews.llvm.org/D113336 Files: clang/lib/Basic/Targets/RISCV.cpp llvm/include/llvm/Support/RISCVISAIn

[PATCH] D113336: [RISCV] Let clang_cc1 be able to imply features

eopXD updated this revision to Diff 385258. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ https://reviews.llvm.org/D113336 Files: clang/lib/Basic/Targets/RISCV.cpp llvm/include/llvm/Support/RISCVISAIn

[PATCH] D113336: [RISCV] Let clang_cc1 be able to imply features

eopXD updated this revision to Diff 385256. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ https://reviews.llvm.org/D113336 Files: clang/lib/Basic/Targets/RISCV.cpp llvm/include/llvm/Support/RISCVISAIn

[PATCH] D112613: [RISCV] Change TARGET_BUILTIN require to zve32x for vector instruction

eopXD added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vaadd.c:3 // REQUIRES: riscv-registered-target -// RUN: %clang_cc1 -triple riscv64 -target-feature +experimental-v -disable-O0-optnone -emit-llvm %s -o - | opt -S -mem2reg | FileCheck -

[PATCH] D113336: [Clang][RISCV] Let clang_cc1 be able to imply feautes

eopXD created this revision. eopXD added a reviewer: craig.topper. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD added a comment. @asb Thanks for the reply. To clarify the question, the 2 inconsistencies are: - Test cases with `clang -cc1` originally don't do dependency check to target feature specified (handled by `parseFeatures`) - Clang driver's -march enforces version to be specified, while llvm

[PATCH] D109215: [RISCV] Fix arch string parsing for multi-character extensions

eopXD added a reviewer: asb. eopXD added a comment. @asb @jrtc27 Hi Alex and Jessica, Although the issue on relaxing naming rules aren't resolved in riscv-isa-manual [1], the v-spec v1.0 had come out including `zve` and `zvl` extensions and is frozen [2]. I have just finished a series of patch

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

eopXD updated this revision to Diff 383987. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112987/new/ https://reviews.llvm.org/D112987 Files: clang/test/Driver/riscv-arch.c clang/test/Preprocessor/riscv-target-fe

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

eopXD created this revision. eopXD added reviewers: kito.cheng, craig.topper. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, M

  1   2   >