eopXD added a comment. In D117860#3261453 <https://reviews.llvm.org/D117860#3261453>, @frasercrmck wrote:
> Thanks for the patch! Not sure the best way to review this. The tests are > passing, which is a good sign. One option could be to split the "meaningful" > changes into a separate diff for easier viewing? We probably don't need to > see all the test RUN line changes, for example. Non-testcase file changes are: M clang/utils/TableGen/RISCVVEmitter.cpp M llvm/lib/Support/RISCVISAInfo.cpp M llvm/lib/Target/RISCV/RISCV.td Do you mean creating separate this patch into two? Won't that cause build failure? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117860/new/ https://reviews.llvm.org/D117860 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
