Author: pxl
Date: Thu May 4 02:31:20 2017
New Revision: 302125
URL: http://llvm.org/viewvc/llvm-project?rev=302125&view=rev
Log:
[OpenCL] Add intel_reqd_sub_group_size attribute support
Summary:
Add intel_reqd_sub_group_size attribute support as intel extension
cl_intel_required_subgroup_size
pxli168 accepted this revision.
pxli168 added a comment.
Sorry for the late reply, I was busy with some backend problem.
LGTM, thanks for the fix!
http://reviews.llvm.org/D21744
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
pxli168 added a comment.
I was on a vecation. LGTM, thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D20133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: pxl
Date: Mon Jun 6 23:34:00 2016
New Revision: 271978
URL: http://llvm.org/viewvc/llvm-project?rev=271978&view=rev
Log:
[OPENCL] Fix wrongly vla error for OpenCL array.
Summary:
OpenCL should support array with const value size length, those const
varibale in global and constant address
Author: pxl
Date: Mon Jun 6 22:41:07 2016
New Revision: 271975
URL: http://llvm.org/viewvc/llvm-project?rev=271975&view=rev
Log:
Revert "[OPENCL] Fix wrongly vla error for OpenCL array."
Test case break on system-z.
This reverts commit 9a7212e1e87f1396952d74f8c62314a775ccbb1c.
Removed:
cfe
Author: pxl
Date: Mon Jun 6 22:13:39 2016
New Revision: 271971
URL: http://llvm.org/viewvc/llvm-project?rev=271971&view=rev
Log:
[OPENCL] Fix wrongly vla error for OpenCL array.
Summary:
OpenCL should support array with const value size length, those const varibale
in global and constant addres
pxli168 updated this revision to Diff 58932.
pxli168 added a comment.
Make all tests in OpenCL 2.0.
http://reviews.llvm.org/D20090
Files:
lib/AST/ExprConstant.cpp
lib/Sema/SemaType.cpp
test/CodeGenOpenCL/vla.cl
Index: test/CodeGenOpenCL/vla.cl
pxli168 added a comment.
Yes, I found although the khronos have make a clarify with implicit
declarations but they sames to be useful with some program link. And I found
some test case about link could not pass by this reason.
But how should we handle the new added spec?
http://reviews.llvm.or
pxli168 accepted this revision.
pxli168 added a comment.
This revision is now accepted and ready to land.
LGTM!
Thanks!
http://reviews.llvm.org/D20444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
pxli168 added inline comments.
Comment at: lib/Sema/SemaType.cpp:2055
@@ -2054,3 +2054,3 @@
- return S.VerifyIntegerConstantExpression(ArraySize, &SizeVal, Diagnoser,
- S.LangOpts.GNUMode).isInvalid();
+ return S
+ .VerifyIntegerC
pxli168 accepted this revision.
pxli168 added a comment.
Sorry about late reply.
LGTM!
http://reviews.llvm.org/D17578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pxli168 accepted this revision.
pxli168 added a comment.
LGTM!
I think we may add optimization on this base later.
http://reviews.llvm.org/D18369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
pxli168 added a comment.
Comment at: lib/Headers/opencl-c.h:9110
@@ +9109,3 @@
+ */
+float __const_func remainder(float x, float y);
+float2 __const_func remainder(float2 x, float2 y);
Anastasia wrote:
> Overloadable here and in other places too?
It seems macro
pxli168 accepted this revision.
pxli168 added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: test/SemaOpenCL/to_addr_builtin.cl:26
@@ +25,3 @@
+#if __OPENCL_C_VERSION__ < CL_VERSION_2_0
+ // expected-error@-2{{'to_global' needs OpenCL version 2.0 o
pxli168 added inline comments.
Comment at: lib/Sema/SemaType.cpp:2055
@@ -2054,3 +2054,3 @@
- return S.VerifyIntegerConstantExpression(ArraySize, &SizeVal, Diagnoser,
- S.LangOpts.GNUMode).isInvalid();
+ return S
+ .VerifyIntegerC
pxli168 added inline comments.
Comment at: test/SemaOpenCL/to_addr_builtin.cl:25
@@ +24,3 @@
+ glob = to_global(con);
+#if __OPENCL_C_VERSION__ < CL_VERSION_2_0
+ // expected-error@-2{{'to_global' needs OpenCL version 2.0 or above}}
yaxunl wrote:
> pxli168 wrote
pxli168 created this revision.
pxli168 added reviewers: Anastasia, yaxunl.
pxli168 added subscribers: cfe-commits, bader.
OpenCL should support array with const value size length, those const varibale
in global and constant address space and variable in constant address space.
http://reviews.ll
pxli168 added a comment.
You can update the SUMMARY of this diff as we are now using generic codegen
output.
And there are some inline comments about spec.
Comment at: test/SemaOpenCL/to_addr_builtin.cl:25
@@ +24,3 @@
+ glob = to_global(con);
+#if __OPENCL_C_VERSION__ < CL_VER
pxli168 added a comment.
The pointer type seems to be not that important, we can just cast it to any
type we want.
Comment at: test/SemaOpenCL/to_addr_builtin.cl:24
@@ +23,3 @@
+
+ glob = to_global(con);
+#if __OPENCL_C_VERSION__ < CL_VERSION_2_0
should this r
pxli168 accepted this revision.
pxli168 added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
pxli168 added a comment.
In http://reviews.llvm.org/D18369#422367, @yaxunl wrote:
> In http://reviews.llvm.org/D18369#421963, @pxli168 wrote:
>
> > If we want to save some space, could we use some macro to expand the
> > gentype or some script to expand the gentype into each types when the clang
pxli168 added a comment.
If we want to save some space, could we use some macro to expand the gentype or
some script to expand the gentype into each types when the clang is build?
http://reviews.llvm.org/D18369
___
cfe-commits mailing list
cfe-comm
pxli168 added a comment.
Could we output a generic function in CodeGen?
This seems to have no big difference to have a lot of declaration in an opencl
c header file.
http://reviews.llvm.org/D19932
___
cfe-commits mailing list
cfe-commits@lists.llvm
Author: pxl
Date: Tue May 3 00:37:07 2016
New Revision: 268364
URL: http://llvm.org/viewvc/llvm-project?rev=268364&view=rev
Log:
[OpenCL] Fix pipe type dump.
Summary:
Fix the dump of PipeType.
Now we will have "pipe int" and element type.
Reviewers: yaxunl, Anastasia
Subscribers: cfe-commits,
pxli168 updated this revision to Diff 55161.
pxli168 added a comment.
Add test and fix some old test.
http://reviews.llvm.org/D19524
Files:
lib/AST/ASTDumper.cpp
lib/AST/TypePrinter.cpp
test/Misc/ast-dump-pipe.cl
test/SemaOpenCL/invalid-access-qualifier.cl
test/SemaOpenCL/invalid-pipe
pxli168 added a comment.
I will add a test and send a new version.
http://reviews.llvm.org/D19524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pxli168 created this revision.
pxli168 added reviewers: Anastasia, yaxunl.
pxli168 added subscribers: bader, cfe-commits.
Fix the dump of PipeType.
Now we will have "pipe int" and element type.
http://reviews.llvm.org/D19524
Files:
lib/AST/ASTDumper.cpp
lib/AST/TypePrinter.cpp
Index: lib/AS
pxli168 accepted this revision.
pxli168 added a comment.
LGTM.
http://reviews.llvm.org/D19478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pxli168 added inline comments.
Comment at: lib/Headers/opencl.h:13721-13726
@@ +13720,8 @@
+
+/**
+ * Queue a memory fence to ensure correct ordering of memory
+ * operations between work-items of a work-group to
+ * image memory.
+ */
+#define CLK_IMAGE_MEM_FENCE 0x04
+
pxli168 added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:421
@@ +420,3 @@
+switch (LangOpts.OpenCLVersion) {
+case 0:
+case 100:
What is 0 stand for as OpenCLVersion, it seems the default OpenCLVersion if we
did not pass any -cl-st
pxli168 added a comment.
I think merge them into one file is a good idea.
And the layout by sepc order is OK, is will makes the review easy.
http://reviews.llvm.org/D18369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
pxli168 accepted this revision.
pxli168 added a comment.
LGTM!
Thanks!
http://reviews.llvm.org/D17412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pxli168 added a comment.
LGTM!
Thanks!
http://reviews.llvm.org/D17412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: pxl
Date: Tue Mar 29 23:46:32 2016
New Revision: 264825
URL: http://llvm.org/viewvc/llvm-project?rev=264825&view=rev
Log:
[OpenCL] Fix pipe builtin bugs
Summary:
1. Diag should be output if types are not the same.
2. Should compare using canonical type.
3. Refine the diag to be more clear
pxli168 added a comment.
Hi Anastasia,
https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15603
Now we got clarify from khronos. I will continue on this patch.
BTW, https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15599 is also fixed in
the same revision.
Thanks
Xiuli
http://reviews.llvm.org/D17
pxli168 updated this revision to Diff 51629.
pxli168 added a comment.
Add test for correct case.
http://reviews.llvm.org/D17955
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl
Index: test/SemaOpenCL/invalid-pipe-bu
Author: pxl
Date: Wed Mar 23 22:57:17 2016
New Revision: 264241
URL: http://llvm.org/viewvc/llvm-project?rev=264241&view=rev
Log:
[OpenCL] Add ocl and spir version for spir target
Summary: Add opencl.spir.version and opencl.ocl.version metadata for CodeGen to
identify OpenCL version.
Reviewers
pxli168 updated this revision to Diff 51253.
pxli168 added a comment.
Add test for spir64.
http://reviews.llvm.org/D17596
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGenOpenCL/spir_version.cl
Index: test/CodeGenOpenCL/spir_version.cl
=
pxli168 updated this revision to Diff 51140.
pxli168 added a comment.
Refine other check using the changed diag.
Change test as well.
http://reviews.llvm.org/D17955
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl
I
pxli168 updated this revision to Diff 51126.
http://reviews.llvm.org/D17596
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGenOpenCL/spir_version.cl
Index: test/CodeGenOpenCL/spir_version.cl
===
--- /dev/null
+++ test/CodeGenOpenCL/
pxli168 marked 2 inline comments as done.
pxli168 added a comment.
http://reviews.llvm.org/D17596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pxli168 added inline comments.
Comment at: test/CodeGenOpenCL/spir_version.cl:15
@@ +14,2 @@
+// CL20: !opencl.ocl.version = !{[[SPIR:![0-9]+]]}
+// CL20: [[SPIR]] = !{i32 2, i32 0}
Anastasia wrote:
> Forgotten to check OpenCL version here?
The metadate will be me
milar to atomic or pointer types.
Cheer,
Anastasia
-Original Message-
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
Xiuli Pan via cfe-commits
Sent: 09 January 2016 12:53
To: cfe-commits@lists.llvm.org
Subject: r257254 - [OpenCL] Pipe type support
Author: pxl
Dat
pxli168 added inline comments.
Comment at: lib/AST/ASTContext.cpp:7613
@@ +7612,3 @@
+if (getLangOpts().OpenCL) {
+ if (LHS.getUnqualifiedType() != RHS.getUnqualifiedType() ||
+ LQuals.getCVRQualifiers() != RQuals.getCVRQualifiers())
Anastasia wr
pxli168 added a comment.
The logic is still to complex and I hope it can be optimized.
Comment at: lib/Sema/SemaExpr.cpp:6222-6227
@@ -6188,1 +6221,8 @@
+auto ResultAddrSpace = ResultTy.getQualifiers().getAddressSpace();
+LHSCastKind = lhQual.getAddressSpace() == ResultA
pxli168 created this revision.
pxli168 added reviewers: Anastasia, yaxunl.
pxli168 added subscribers: cfe-commits, pekka.jaaskelainen.
1. Diag should be output if types are not the same.
2. Should compare using canonical type.
3. Refine the diag to be more clear.
http://reviews.llvm.org/D17955
F
Author: pxl
Date: Fri Mar 4 01:11:16 2016
New Revision: 262692
URL: http://llvm.org/viewvc/llvm-project?rev=262692&view=rev
Log:
[OpenCL] Refine pipe builtin support
Summary:
Refine the type builtin support as the request with
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160201/1486
pxli168 updated this revision to Diff 49797.
http://reviews.llvm.org/D16876
Files:
include/clang/Basic/Builtins.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl
Index: test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl
==
pxli168 added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:6194-6203
@@ +6193,12 @@
+
+ incompatTy = S.Context.getPointerType(
+ S.Context.getAddrSpaceQualType(S.Context.VoidTy, ResultAddrSpace));
+ LHS = S.ImpCastExprToType(LHS.get(), incompatTy,
+
Author: pxl
Date: Thu Feb 25 21:13:03 2016
New Revision: 261961
URL: http://llvm.org/viewvc/llvm-project?rev=261961&view=rev
Log:
[OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr
Summary:
OpenCL access qualifiers are now not only used for image types, refine it to
avoid misleading,
Add
pxli168 marked an inline comment as done.
pxli168 added a comment.
I think this is just a small change to help identify the which standard llvm-ir
is using.
And there is a SPIRV branch from Khronos
https://github.com/KhronosGroup/SPIRV-LLVM
We can start there and try to merge the spir-v support
pxli168 updated this revision to Diff 49136.
http://reviews.llvm.org/D17596
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGenOpenCL/spir_version.cl
Index: test/CodeGenOpenCL/spir_version.cl
===
--- /dev/null
+++ test/CodeGenOpenCL/
pxli168 added a comment.
https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15603
Bug reported.
http://reviews.llvm.org/D17438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pxli168 added inline comments.
Comment at: lib/Sema/SemaCast.cpp:2324-2326
@@ +2323,5 @@
+} else {
+Self.Diag(OpRange.getBegin(),
+ diag::error_opencl_cast_non_zero_to_event_t)
+ << intValue.toString(10) << SrcExpr.get()->getSource
pxli168 added a comment.
foo((event_t)0);
Is above use have been hint by some test cases?
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7679
@@ -7678,2 +7678,3 @@
def err_wrong_sampler_addressspace: Error<
- "sampler type cannot be used with the __local and __globa
pxli168 updated this revision to Diff 49008.
pxli168 added a comment.
1. Make new indent and leave space for the incoming OpenCL C++.
2. Check for the index to see if they are integers.
http://reviews.llvm.org/D16876
Files:
include/clang/Basic/Builtins.h
include/clang/Basic/DiagnosticSemaKi
pxli168 updated this revision to Diff 49007.
http://reviews.llvm.org/D16040
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CodeGenFunction.cpp
lib/Parse/ParseDecl.cpp
lib/Sema/SemaChecking.cpp
lib/Sema/SemaDe
pxli168 marked 2 inline comments as done.
pxli168 added a comment.
Remove test case for access quilifier in
test/SemaOpenCL/invalid-kernel-attrs.cl.
Due to the patch http://reviews.llvm.org/D17437.
read_only can only be used in parameters with pipe and image type.
Comment at: t
Author: pxl
Date: Wed Feb 24 21:34:20 2016
New Revision: 261818
URL: http://llvm.org/viewvc/llvm-project?rev=261818&view=rev
Log:
[OpenCL] Add Sema checks for types
Summary:
Add Sema checks for opencl type: image, pipe
This patch is partitioned from http://reviews.llvm.org/D16047
Reviewers:
Hi,
Does anyone knows why the svn seems to be stuck after I commit this patch.
Thanks
Xiuli
-Original Message-
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
Xiuli Pan via cfe-commits
Sent: Wednesday, February 24, 2016 12:41 PM
To: cfe-commits@lists.llvm.org
Author: pxl
Date: Tue Feb 23 22:29:36 2016
New Revision: 261719
URL: http://llvm.org/viewvc/llvm-project?rev=261719&view=rev
Log:
[OpenCL] Add Sema checks for OpenCL 2.0 block
Summary:
Add Sema checks for opencl 2.0 new features: Block.
This patch is partitioned from http://reviews.llvm.org/D1604
pxli168 added a comment.
It now gives a warning for both C99 and OpenCL.
But for target SPIR it gives an err only because it treat unprototyped function
as varidic function:
/// \brief Checks whether the given calling convention supports variadic
/// calls. Unprototyped calls also use the va
pxli168 updated this revision to Diff 48872.
pxli168 marked an inline comment as done.
http://reviews.llvm.org/D17437
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaType.cpp
test/CodeGenOpenCL/opencl_types.cl
test/SemaOpenCL/invalid-image.cl
test/
pxli168 added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:6714
@@ +6713,3 @@
+ if (LangOpts.OpenCLVersion >= 200 && T->isBlockPointerType()) {
+const BlockPointerType *BlkTy = T->getAs();
+const FunctionProtoType *FTy =
Anastasia wrote:
> Yes, but
pxli168 updated this revision to Diff 48774.
http://reviews.llvm.org/D17436
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExpr.cpp
lib/Sema/SemaType.cpp
test/SemaOpenCL/invalid-block.cl
Index: test/SemaOpenCL/invalid-block.cl
=
pxli168 updated this revision to Diff 48773.
pxli168 added a comment.
Add array check for types.
http://reviews.llvm.org/D17437
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaType.cpp
test/CodeGenOpenCL/opencl_types.cl
test/SemaOpenCL/invalid-imag
pxli168 added a comment.
It seems this patch is useless.
The spec does not tell about implicit declaration of function, but now clang
with -triple spir will output err if there is implicit declaration of function.
I have read about spir and opencl spec but could not find anything talk about
that
pxli168 accepted this revision.
pxli168 added a comment.
This revision is now accepted and ready to land.
Then there will be no problem.
I will change my patches as well.
LGTM!
Thanks.
http://reviews.llvm.org/D16928
___
cfe-commits mailing list
cfe-
pxli168 added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:5725
@@ +5724,3 @@
+ // Pipes can only be passed as arguments to a function.
+ if (getLangOpts().OpenCL && getLangOpts().OpenCLVersion >= 200 &&
+ R->isPipeType()) {
Anastasia wrote:
> Remove
pxli168 retitled this revision from "[OpenCL] Add Sema checks for image and
pipe" to "[OpenCL] Add Sema checks for types".
pxli168 updated the summary for this revision.
pxli168 updated this revision to Diff 48654.
pxli168 marked an inline comment as done.
pxli168 added a comment.
Refine comments
pxli168 added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5046
@@ +5045,3 @@
+ if (D->hasAttr()) {
+S.Diag(Attr.getLoc(), diag::err_opencl_multiple_access_qualifiers)
+<< D->getSourceRange();
Anastasia wrote:
> Yes, I think attribute would
pxli168 updated this revision to Diff 48648.
http://reviews.llvm.org/D17436
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExpr.cpp
lib/Sema/SemaType.cpp
test/SemaOpenCL/invalid-block.cl
Index: test/SemaOpenCL/invalid-block.cl
=
pxli168 marked 11 inline comments as done.
pxli168 added a comment.
Block is an OpenCL v2.0 feature, I think all test should be handled only for
CL2.0 or newer version.
Comment at: lib/Sema/SemaDecl.cpp:6714
@@ +6713,3 @@
+ // supported in OpenCL C: Blocks with variadic argume
pxli168 requested changes to this revision.
pxli168 added a comment.
This revision now requires changes to proceed.
It seems this patch will check block for CL1.2 or eailer? But the spec
reference is for OpenCL v2.0.
http://reviews.llvm.org/D16928
pxli168 accepted this revision.
pxli168 added a comment.
This revision is now accepted and ready to land.
LGTM!
Thanks
http://reviews.llvm.org/D16928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
pxli168 added a comment.
LGTM!
Thanks.
http://reviews.llvm.org/D16928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pxli168 created this revision.
pxli168 added reviewers: pekka.jaaskelainen, Anastasia, yaxunl.
pxli168 added a subscriber: cfe-commits.
Add Sema checks for atomics and implicit declaration
This patch is partitioned from http://reviews.llvm.org/D16047
http://reviews.llvm.org/D17438
Files:
inclu
pxli168 created this revision.
pxli168 added reviewers: Anastasia, pekka.jaaskelainen.
pxli168 added a subscriber: cfe-commits.
Add Sema checks for opencl 2.0 new features: Block.
http://reviews.llvm.org/D17436
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sem
pxli168 updated this revision to Diff 48452.
pxli168 added a comment.
Refine the pipe parse to solve the problem the attribute for pipe will be
handled twice within Declarator
http://reviews.llvm.org/D16040
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/
pxli168 planned changes to this revision.
pxli168 added a comment.
It seems it is related with the pipe type. I am still working on how to fix
this problem.
http://reviews.llvm.org/D16040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
pxli168 added a comment.
Hi Anastasia,
It seems the access qualifier attribute may need to be handled like the you
have mentioned in clang-commit that to be in type.
What is you opinion? I can write a patch for that too.
Thanks
Comment at: lib/Sema/SemaDeclAttr.cpp:5804-5816
@
pxli168 accepted this revision.
pxli168 added a comment.
Sorry for the late reply, I was on a break.
LGTM!
http://reviews.llvm.org/D16686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
pxli168 requested a review of this revision.
pxli168 added a comment.
Need to refine access qualifier with pipe type.
Comment at: lib/Sema/SemaDeclAttr.cpp:5052
@@ +5051,3 @@
+ if (D->hasAttr()) {
+S.Diag(D->getLocation(), diag::err_opencl_multiple_access_qualifiers)
+
pxli168 updated this revision to Diff 48046.
pxli168 marked 3 inline comments as done.
pxli168 added a comment.
Update doc for OpenCL access qualifier, still find where to handle access
qualifier for pipe type.
http://reviews.llvm.org/D16040
Files:
include/clang/Basic/Attr.td
include/clang
pxli168 updated this revision to Diff 47455.
pxli168 marked 5 inline comments as done.
http://reviews.llvm.org/D16040
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CodeGenFunction.cpp
lib/Sema/SemaChecking.cpp
lib/Sema/SemaDeclAttr.cpp
lib/S
pxli168 updated this revision to Diff 47074.
pxli168 updated the summary for this revision.
pxli168 added a comment.
Rebase for partition
http://reviews.llvm.org/D16047
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExpr.cpp
lib/Sema/SemaInit.cpp
pxli168 added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:13011
@@ -12978,5 +13010,3 @@
- // OpenCL 1.2 spec, s6.9 r:
- // The event type cannot be used to declare a structure or union field.
- if (LangOpts.OpenCL && T->isEventT()) {
-Diag(Loc, diag::err_event_t_st
pxli168 added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5067
@@ +5066,3 @@
+ if (DeclTy->isPipeType() ||
+ (S.getLangOpts().OpenCLVersion < 200 && DeclTy->isImageType())) {
+S.Diag(D->getLocation(), diag::err_opencl_invalid_read_write)
--
pxli168 updated this revision to Diff 47073.
pxli168 added a comment.
Make some optimization
http://reviews.llvm.org/D16040
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CodeGenFunction.cpp
lib/Sema/SemaChecking.cpp
lib/Sema/SemaDeclAttr.cpp
pxli168 added a reviewer: rsmith.
pxli168 added a comment.
Hi richard,
What is your opinion about where to put this ParseOpenCLUnrollHintAttribute?
Thanks
Xiuli
Comment at: lib/Parse/ParseStmt.cpp:2214
@@ +2213,3 @@
+
+bool Parser::ParseOpenCLUnrollHintAttribute(ParsedAttribut
pxli168 requested a review of this revision.
pxli168 added a reviewer: rsmith.
pxli168 added a comment.
Hi Richard/Anastasia,
I replied in the commit email, and here are some explains:
1. Without the space after comma the "//" will be aligned.
2. We want generic prototypes of the builtin functio
pxli168 added a comment.
Hi Anastasia/Pekka,
https://www.khronos.org/bugzilla/show_bug.cgi?id=1459
Bug report has been sent.
Thanks
Xiuli
http://reviews.llvm.org/D15914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
pxli168 added a comment.
Hi Pekka/Anastasia,
I find that most of the attribute parses was done in ParseDecl.cpp, should this
also be in there?
Thanks
Xiuli
Comment at: lib/Parse/ParseStmt.cpp:2214
@@ +2213,3 @@
+
+bool Parser::ParseOpenCLUnrollHintAttribute(ParsedAttributes &
pxli168 requested a review of this revision.
Comment at: lib/Sema/SemaChecking.cpp:343
@@ -332,3 +342,3 @@
// Two kinds of read/write pipe
// From OpenCL C Specification 6.13.16.2 the built-in read/write
// functions have following forms.
yaxunl wrote:
>
pxli168 updated this revision to Diff 46991.
http://reviews.llvm.org/D16876
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl
Index: test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl
===
The refined patch is in http://reviews.llvm.org/D16876
-Original Message-
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
xiuli pan via cfe-commits
Sent: Tuesday, February 2, 2016 10:53 AM
To: 'Richard Smith'
Cc: 'cfe-commits'
Subject: RE
pxli168 created this revision.
pxli168 added reviewers: Anastasia, pekka.jaaskelainen, yaxunl.
pxli168 added a subscriber: cfe-commits.
Refine the type builtin support as the request with
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160201/148637.html
http://reviews.llvm.org/D16876
pxli168 added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5067
@@ +5066,3 @@
+ if (DeclTy->isPipeType() ||
+ (S.getLangOpts().OpenCLVersion < 200 && DeclTy->isImageType())) {
+S.Diag(D->getLocation(), diag::err_opencl_invalid_read_write)
--
pxli168 updated this revision to Diff 46865.
pxli168 added a comment.
Remove repeat test case.
http://reviews.llvm.org/D16040
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CodeGenFunction.cpp
lib/Sema/SemaChecking.cpp
lib/Sema/SemaDeclAttr.c
pxli168 added a comment.
I see you have committed this patch, you can try to follow the guide here:
http://llvm.org/docs/Phabricator.html#committing-a-change
To add something in your commit and then the system will automatic close the
diff and have link to the commmit.
This will help others to fi
1 - 100 of 164 matches
Mail list logo
