[PATCH] D131295: [clangd] Implement textDocument/codeLens

lightmelodies added a comment. In D131295#3935759 , @Trass3r wrote: > Yeah quite complex: https://godbolt.org/z/8T5Pqadro Not very hard with a track of visited decls. It should also reslove other duplicate codelens. https://github.com/lightmelodies/llvm

[PATCH] D131295: [clangd] Implement textDocument/codeLens

lightmelodies added a comment. In D131295#3935027 , @Trass3r wrote: > Thanks, it seems to fix the base case, but I still see multiple lenses when I > add > > template > int Foo::foo() > { > return 0; > } Interesting, I see the same issue

[PATCH] D131295: [clangd] Implement textDocument/codeLens

lightmelodies added a comment. In D131295#3933381 , @Trass3r wrote: > One remaining issue is multiple lenses for template code like > > template > int i = 0; > > template int i<0>; > template int i<1>; > template int i<2>; > > template

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies added a comment. In D96751#2571563 , @sammccall wrote: > Fantastic, thank you! Maybe WithoutVoid.consume_front("void "); CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96751/new/ https://reviews.llvm.org/D96751 ___

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies added a comment. In D96751#2571346 , @sammccall wrote: > Nice! This looks good to land as-is, I just have some suggestions where we > may want to mark behavior to revisit later, and some places where we could > trim the tests a bit. > > Do

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies updated this revision to Diff 324626. lightmelodies added a comment. Better printing for C++ constructor and destructor. Remove unnecessary test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96751/new/ https://reviews.llvm.org/D96751 Files: clang-tools-extra/cla

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies updated this revision to Diff 324599. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96751/new/ https://reviews.llvm.org/D96751 Files: clang-tools-extra/clangd/FindSymbols.cpp clang-tools-extra/clangd/test/symbols.test clang-tools-extra/clangd/unittests/FindSymbolsTest

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies updated this revision to Diff 324582. lightmelodies added a comment. Change behavior of template and add unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96751/new/ https://reviews.llvm.org/D96751 Files: clang-tools-extra/

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies added a comment. Thanks for your response. Yes decl is too verbose in many cases. In fact I have tried another concise version, but I can not decide which one is better. Unit test in FindSymbolsTests.cpp is also done, but I would like upload them after we reach an agreement on wh

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies updated this revision to Diff 324143. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96751/new/ https://reviews.llvm.org/D96751 Files: clang-tools-extra/clangd/FindSymbols.cpp clang-tools-extra/clangd/test/symbols.test Index: clang

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies created this revision. lightmelodies added reviewers: sammccall, kadircet. lightmelodies added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lightmelodies requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. H

[PATCH] D91930: [clangd] Implement textDocument/codeLens

lightmelodies added a comment. I have also considered these problems, and here is some points of my view. **Latency** Consider llvm-project itself, **textDocument/codeLens** can be done in <500ms generally and <100ms if collect hierarchy is disabled in my notebook. Latency is significant in som

[PATCH] D91930: [clangd] Implement textDocument/codeLens

lightmelodies added a comment. In D91930#2411338 , @kadircet wrote: > Thanks a lot for working on improving clangd! > > Can you also give a high-level overview of what kind of functionality you are > providing here? Looks like there's a lot going on here,

[PATCH] D91930: [clangd] Implement textDocument/codeLens

lightmelodies updated this revision to Diff 306916. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91930/new/ https://reviews.llvm.org/D91930 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clangd/ClangdLSPServer.h clang-tools-extra/clangd/ClangdServer.cpp cl

[PATCH] D91930: [clangd] Implement textDocument/codeLens

lightmelodies updated this revision to Diff 306912. lightmelodies edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91930/new/ https://reviews.llvm.org/D91930 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clangd/ClangdLSPServer

[PATCH] D91930: [clangd] Implement textDocument/codeLens

lightmelodies created this revision. lightmelodies added reviewers: kadircet, sammccall. lightmelodies added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, arphaman, javed.absar. Herald added a project: clang. lightmelodies requested review of this revision. Herald