[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

vitalybuka added a comment. In D159167#4651325 , @lhames wrote: > @vitalybuka If we want to disable this test for now, what's the canonical way > to do it? Should we just wrap the whole `add_clang_unittest` block in the > conditional? > > # export_exe

[PATCH] D148654: Modify BoundsSan to improve debuggability

vitalybuka resigned from this revision. vitalybuka added a comment. I assume we moved to https://github.com/llvm/llvm-project/pull/65972 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148654/new/ https://reviews.llvm.org/D148654 ___

[PATCH] D145214: [TSAN] add support for riscv64

vitalybuka accepted this revision. vitalybuka added inline comments. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:5 append_list_if(COMPILER_RT_HAS_MSSE4_2_FLAG -msse4.2 TSAN_RTL_CFLAGS) -append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-than=530 +append_list_if(SAN

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

vitalybuka added a comment. Also maybe it's cleaner just disable a particular test (binary or test case) with incompatible sanitizer. Leaving this up to @lkail or @v.g.vassilev Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159167/new/ https://revi

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

vitalybuka added a comment. In D159167#4645214 , @vitalybuka wrote: > This breaks https://lab.llvm.org/buildbot/#/builders/5/builds/36614 I landed b4b4d8bd61d8de946e130beff5049a4ab13e155d

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

vitalybuka added a comment. This breaks https://lab.llvm.org/buildbot/#/builders/5/builds/36614 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159167/new/ https://reviews.llvm.org/D159167 ___ cfe-commits

[PATCH] D148654: Modify BoundsSan to improve debuggability

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:47 #include "llvm/Transforms/Utils/SanitizerStats.h" #include this file and BoundsChecking.cpp belong to different patches Comment at: clang/lib/CodeGen/CGExpr.cpp:

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

vitalybuka added a comment. In D74094#4633785 , @alexfh wrote: > This commit caused invalid AddressSanitizer: stack-use-after-scope errors in > our internal setup. Trying to create a standalone repro, but so far we think > that the patch is incorrect. @v

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

vitalybuka added a comment. Reverted cd591e02d4563d4b90792ed5f441e1cf5b30443e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157632/new/ https://reviews.llvm.org/D157632 ___

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

vitalybuka added a comment. Reverted. Please continue on original review: `arc diff HEAD^ --revision D157632` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000 _

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

vitalybuka added a comment. Could this be related https://lab.llvm.org/buildbot/#/builders/127/builds/54239 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000 _

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

vitalybuka added a comment. It's more convenient if you upload new patches into original review and reland that one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000 __

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

vitalybuka added a comment. Reverted with D155568 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156042/new/ https://reviews.llvm.org/D156042 ___ cfe-commits mailing lis

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

vitalybuka added a comment. Breaks the bot https://lab.llvm.org/buildbot/#/builders/74/builds/21336/steps/13/logs/stdio Please take a look or revert? Note: msan_track_origins step may have useful details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

vitalybuka added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:3656 + VisitorWorkList *WL = nullptr; + if (!WorkListFreeList.empty()) { +WL = WorkListFreeList.back(); vitalybuka wrote: > There is a leak here https://lab.llvm.org/buildbot/#/bu

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

vitalybuka added a comment. Not sure why the similar code above does not leak, so I will revert and leave to author to investigate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151373/new/ https://reviews.llvm.org/D151373

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

vitalybuka added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:3656 + VisitorWorkList *WL = nullptr; + if (!WorkListFreeList.empty()) { +WL = WorkListFreeList.back(); There is a leak here https://lab.llvm.org/buildbot/#/builders/5/builds/3572

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

vitalybuka added a comment. In D153536#4576683 , @aaron.ballman wrote: > In D153536#4571435 , @vitalybuka > wrote: > >>> Thanks! We might need someone from clangd to help here. The logs do not >>> have any info

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

vitalybuka added a comment. > Thanks! We might need someone from clangd to help here. The logs do not have > any information explaining what's failing with the test, and looking at the > test code, I struggle to see how these changes would impact that test. We've > had some significant issues w

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

vitalybuka added a comment. Not a test update The second line of the test triggers: RUN: not --crash clangd -lit-test -sync=0 < %s 2> %t.async.err == Signalled while building preamble Filename: ===

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

vitalybuka added a comment. In D153536#4570534 , @aaron.ballman wrote: > In D153536#4570513 , @vitalybuka > wrote: > >> This patch brakes https://lab.llvm.org/buildbot/#/builders/168/builds/14997 >> Not sure wha

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

vitalybuka added a comment. This patch brakes https://lab.llvm.org/buildbot/#/builders/168/builds/14997 Not sure what is wrong there, probably the test need to be updated. Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. In D157119#4569967 , @vitalybuka wrote: > In D157119#4569725 , @jroelofs > wrote: > >> Flaky test? Here's a later build where it succeeds, but the change has >> nothing to do with cl

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. In D157119#4569725 , @jroelofs wrote: > Flaky test? Here's a later build where it succeeds, but the change has > nothing to do with clangd: > https://lab.llvm.org/buildbot/#/builders/168/builds/14997 No, I manually requested

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. > How to reproduce locally: > https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild Does not reproduce on my workstation too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https://reviews

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. In D157119#4565993 , @jroelofs wrote: > In D157119#4564546 , @vitalybuka > wrote: > >> I suspect one of your recent changes broke >> https://lab.llvm.org/buildbot/#/builders/168/build

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. I suspect one of your recent changes broke https://lab.llvm.org/buildbot/#/builders/168/builds/14944 Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https://reviews.llvm.org/D157119

[PATCH] D148654: Modify BoundsSan to improve debuggability

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3576-3597 +if (TrapBBs.size() <= CheckHandlerID) + TrapBBs.resize(CheckHandlerID + 1); +llvm::BasicBlock *&TrapBB = TrapBBs[CheckHandlerID]; + +if (!CGM.getCodeGenOpts().OptimizationLevel

[PATCH] D152650: [docs] Improve UndefinedBehaviorSanitizer.rst

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/UndefinedBehaviorSanitizer.rst:62 + # -fno-sanitize=undefined nullifies the previous -fsanitize=undefined. + % clang -fsanitize=undefined

[PATCH] D152412: [clang/test/CodeGen] Add test coverage for VarBypassDetector handling init statements and condition variables in switch clauses

This revision was automatically updated to reflect the committed changes. Closed by commit rGb03abbb537e5: [clang/test/CodeGen] Add test coverage for VarBypassDetector handling init… (authored by dwang, committed by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Either way is fine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151593/new/ https://reviews.llvm.org/D151593 _

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:995 +// TODO: Consider passing the MemoryProfileOutput to the pass builder via +// the PGOOptions, and set this up there. tejohnson wrote: > vitalybuka wrote: > > if this is

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:995 +// TODO: Consider passing the MemoryProfileOutput to the pass builder via +// the PGOOptions, and set this up there. if this is registerOptimizerLastEPCallback, it can

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG4498663f3de0: [AST] Initialized data after TypeSourceInfo (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150499/new/ https://review

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka added reviewers: kstoimenov, thurston. vitalybuka added a comment. Oh, I rerun msan bot locally and it looked like issue dissipated, but I probably checked wrong logs. So I enabled -Oz on the bot, to catch more bugs, but the issue is still there https://lab.llvm.org/buildbot/#/builder

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150499/new/ https://reviews.llvm.org/D150499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D150504: [AST] Construct Capture objects before use

This revision was automatically updated to reflect the committed changes. Closed by commit rG8826cd57825d: [AST] Construct Capture objects before use (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150504/new/ https://reviews

[PATCH] D148573: Allow -fsanitize=function on all targets

vitalybuka added a comment. These bots are broken after the patch https://lab.llvm.org/buildbot/#/builders/77/builds/26834 https://lab.llvm.org/buildbot/#/builders/18/builds/9073 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148573/new/ https://rev

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka added a comment. ping, any concerns regarding this patch? i want to make MSAN stricter on our bot by reducing -O level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150499/new/ https://reviews.llvm.org/D150499 __

[PATCH] D150504: [AST] Construct Capture objects before use

vitalybuka added a comment. ping, any concerns regarding this patch? i want to make MSAN stricter on our bot by reducing -O level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150504/new/ https://reviews.llvm.org/D150504 __

[PATCH] D150492: [AST] Initialize local counter

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8cd04624e50: [AST] Initialize local counter (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D150492?vs=521819&id=523292#toc Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D150492: [AST] Initialize local counter

vitalybuka added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150492/new/ https://reviews.llvm.org/D150492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

vitalybuka added a comment. Is possible to split the patch into smaller ones? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148785/new/ https://reviews.llvm.org/D148785 ___ cfe-commits mailing list cfe-c

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka added a comment. In D150499#4341115 , @rjmccall wrote: > This memory is supposed to be initialized when we copy the `TypeLoc`. Are > you observing that not happening? Yes. There is the msan report in the description. Repository: rG LLVM

[PATCH] D150504: [AST] Construct Capture objects before use

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Msan reports https://reviews.llvm.org/P8308 So the reason is if PointerIntPair is not properly constructed, setPointer

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka updated this revision to Diff 521847. vitalybuka added a comment. use 0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150499/new/ https://reviews.llvm.org/D150499 Files: clang/include/clang/AST/Type.h clang/include/clang/AST/TypeLoc

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is no initialization of the data between allocation and first getBeginLoc call. llvm-project/clang/lib/AST/ASTC

[PATCH] D150492: [AST] Initialized local counter

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I assume it's optional and ReadAST does not have to set the counter on success. Repository: rG LLVM Github Monorep

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

vitalybuka added inline comments. Comment at: compiler-rt/lib/asan_abi/asan_abi_shim.cpp:62 +void __asan_init(void) { +assert(sizeof(uptr) == 8); +assert(sizeof(u64) == 8); static_assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

vitalybuka added a comment. Breaks these bots? https://lab.llvm.org/buildbot/#/builders/18/builds/8898 https://lab.llvm.org/buildbot/#/builders/19/builds/16412 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143467/new/ https://reviews.llvm.org/D1434

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

vitalybuka accepted this revision. vitalybuka added 2 blocking reviewer(s): eugenis, MaskRay. vitalybuka added a comment. In D143675#4310734 , @rsundahl wrote: > @kcc @eugenis @MaskRay @vitalybuka Ok to go with this? All new functionality > is under the

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

vitalybuka added a comment. In D143675#4281673 , @rsundahl wrote: > @kcc @eugenis @MaskRay @vitalybuka Ok to go with this? All new functionality > is under the added flag so not expecting any surprises. I don't have reasons to block this. ===

[PATCH] D147121: [hwasan] remove requirment for PIE

vitalybuka removed 1 blocking reviewer(s): eugenis. vitalybuka added a comment. This revision is now accepted and ready to land. Feel free to land. It works on my arm linux setup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147121/new/ https://re

[PATCH] D147121: [hwasan] remove requirment for PIE

vitalybuka removed a reviewer: alekseyshl. vitalybuka added 1 blocking reviewer(s): eugenis. vitalybuka accepted this revision. vitalybuka added a comment. This revision now requires review to proceed. I don't know why HWASAN may required pie, but @eugenis seems confident on D44745

[PATCH] D146603: [docs] Document -fomit-frame-pointer

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/Options.td:2643 + HelpText<"Omit the frame pointer from functions that don't need it. " + "Some stack unwinding cases lik

[PATCH] D145840: [Docs] Added -fomit-frame-pointer and -fno-omit-frame-pointer flag documentation

vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:2539 +def fno_omit_frame_pointer : Flag<["-"], "fno-omit-frame-pointer">, Group, + HelpText<"Help to produce better stack traces during debugging">; defm operator_names : BoolFOption<"operator-

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

vitalybuka added a comment. what is about detect_leaks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145822/new/ https://reviews.llvm.org/D145822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

vitalybuka added inline comments. Comment at: clang/test/Index/crash-recovery-modules.m:14 // REQUIRES: crash-recovery // UNSUPPORTED: libstdcxx-safe-mode // UNSUPPORTED: libstdcxx-safe-mode, hwasan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D145727: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. non-crash ones are probable worth of investigating later Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145727/new/ https://reviews.llvm.

[PATCH] D145040: Add test for Flags.data_flow_trace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67f5b05cdcdc: Add test for Flags.data_flow_trace (authored by yingcong-wu, committed by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D145040: Add test for Flags.data_flow_trace

vitalybuka updated this revision to Diff 503231. vitalybuka added a comment. test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145040/new/ https://reviews.llvm.org/D145040 Files: compiler-rt/lib/fuzzer/FuzzerDriver.cpp compiler-rt/test/fuzzer

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

vitalybuka added a comment. Usually freezing signatures is not a big concern, we can agree to preserve existing functions. The stuff like ASanStackFrameLayout is the concern. compiler and runtime must agree on data layout. The same for global. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

vitalybuka added subscribers: kstoimenov, vitalybuka. vitalybuka added a comment. One of your patches likely introduced UB https://lab.llvm.org/buildbot/#/builders/85/builds/14558 Can you please take a look? FYI, @kstoimenov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG890146b19206: [WebAssembly] Initial support for reference type externref in clang (authored by pmatos, committed by vitalybuka). Repository: rG LL

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

vitalybuka updated this revision to Diff 498550. vitalybuka added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTContext.h clang/include/clan

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

vitalybuka added a comment. In D122215#4118516 , @asb wrote: > @pmatos and I have tried and failed to reproduce the assert in the stage3 > msan build locally (both of us on separate machines, different environments). > We've reached out to @vitalybuka v

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

vitalybuka updated this revision to Diff 494999. vitalybuka added a comment. as reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTContext.h clang/include/clang

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

vitalybuka added a comment. Fails on this bot https://lab.llvm.org/buildbot/#/builders/5/builds/30884/steps/13/logs/stdio https://reviews.llvm.org/D142233 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142233/new/ https://reviews.llvm.org/D142233

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

vitalybuka added a comment. https://lab.llvm.org/buildbot/#/builders/37/builds/19499 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D139114 ___ cfe-commits mailing lis

[PATCH] D137838: [Support] Move TargetParsers to new component

vitalybuka added a comment. This bot is broken after the patch https://lab.llvm.org/buildbot/#/builders/236/builds/1480 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137838 ___

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Introduces memory bugs: https://lab.llvm.org/buildbot/#/builders/5/builds/30234 https://lab.llvm.org/buildbot/#/builders/236/builds/1556 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Abandon? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129448/new/ https://reviews.llvm.org/D129448 _

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a comment. You probably can try to finish pure lsan, and then get back to lsan+asan. So if you continue to work please send smaller and ready pieces for review? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 _

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Herald added a subscriber: Enna1. Is this still relevant? If so, I would recommend to split ItaniumCXXABI from asan changes. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Herald added a subscriber: Enna1. Is this still relevant? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 ___

[PATCH] D119621: [SanitizerCoverage] Add instrumentation callbacks for FP cmp instructions

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Herald added a subscriber: Enna1. Please update if it's still relevant CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119621/new/ https://reviews.llvm.org/D119621 __

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. vitalybuka marked an inline comment as done. Closed by commit rG166c8cccde01: [msan][CodeGen] Set noundef for C return value (authored by vitalybuka). Repository: rG

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1828 !Module.MayDropFunctionReturn(Module.getContext(), RetTy) || Module.getLangOpts().Sanitize.has(SanitizerKind::Memory) || Modu

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka updated this revision to Diff 480335. vitalybuka added a comment. remove redundant check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeG

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka added a comment. In D139296#3972142 , @kda wrote: > Is there a risk of this being too strict for standard C? > > Should there be a test case for our specific problem? (C calling C++) Probably not. It's cross module mismatch. To reproduce we n

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka updated this revision to Diff 479992. vitalybuka added a comment. new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/cleanup-des

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Msan needs noundef consistency between interface and implementation. If we call C++ from C we can have noundef on C++

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/docs/GwpAsan.rst:174 ++-++

[PATCH] D137992: [asan] -fsanitize-address-outline-instrumentation -> -asan-max-inline-poisoning-size=0

vitalybuka added a subscriber: kstoimenov. vitalybuka added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:1256 if (AsanOutlineInstrumentation) { CmdArgs.push_back("-mllvm"); CC @kstoimenov it's maybe not the best name for flag, but t

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

vitalybuka added a comment. In D137381#3924698 , @lebedev.ri wrote: > Can someone from @Sanitizers please comment? :) @vitalybuka ? @glider ? > @rsmith ? > > In D137381#3923911 , @MaskRay wrote: > >> I think im

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:777 // Enable aliases as they should have no downside with ODR indicators. -UsePrivateAlias(UseOdrIndicator || ClUsePrivateAlias), -UseOdrIndicator(UseO

[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

vitalybuka added subscribers: fmayer, vitalybuka. vitalybuka added a comment. FYI @fmayer Probably this patch https://lab.llvm.org/buildbot/#/builders/237/builds/350/steps/13/logs/stdio -- Testing: 66920 tests, 48 workers -- Testing: 0.. 10.. 20 FAIL: Clang :: SemaCXX/sugar-common-types.c

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3031 +OrderedEntries[E.getOrder()] = +std::make_tuple(&E, Loc, EntryInfo.ParentName); +ParentFunctions[E.getOrder()] = EntryInfo.ParentName; mikerice w

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

vitalybuka added a comment. Comment at: clang/lib/CodeGen/CGExpr.cpp:1746 + if (auto TyPtr = Ty.getTypePtrOrNull()) { +if (!(TyPtr->isSpecificBuiltinType(BuiltinType::UChar) || Taking into account potantial risks from pre-existing UB, I believe we need

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

vitalybuka added a comment. In D134410#3860646 , @xbolva00 wrote: >> I assume with this patch landed, many such cases may change code behavior. >> So we will need to update msan to have a tool to detect cases like this >> anyway. > > I believe that upda

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

vitalybuka added a reviewer: vitalybuka. vitalybuka added a comment. In D134410#3817190 , @vitalybuka wrote: >> Also I applied this patch with D134698 >> and used on our large test set, expecting significant number of

[PATCH] D135713: [cmake][Fuchsia] Add -ftrivial-auto-var-init=zero to runtimes build

vitalybuka added a comment. It may help with some cases, but still does not guarantee that pointer will not survive in paddings or red-zones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135713/new/ https://reviews.llvm.org/D135713 _

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

vitalybuka added a comment. > Also I applied this patch with D134698 and > used on our large test set, expecting significant number of pre-existing > reports. To my surprise I see not many of them. Something wrong with my msan experiment, I'll re-evaluate size

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

vitalybuka added a comment. In D134410#3817070 , @xbolva00 wrote: > In D134410#3816918 , @vitalybuka > wrote: > >> I tried to hook this patch into MemorySanitizer and it reduces instrumented >> code by ~30% ! >

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

vitalybuka added a comment. I tried to hook this patch into MemorySanitizer and it reduces instrumented code by ~30% ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134410/new/ https://reviews.llvm.org/D134410

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

vitalybuka added a comment. Are there patches uploaded with arc tool? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134410/new/ https://reviews.llvm.org/D134410 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

vitalybuka added a comment. diff --git a/clang/test/Driver/fsanitize-memory-param-retval.c b/clang/test/Driver/fsanitize-memory-param-retval.c index d82d20812186..79ade32178b6 100644 --- a/clang/test/Driver/fsanitize-memory-param-retval.c +++ b/clang/test/Driver/fsanitize-memory-param-ret

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

vitalybuka updated this revision to Diff 463058. vitalybuka added a comment. Herald added a subscriber: MaskRay. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134669/new/ https://reviews.llvm.org/D134669 Files: clang/include/clang/Driver/

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:1767 MarshallingInfoEnum, "Global">; defm sanitize_memory_param_retval : BoolFOption<"sanitize-memory-param-retval", you need to update SanitizerArgs::MsanParamRetval

[PATCH] D134669: [clang][msan] Turn on -fsanitize-memory-param-retval by default

vitalybuka added a comment. In D134669#3816519 , @aeubanks wrote: > do you want the tests to all properly work with > -fsanitize-memory-param-retval, or just pin them to > -fno-sanitize-memory-param-retval if they're failing? I have some draft patch fo

  1   2   3   4   5   6   7   8   >