vitalybuka added a comment. In D153536#4576683 <https://reviews.llvm.org/D153536#4576683>, @aaron.ballman wrote:
> In D153536#4571435 <https://reviews.llvm.org/D153536#4571435>, @vitalybuka > wrote: > >>> Thanks! We might need someone from clangd to help here. The logs do not >>> have any information explaining what's failing with the test, and looking >>> at the test code, I struggle to see how these changes would impact that >>> test. We've had some significant issues with flaky clangd tests >>> (https://github.com/clangd/clangd/issues/1712), so it's possible this is >>> happenstance. >> >> I tried to debug that, and it looks like false Asan report. Maybe a bug in >> FakeStack::GC related code. > > Thank you for looking into it! I came to the same general conclusion; and it > seems the impacted bot has gone back to green in the meantime: > https://lab.llvm.org/buildbot/#/builders/168/builds/15031 so hopefully we're > in good shape. Yes. Fixed by D157552 <https://reviews.llvm.org/D157552>. It's amusing to see this unrelated patch exposing ~10 years old bug, which was never reported before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153536/new/ https://reviews.llvm.org/D153536 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
