[clang] [llvm] [ImmutableSet] Optimize add/remove operations to avoid redundant tree modifications (PR #159845)

2025-09-22 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: > Did we only have this issue with the sets? Are the maps fine? Maps are implemented as a set of key, value pair and therefore use the same API. https://github.com/llvm/llvm-project/pull/159845 ___ cfe-commits mailing list cfe-commits@lis

[clang] [llvm] [LifetimeSafety] Implement support for lifetimebound attribute (PR #158489)

2025-09-21 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/158489 >From f105e5a5c094e3bfc8f3ceb6331651eaed5823e9 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 19 Sep 2025 20:00:17 + Subject: [PATCH 1/3] fix-add-immutable-set --- clang/lib/Analysis/LifetimeSafety

[clang] [LifetimeSafety] Implement support for lifetimebound attribute (PR #158489)

2025-09-21 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/158489 >From 1bb7dffe767c547e77eea57ee0ef341284e0fb1d Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Sun, 14 Sep 2025 14:46:45 + Subject: [PATCH] lifetime-analysis-lifetimebound --- .../clang/Analysis/Analyses

[clang] [LifetimeSafety] Implement LiveOrigins analysis (PR #148976)

2025-09-21 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/148976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Implement support for lifetimebound attribute (PR #158489)

2025-09-21 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/158489 >From 076766a917cd3c327a584dd868418d69ddecfcd5 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Sun, 14 Sep 2025 14:46:45 + Subject: [PATCH] lifetime-analysis-lifetimebound --- .../clang/Analysis/Analyses

[clang] [LifetimeSafety] Implement support for lifetimebound attribute (PR #158489)

2025-09-21 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/158489 >From 29f3f38f2aef81ba0d5a2c18d886d3a71f05bc55 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Sun, 14 Sep 2025 14:46:45 + Subject: [PATCH] lifetime-analysis-lifetimebound --- .../clang/Analysis/Analyses

[clang] [LifetimeSafety] Implement support for lifetimebound attribute (PR #158489)

2025-09-21 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/158489 >From 6926b8cb5aa54ec17d85c1a1cf0e99751083d85d Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Sun, 14 Sep 2025 14:46:45 + Subject: [PATCH] lifetime-analysis-lifetimebound --- .../clang/Analysis/Analyses

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-20 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: * **#159582** https://app.graphite.dev/github/pr/llvm/llvm-project/159582?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/159582

[clang] [llvm] fix-add-immutable-set (PR #159845)

2025-09-20 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: * **#159845** https://app.graphite.dev/github/pr/llvm/llvm-project/159845?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/159845

[clang] [LifetimeSafety] Add support for GSL Pointer types (PR #154009)

2025-09-20 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 auto_merge_enabled https://github.com/llvm/llvm-project/pull/154009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Add support for GSL Pointer types (PR #154009)

2025-09-20 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: (Landing atm with the approvals in place. Happy to address any more comments post-commit). https://github.com/llvm/llvm-project/pull/154009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [llvm] [ImmutableSet] Optimize add/remove operations to avoid redundant tree modifications (PR #159845)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 ready_for_review https://github.com/llvm/llvm-project/pull/159845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/159582 >From 215d59c655c6117dc5774dfb8163156aad152044 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 18 Sep 2025 12:52:29 + Subject: [PATCH] [LifetimeSafety] Avoid adding already present items in sets/maps

[clang] [llvm] [ImmutableSet] Optimize add/remove operations to avoid redundant tree modifications (PR #159845)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/159845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/159582 >From c6e96e9fd828cefa1aa27d19b735125b14e51ad2 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 18 Sep 2025 12:52:29 + Subject: [PATCH] [LifetimeSafety] Avoid adding already present items in sets/maps

[clang] [llvm] fix-add-immutable-set (PR #159845)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/159845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ImmutableSet] Optimize add/remove operations to avoid redundant tree modifications (PR #159845)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/159845 >From f105e5a5c094e3bfc8f3ceb6331651eaed5823e9 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 19 Sep 2025 20:00:17 + Subject: [PATCH] fix-add-immutable-set --- clang/lib/Analysis/LifetimeSafety.cpp

[clang] [llvm] [ImmutableSet] Optimize add/remove operations to avoid redundant tree modifications (PR #159845)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/159845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] fix-add-immutable-set (PR #159845)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/159845 None >From aac86de4b88c2151032f22e5be90b499b97acc43 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 19 Sep 2025 20:00:17 + Subject: [PATCH] fix-add-immutable-set --- clang/lib/Analysis/LifetimeSafe

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/159582 >From c08ea2d26df77ece3e1d471d25dd3c29f609bac7 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 18 Sep 2025 12:52:29 + Subject: [PATCH] [LifetimeSafety] Avoid adding already present items in sets/maps

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/159582 >From 11a1905b6520d7f74cf33c1e3c729a9a1ec4e2ad Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 18 Sep 2025 12:52:29 + Subject: [PATCH] [LifetimeSafety] Avoid adding already present items in sets/maps

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: Hmm. Atleast the [documentation](https://github.com/llvm/llvm-project/blob/e2467cbfa8fdc440debac1cfb930ee476f3d5e42/llvm/include/llvm/ADT/ImmutableSet.h#L531-L533) for add_internal suggests that this might be really unintentional https://github.com/llvm/llvm-project/pull/159582 __

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/159582 >From ace40d4ba0eb87fb5bd9761e01420563c99f9603 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 18 Sep 2025 12:52:29 + Subject: [PATCH] [LifetimeSafety] Avoid adding already present items in sets/maps

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 commented: Will change the underlying data structure in the next PR. Submitting this to stop the bleeding. https://github.com/llvm/llvm-project/pull/159582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/159582 >From a7146ee0032245a16b3d9c1ad3038d0b0f93a836 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 18 Sep 2025 12:52:29 + Subject: [PATCH] [LifetimeSafety] Avoid adding already present items in sets/maps

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: ### Merge activity * **Sep 19, 3:59 PM UTC**: [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/159582) rebased this pull request as part of a merge. https://github.com/llvm/llvm-project/pull/159582 ___ cfe-commits mailin

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/159582 >From 713609dcd10ab8890e6e10400b1286b9bd519e50 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 18 Sep 2025 12:52:29 + Subject: [PATCH] [LifetimeSafety] Avoid adding already present items in sets/maps

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
@@ -910,6 +910,8 @@ template static llvm::ImmutableSet join(llvm::ImmutableSet A, llvm::ImmutableSet B, typename llvm::ImmutableSet::Factory &F) { + if (A == B) +return A; usx95 wrote: A

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/159582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/159582 >From 533103b93c27af136b6510220229b6c4d784a7e7 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 18 Sep 2025 12:52:29 + Subject: [PATCH] [LifetimeSafety] Avoid adding already present items in sets/maps

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: Yitzi beat me to it. Yup this is definitely a bug then. https://github.com/llvm/llvm-project/pull/159582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: > Ugh, I wonder if this is unintentional and we should change the > implementation of these data structures. I also find this behavior very > surprising. I can try changing the data structure. Let me do that in a separate PR. It would need an extra Value comparison which needs t

[clang] [LifetimeSafety] Associate origins to all l-valued expressions (PR #156896)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: Since we discussed this patch briefly f2f and no major concerns were raised, I will land this for now @ymand . Happy to address review comments post commit. https://github.com/llvm/llvm-project/pull/156896 ___ cfe-commits mailing list cfe

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/159582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Add support for GSL Pointer types (PR #154009)

2025-09-18 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/154009 >From c13b6a0a04a311b284c484ed6cda63cf76657805 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 4 Sep 2025 14:27:37 + Subject: [PATCH 1/2] all-lvalues-have-origin >From 83a9c8091d3d0a267963e87a8a0b5e

[clang] [LifetimeSafety] Associate origins to all l-valued expressions (PR #156896)

2025-09-18 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: ### Merge activity * **Sep 11, 1:50 PM UTC**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/156896). https://github.com/llvm/llvm-project/pull/156896 __

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-18 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/159582 None >From 45f4b75d022eebd92d3ae2514653dc7e4f81b555 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 18 Sep 2025 12:52:29 + Subject: [PATCH] [LifetimeSafety] Avoid adding already present items in set

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-18 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 ready_for_review https://github.com/llvm/llvm-project/pull/159582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-18 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/159582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Avoid adding already present items in sets/maps (PR #159582)

2025-09-18 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/159582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Add support for GSL Pointer types (PR #154009)

2025-09-17 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: I think we have a very different model of understanding when a loan is created so it is hard to match these. Is there any piece specifically you have in mind. I could imagine lot of implicit annotation and annotation presence check can be shared (`shouldTrackImplicitObjectArg`, `

[clang] [LifetimeSafety] Implement support for lifetimebound attribute (PR #158489)

2025-09-14 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/158489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Implement support for lifetimebound attribute (PR #158489)

2025-09-14 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/158489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Implement support for lifetimebound attribute (PR #158489)

2025-09-14 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/158489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Implement support for lifetimebound attribute (PR #158489)

2025-09-14 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/158489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] lifetime-analysis-lifetimebound (PR #158489)

2025-09-14 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: * **#158489** https://app.graphite.dev/github/pr/llvm/llvm-project/158489?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/158489

[clang] lifetime-analysis-lifetimebound (PR #158489)

2025-09-14 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/158489 None >From 0f103748146c260fc0abfb738446d0a0dc71daf9 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Sun, 14 Sep 2025 14:46:45 + Subject: [PATCH] lifetime-analysis-lifetimebound --- .../clang/Analysis/An

[clang] [LifetimeSafety] Add support for GSL Pointer types (PR #154009)

2025-09-14 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/154009 >From 598c803c93eeb4c32737938482e24fd98bf7fa8d Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 4 Sep 2025 14:27:37 + Subject: [PATCH 1/2] all-lvalues-have-origin >From 4f1e0b70d9118379bb0afabf50bba7

[clang] [LifetimeSafety] Add support for GSL Pointer types (PR #154009)

2025-09-14 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/154009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Add support for GSL Pointer types (PR #154009)

2025-09-14 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/154009 >From c13b6a0a04a311b284c484ed6cda63cf76657805 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 4 Sep 2025 14:27:37 + Subject: [PATCH 1/2] all-lvalues-have-origin >From 83a9c8091d3d0a267963e87a8a0b5e

[clang] [LifetimeSafety] Add support for GSL Pointer types (PR #154009)

2025-09-13 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/154009 >From 266c3fefb387c415dfb2f0910f22d0e7a382de23 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 4 Sep 2025 14:27:37 + Subject: [PATCH 1/2] all-lvalues-have-origin >From 26bf92131fd0141988be121f8f88c5

[clang] [LifetimeSafety] Add support for GSL Pointer types (PR #154009)

2025-09-13 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/154009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Associate origins to all l-valued expressions (PR #156896)

2025-09-12 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/156896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Add support for GSL Pointer types (PR #154009)

2025-09-12 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/154009 >From c13b6a0a04a311b284c484ed6cda63cf76657805 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 4 Sep 2025 14:27:37 + Subject: [PATCH 1/2] all-lvalues-have-origin >From 83a9c8091d3d0a267963e87a8a0b5e

[clang] [LifetimeSafety] Add support for GSL Pointer types (PR #154009)

2025-09-12 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/154009 >From 670dd40ca05e61d420b259122008186c1ba91c90 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Sun, 17 Aug 2025 10:10:18 + Subject: [PATCH] [LifetimeSafety] Track gsl::Pointer types --- clang/lib/Analysi

[clang] [LifetimeSafety] Associate origins to all l-valued expressions (PR #156896)

2025-09-08 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/156896 >From f7906c207782f94873936a5c4545c7900165534e Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 4 Sep 2025 14:27:37 + Subject: [PATCH] all-lvalues-have-origin --- clang/lib/Analysis/LifetimeSafety.cp

[clang] [LifetimeSafety] Mark all DeclRefExpr as usages of the corresp. origin (PR #154316)

2025-09-05 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/154316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Mark all DeclRefExpr as usages of the corresp. origin (PR #154316)

2025-09-05 Thread Utkarsh Saxena via cfe-commits
@@ -567,9 +565,47 @@ class FactGenerator : public ConstStmtVisitor { return false; } + void handleAssignment(const Expr *LHSExpr, const Expr *RHSExpr) { +// Find the underlying variable declaration for the left-hand side. +if (const auto *DRE_LHS = +

[clang] [LifetimeSafety] Associate origins to all l-valued expressions (PR #156896)

2025-09-05 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/156896 >From fdbae53b68bfb61defbb27866ad47ee16e6e8481 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 4 Sep 2025 14:27:37 + Subject: [PATCH] all-lvalues-have-origin --- clang/lib/Analysis/LifetimeSafety.cp

[clang] [LifetimeSafety] Mark all DeclRefExpr as usages of the corresp. origin (PR #154316)

2025-09-05 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: ### Merge activity * **Sep 5, 8:15 PM UTC**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/154316). https://github.com/llvm/llvm-project/pull/154316 ___

[clang] [LifetimeSafety] Associate origins to all l-valued expressions (PR #156896)

2025-09-05 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/156896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Mark all DeclRefExpr as usages of the corresp. origin (PR #154316)

2025-09-05 Thread Utkarsh Saxena via cfe-commits
@@ -556,8 +554,47 @@ class FactGeneratorVisitor : public ConstStmtVisitor { return false; } + void handleAssignment(const Expr *LHSExpr, const Expr *RHSExpr) { +// Find the underlying variable declaration for the left-hand side. +if (const auto *DRE_LHS = +

[clang] [LifetimeSafety] Mark all DeclRefExpr as usages of the corresp. origin (PR #154316)

2025-09-04 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/154316 >From 87fedf5f99b0028ff939188625be884d4ac6486f Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 19 Aug 2025 12:00:53 + Subject: [PATCH] Identify DeclRefExpr as a use of an origin --- clang/lib/Analys

[clang] [LifetimeSafety] Mark all DeclRefExpr as usages of the corresp. origin (PR #154316)

2025-09-03 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/154316 >From 1312765602deb4bfbbebf1c8cf4dd85f3460bb10 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 19 Aug 2025 12:00:53 + Subject: [PATCH] Identify DeclRefExpr as a use of an origin --- clang/lib/Analys

[clang] [LifetimeSafety] Mark all DeclRefExpr as usages of the corresp. origin (PR #154316)

2025-09-03 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/154316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Fix duplicate loan generation for ImplicitCastExpr (PR #153661)

2025-09-03 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/153661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Fix duplicate loan generation for ImplicitCastExpr (PR #153661)

2025-09-03 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: ### Merge activity * **Sep 3, 2:28 PM UTC**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/153661). https://github.com/llvm/llvm-project/pull/153661 ___

[clang] [LifetimeSafety] Fix duplicate loan generation for ImplicitCastExpr (PR #153661)

2025-09-03 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/153661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-09-03 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/153661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-09-03 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: @Xazax-hun `AC.getCFGBuildOptions().setAllAlwaysAdd();` worked just fine. Thanks for the suggestion. https://github.com/llvm/llvm-project/pull/153661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-09-03 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/153661 >From 6c42309ef6b46167c65c398fd895aab21a095964 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 14 Aug 2025 06:57:44 + Subject: [PATCH] [LifetimeSafety] Track view types/gsl::Pointer. --- clang/lib/A

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-09-03 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/153661 >From 27e8bfcd7079d654621c1439d4637edde3fd805d Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 14 Aug 2025 06:57:44 + Subject: [PATCH] [LifetimeSafety] Track view types/gsl::Pointer. --- clang/lib/A

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-09-02 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/153661 >From 577d9638297f4383fa025b44d202903703863212 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 14 Aug 2025 06:57:44 + Subject: [PATCH] [LifetimeSafety] Track view types/gsl::Pointer. --- clang/lib/A

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-09-02 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: Seems to work fine. It is already added for a couple of other analyses so should be fine for us. https://github.com/llvm/llvm-project/pull/153661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-09-02 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/153661 >From 4576fa72454847f64a62ad0d403816cf4ad59505 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 14 Aug 2025 06:57:44 + Subject: [PATCH] [LifetimeSafety] Track view types/gsl::Pointer. --- clang/lib/A

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-09-02 Thread Utkarsh Saxena via cfe-commits
@@ -403,29 +404,17 @@ class FactManager { llvm::BumpPtrAllocator FactAllocator; }; -class FactGenerator : public ConstStmtVisitor { - using Base = ConstStmtVisitor; +class FactGeneratorVisitor : public ConstStmtVisitor { + using Base = ConstStmtVisitor; public: - FactG

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-09-02 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/153661 >From 28730f8c96061a77c594fd849ba21524e1f69bfb Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 14 Aug 2025 06:57:44 + Subject: [PATCH] [LifetimeSafety] Track view types/gsl::Pointer. --- clang/lib/A

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-09-02 Thread Utkarsh Saxena via cfe-commits
@@ -403,29 +404,20 @@ class FactManager { llvm::BumpPtrAllocator FactAllocator; }; -class FactGenerator : public ConstStmtVisitor { - using Base = ConstStmtVisitor; +class FactGeneratorVisitor : public ConstStmtVisitor { + using Base = ConstStmtVisitor; public: - FactG

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-09-02 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: > Thanks! > > I have one more question. So we need the reverse post order property of the > CFG to ensure that we visit everything in the right order. The only reason > why I am a bit unsure here, is because I wonder if it can ever cause some > trouble that the RAV visiting the

[clang] [clang][dataflow] Fix uninitialized memory bug. (PR #154575)

2025-08-20 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 approved this pull request. https://github.com/llvm/llvm-project/pull/154575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-08-19 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: This does introduce an extra layer of orchestration but** I like the current approach**. The `FactGeneratorVisitor` can now safely assume that all sub expressions must have been visited and does not have to case-by-case handle it during each Visit* methods. I think this becomes mo

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-08-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/153661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-08-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/153661 >From 3b3b93bb94b01d48bcca194b01eb9428ad19eaa4 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 14 Aug 2025 06:57:44 + Subject: [PATCH] [LifetimeSafety] Track view types/gsl::Pointer. --- clang/lib/A

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-08-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/153661 >From 440c3fe4037d7728831af927256f281f9d40aafb Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 14 Aug 2025 06:57:44 + Subject: [PATCH] [LifetimeSafety] Track view types/gsl::Pointer. --- clang/lib/A

[clang] [LifetimeSafety] Improve Origin information in debug output (PR #153951)

2025-08-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/153951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-08-19 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: >WDYT about this alternative of using a RAV driver ? >>Hmm, there is a change that this could be a bit simpler than the current >>solution. If you can give this a try to see where does that lead it would be >>awesome. Switched to using RAV for driving the FactGenerator @Xazax-hun

[clang] [LifetimeSafety] Improve Origin information in debug output (PR #153951)

2025-08-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 auto_merge_enabled https://github.com/llvm/llvm-project/pull/153951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Improve Origin information in debug output (PR #153951)

2025-08-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/153951 >From 2f46b55736b884c4ec9184f861b3be900ed102ff Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Sat, 16 Aug 2025 11:45:30 + Subject: [PATCH] Add decl/expr name to Origin's debug output --- clang/lib/Analy

[clang] [LifetimeSafety] Improve Origin information in debug output (PR #153951)

2025-08-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/153951 >From 2f46b55736b884c4ec9184f861b3be900ed102ff Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Sat, 16 Aug 2025 11:45:30 + Subject: [PATCH] Add decl/expr name to Origin's debug output --- clang/lib/Analy

[clang] [LifetimeSafety] Improve Origin information in debug output (PR #153951)

2025-08-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/153951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Enhance benchmark script for new sub analyses (PR #149577)

2025-08-18 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/149577 >From 7a8dd3eee64d77ed306a464bb827dbc90f8c1c6a Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Sat, 19 Jul 2025 15:40:36 + Subject: [PATCH] add live origins --- .../test/Analysis/LifetimeSafety/benchmark

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-08-18 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/153661 >From 2f329e7c06633b293988d56aea92768d6fe388b5 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 14 Aug 2025 06:57:44 + Subject: [PATCH 1/2] [LifetimeSafety] Track view types/gsl::Pointer. --- clang/l

[clang] [LifetimeSafety] Prevent duplicate loans and statement visits (PR #153661)

2025-08-18 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: >> The RAV would still need to maintain a Visited set > Could you elaborate on why? The CFG can contain sub expressions as individual CFG statements. Later parent expressions can again appear as independent CFGStmt. It is not guaranteed that all subexpressions of all expr types a

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-08-18 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/153661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Refactor FactGenerator to use RecursiveASTVisitor (PR #153661)

2025-08-18 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/153661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Prevent duplicate loans and statement visits (PR #153661)

2025-08-18 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/153661 >From 2f329e7c06633b293988d56aea92768d6fe388b5 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 14 Aug 2025 06:57:44 + Subject: [PATCH] [LifetimeSafety] Track view types/gsl::Pointer. --- clang/lib/A

[clang] [LifetimeSafety] Prevent duplicate loans and statement visits (PR #153661)

2025-08-18 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/153661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Prevent duplicate loans and statement visits (PR #153661)

2025-08-18 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/153661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Prevent duplicate loans and statement visits (PR #153661)

2025-08-18 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/153661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Prevent duplicate loans and statement visits (PR #153661)

2025-08-18 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/153661 >From dbb99ed734b7e1a8ba970862175faefdd010f3ef Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 14 Aug 2025 06:57:44 + Subject: [PATCH] [LifetimeSafety] Track view types/gsl::Pointer. --- clang/lib/A

  1   2   3   4   5   6   7   8   9   10   >