[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

shraiysh added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:625 + void applySimd(CanonicalLoopInfo *Loop, Value *IfCond, ConstantInt *Simdlen, + ConstantInt *Safelen); psoni2628 wrote: > shraiysh wrote: > > [nit

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

shraiysh added a comment. Minor comments. Thank you for working on this! Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:625 + void applySimd(CanonicalLoopInfo *Loop, Value *IfCond, ConstantInt *Simdlen, + ConstantInt *Safelen);

[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61fa7a88c7b6: [clang][OpenMP] Add IRBuilder support for taskgroup (authored by shraiysh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

shraiysh updated this revision to Diff 446355. shraiysh added a comment. Rebase with main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129992/new/ https://reviews.llvm.org/D129992 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/ta

[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

shraiysh added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5209 + OMPLexicalScope Scope(*this, S, OMPD_unknown); + if (CGM.getLangOpts().OpenMPIRBuilder && S.clauses().size() == 0) { +llvm::OpenMPIRBuilder &OMPBuilder = CGM.getOpenMPRuntime().getOMPBuild

[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

shraiysh updated this revision to Diff 445697. shraiysh added a comment. Moved checking to `isSupportedByOpenMPIRBuilder`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129992/new/ https://reviews.llvm.org/D129992 Files: clang/lib/CodeGen/CGStmt

[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

shraiysh created this revision. Herald added subscribers: guansong, yaxunl. Herald added a project: All. shraiysh requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch makes use of OMPIRBuil

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

shraiysh added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2596 // Check for unsupported clauses - if (!S.clauses().empty()) { -// Currently no clause is supported -return false; + for (OMPClause *C : S.clauses()) { +// Currently only simdlen

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

shraiysh added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2596 // Check for unsupported clauses - if (!S.clauses().empty()) { -// Currently no clause is supported -return false; + for (OMPClause *C : S.clauses()) { +// Currently only simdlen

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

shraiysh added inline comments. Comment at: clang/lib/Testing/CMakeLists.txt:33 + clangBasic + clangFrontend ) abidmalikwaterloo wrote: > Are these okay? In D105584 these were not No, this is not okay. There is some issue with these patches and I don't know

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

shraiysh added inline comments. Comment at: clang/lib/Testing/CMakeLists.txt:29 llvm_gtest + clangBasic + clangFrontend abidmalikwaterloo wrote: > shraiysh wrote: > > abidmalikwaterloo wrote: > > > shraiysh wrote: > > > > unrelated change? > > > When I rebas

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

shraiysh added a comment. > With this change the flang driver will not generate an executable unless it > is built with an option. Okay, thank you for the clarification. Is this a cmake option and? Are we documenting this somewhere except this patch summary, like on the flang documentation or

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

shraiysh added a comment. > clarify that execution is still restricted to developers via a flag. Just confirming what this means: After this patch, would `flang sample.f90` generate an executable? If not, how to generate an executable using `flang-new`? If yes, does this mean that if I just rep

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

shraiysh added inline comments. Comment at: clang/lib/Testing/CMakeLists.txt:29 llvm_gtest + clangBasic + clangFrontend abidmalikwaterloo wrote: > shraiysh wrote: > > unrelated change? > When I rebase, these changes were highlighted in the main branch which

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

shraiysh added a comment. Thanks for working on this. A couple comments. There are no testcases. Please add testcases. Comment at: clang/lib/Testing/CMakeLists.txt:29 llvm_gtest + clangBasic + clangFrontend unrelated change? Comment at:

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

shraiysh added a comment. Minor nits about documentation. LGTM given that verifier and assembly format will be added soon for each of these as a separate patch soon. Please wait for atleast one more +1. The OpenMP IRBuilder work does not have to wait for this patch to merge. You can start work

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

shraiysh added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:74-75 + // for the allocs. + // TODO: Create a dedicated alloca BasicBlock at function creation such that + // we do not need to move the current InertPoint here. +

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

shraiysh added a comment. LGTM. Can we please rebase this and fix the same in `convertOmpAtomicUpdate` and `convertOmpAtomicCapture` too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117835/new/ https://reviews.llvm.org/D117835 _

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

shraiysh added a comment. LGTM (will let others review as this includes changes to clang too and I am not familiar with it) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121374/new/ https://reviews.llvm.org/D121374 ___

[PATCH] D121198: [flang][driver] Add support for `-debug-dump-pft`

shraiysh accepted this revision. shraiysh added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121198/new/ https://reviews.llvm.org/D121198 __

[PATCH] D115650: [clangd] Disable support for clang-tidy suppression blocks (NOLINTBEGIN)

shraiysh added a comment. Hey folks, this commit seems to cause multiple buildbot failures 1 2 3 . Can someone pleas

[PATCH] D114143: [OpenMP][IRBuilder] Fix createSections

This revision was automatically updated to reflect the committed changes. Closed by commit rGec97e1206abd: [OpenMP][IRBuilder] Fix createSections (authored by shraiysh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114143/new/ https://reviews.llvm.

[PATCH] D114143: [OpenMP][IRBuilder] Fix createSections

shraiysh updated this revision to Diff 390935. shraiysh added a comment. Thanks for the review @Meinersbur . Rebase with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114143/new/ https://reviews.llvm.org/D114143 Files: clang/test/OpenMP/ca

[PATCH] D114143: [OpenMP][IRBuilder] Fix createSections

shraiysh added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114143/new/ https://reviews.llvm.org/D114143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D114143: [OpenMP][IRBuilder] Fix createSections

shraiysh created this revision. Herald added subscribers: rogfer01, guansong, hiraditya, yaxunl. shraiysh requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Fix for the case when

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fb52cb3f123: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write (authored by shraiysh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111992/new/ ht

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

shraiysh updated this revision to Diff 382537. shraiysh added a comment. Rebase with main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111992/new/ https://reviews.llvm.org/D111992 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp flang/lib/Semantics/

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

shraiysh added inline comments. Comment at: mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp:1246 +StringRef memOrder = op.memory_order().getValue(); +if (memOrder.equals("acq_rel") || memOrder.equals("release")) + return op.emitError( shraiysh wrote: >

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

shraiysh added a comment. Thanks for the review @peixin. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:513 + +def AtomicReadOp : OpenMP_Op<"atomic.read"> { + let arguments = (ins OpenMP_PointerLikeType:$address, peixin wrote: > How do you plan to h

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

shraiysh updated this revision to Diff 381772. shraiysh added a comment. Rebase with main, updated syntax. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111992/new/ https://reviews.llvm.org/D111992 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp fla

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

shraiysh added a comment. In D111992#3080308 , @kiranchandramohan wrote: > LGTM. > > My preference is the following one. If you agree then please make the change, > otherwise, you can keep it as is. Also, wait a couple of days to see whether > others h

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

shraiysh added a comment. Hi @kiranchandramohan. Thanks for the review. > %8 = omp.atomic.read %addr : memref -> i32 hint(speculative, > contended) memory_order(seq_cst) This cannot be done because the statement ends at optional clauses. This is dangerous in the following situation where par

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

shraiysh added a comment. Hi all, the NFC has been merged, and the build is passing. This is ready for review now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111992/new/ https://reviews.llvm.org/D111992

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

shraiysh updated this revision to Diff 380718. shraiysh added a comment. Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Rebase with main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111992/new/ https://reviews.llvm.or