ryee88 updated this revision to Diff 55707.
ryee88 added a comment.
Removed unnecessary code changes. This patch contains a unit test to detect a
regression of this global name specifier issue.
http://reviews.llvm.org/D16965
Files:
test/Parser/cxx-class.cpp
Index: test/Parser/cxx-class.cpp
ryee88 added a comment.
Yeah I don't think it's worth it to modify the general case wording to to
explicitly call out the degenerate global nested-name-specifier. It'll cause
more confusion for the general case.
At this point, do we just close the bug and keep the new unit tests?
http://revie
ryee88 added a comment.
In http://reviews.llvm.org/D16965#377864, @dblaikie wrote:
> Not sure I fully understand the issue with the existing diagnostic/change in
> wording.
>
> '::' is a nested name specifier, even if it's a degenerate case, I think - so
> the old wording doesn't seem wrong, as
ryee88 added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:3803
@@ +3802,3 @@
+
+// Per C++ standard [n3485] 3.4.4 Elaborated type specifiers, section 3:
+// "Cannot introduce an qualified".
aaron.ballman wrote:
> Can drop the N-paper reference, a
ryee88 added a comment.
Anyone want to pick up this review?
http://reviews.llvm.org/D16965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ryee88 added a subscriber: dblaikie.
ryee88 added a comment.
Anyone care to take a look?
http://reviews.llvm.org/D16965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ryee88 updated this revision to Diff 49866.
http://reviews.llvm.org/D16965
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/Parser/cxx-class.cpp
Index: test/Parser/cxx-class.cpp
===
--- test/Parser/
ryee88 added a comment.
Thanks! I don’t have commit permissions; can you submit for me?
http://reviews.llvm.org/D16949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ryee88 updated this revision to Diff 49577.
http://reviews.llvm.org/D16949
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaOverload.cpp
test/SemaCXX/overload-call.cpp
Index: test/SemaCXX/overload-call.cpp
===
--
ryee88 added a comment.
Yeah you’re right about this one being the original variant. I missed it when I
was reading through the tests in this file.
I’ve reworked it to reflect the new variants.
http://reviews.llvm.org/D16949
___
cfe-commits mailin
ryee88 updated this revision to Diff 49280.
ryee88 added a comment.
Moved test to a file that checks for similar diagnostics.
http://reviews.llvm.org/D16949
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaOverload.cpp
test/SemaCXX/overload-call.cpp
Index: test/SemaCXX/over
ryee88 added a comment.
any comments?
http://reviews.llvm.org/D16949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ryee88 updated this revision to Diff 48149.
ryee88 added a comment.
Keeping the number of test files to a minimum makes sense.
Couldn't find an existing test for this diagnostic. I did find a
cxx-reference.cpp that tests reference diagnostics so this seems like a
reasonable location for this ne
ryee88 updated this revision to Diff 47926.
ryee88 added a comment.
Messed up the diff. Uploading it again.
http://reviews.llvm.org/D16965
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/Parser/forward-declaration.cpp
Index: test/Parser/forward-declaration.cp
ryee88 updated this revision to Diff 47925.
ryee88 added a comment.
Sorry-- re-uploading the diff. Didn't notice I dropped the code changes.
http://reviews.llvm.org/D16949
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaOverload.cpp
test/Parser/overloaded-pointer-vs-referen
ryee88 updated this revision to Diff 47924.
ryee88 added a comment.
Added unit test as per review comments.
http://reviews.llvm.org/D16949
Files:
test/Parser/overloaded-pointer-vs-reference-hint.cpp
Index: test/Parser/overloaded-pointer-vs-reference-hint.cpp
=
ryee88 updated this revision to Diff 47922.
ryee88 added a comment.
Added unit tests.
http://reviews.llvm.org/D16965
Files:
test/Parser/forward-declaration.cpp
Index: test/Parser/forward-declaration.cpp
===
--- /dev/null
+++ tes
ryee88 added a comment.
Ping-- can someone look at this review?
http://reviews.llvm.org/D16949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ryee88 added a comment.
Ping-- I think this review got missed.
http://reviews.llvm.org/D16965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ryee88 created this revision.
ryee88 added reviewers: doug.gregor, gribozavr, francisco.lopes.
ryee88 added a subscriber: cfe-commits.
Bug 14644 - clang confuses scope operator for global namespace giving extra
qualification on member
This is a fix for this bug: https://llvm.org/bugs/show_bug.cg
ryee88 created this revision.
ryee88 added reviewers: doug.gregor, jyasskin, nicholas, rsmith.
ryee88 added a subscriber: cfe-commits.
This is bug 5941: https://llvm.org/bugs/show_bug.cgi?id=5941
I copied the extra suggestions from the complete type case to the incomplete
type case.
http://revi
21 matches
Mail list logo
