https://github.com/rprichard approved this pull request.
https://github.com/llvm/llvm-project/pull/111007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rprichard wrote:
> The github UI should show all changes to main? Not sure why a rebase would be
> necessary...?
Sorry, you're right. (Not sure why I didn't notice that before.)
The change looks good to me now.
https://github.com/llvm/llvm-project/pull/96171
_
rprichard wrote:
I rebased the changes so I could review them,
https://github.com/llvm/llvm-project/commit/640d2e631a4bc11e3afa030e30d05288ee954cb5.
The compiler-rt/cmake/config-ix.cmake file is still removing
`include(LLVMCheckCompilerLinkerFlag)`, but it needs to keep it now.
https://githu
rprichard wrote:
The previous `llvm_check_compiler_linker_flag` passes the same flag to both the
compile step and the linker step. Apparently, it's like a combined
`check_compiler_flag` and `check_linker_flag`. CMake apparently doesn't
implement this directly
(https://stackoverflow.com/questi
rprichard wrote:
> This check in libcxx/cmake/config-ix.cmake seems to break:
>
> ```
> check_cxx_compiler_flag(-nostdlib++ CXX_SUPPORTS_NOSTDLIBXX_FLAG)
> ```
This particular check was already using `check_cxx_compiler_flag` before this
PR, so it was broken(?), but it apparently doesn't matte
rprichard wrote:
This check in libcxx/cmake/config-ix.cmake seems to break:
```
check_cxx_compiler_flag(-nostdlib++ CXX_SUPPORTS_NOSTDLIBXX_FLAG)
```
It appears that it isn't passing either `-nostdlib++` or `-lc++` to the clang
linker command-line, but then `-lc++` _is_ passed to `ld.lld` becau
rprichard wrote:
> I was waiting for your recent PRs to land, but the android failures seem to
> persist even after them.
Yeah that's also what I noticed. My PRs were aimed at getting the Android
Dockerfile buildable again, but once it was buildable, the feature testing
failed.
It _seemed_ t
rprichard wrote:
Sorry, I didn't notice the ping until just now.
The CMake feature testing seems broken, on Android at least. Here's a
representative error from
`build/android-ndk-21-def-x86/CMakeFiles/CMakeError.log`:
```
Performing C++ SOURCE FILE Test CXX_SUPPORTS_NOSTDLIBXX_FLAG failed wi
@@ -22,6 +22,9 @@ set(LIBCXX_ENABLE_ABI_LINKER_SCRIPT OFF CACHE BOOL "")
set(LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY ON CACHE BOOL "")
set(LIBCXXABI_ENABLE_SHARED OFF CACHE BOOL "")
+# Android uses its own unwinder library
+set(LIBCXXABI_USE_LLVM_UNWINDER OFF CACHE BOOL "
Author: Ryan Prichard
Date: 2022-12-09T15:16:20-08:00
New Revision: 106a99276f9e7b9eec9542cc2b4dcd8489eb1a6b
URL:
https://github.com/llvm/llvm-project/commit/106a99276f9e7b9eec9542cc2b4dcd8489eb1a6b
DIFF:
https://github.com/llvm/llvm-project/commit/106a99276f9e7b9eec9542cc2b4dcd8489eb1a6b.diff
Author: Ryan Prichard
Date: 2022-07-21T17:23:29-07:00
New Revision: 02a25279aedcd959d060bba585adc0fe1cec3782
URL:
https://github.com/llvm/llvm-project/commit/02a25279aedcd959d060bba585adc0fe1cec3782
DIFF:
https://github.com/llvm/llvm-project/commit/02a25279aedcd959d060bba585adc0fe1cec3782.diff
Author: Ryan Prichard
Date: 2022-07-21T17:23:29-07:00
New Revision: 408a2638fda63b381f8750e16c78bc3c845cfdfd
URL:
https://github.com/llvm/llvm-project/commit/408a2638fda63b381f8750e16c78bc3c845cfdfd
DIFF:
https://github.com/llvm/llvm-project/commit/408a2638fda63b381f8750e16c78bc3c845cfdfd.diff
Author: Ryan Prichard
Date: 2021-03-09T18:09:53-08:00
New Revision: a478b0a199f4928041390d1f35dd5e226936b42c
URL:
https://github.com/llvm/llvm-project/commit/a478b0a199f4928041390d1f35dd5e226936b42c
DIFF:
https://github.com/llvm/llvm-project/commit/a478b0a199f4928041390d1f35dd5e226936b42c.diff
Author: Ryan Prichard
Date: 2021-02-25T15:40:02-08:00
New Revision: 91f8aacc040f5a458cfc2a10c4039e0028931455
URL:
https://github.com/llvm/llvm-project/commit/91f8aacc040f5a458cfc2a10c4039e0028931455
DIFF:
https://github.com/llvm/llvm-project/commit/91f8aacc040f5a458cfc2a10c4039e0028931455.diff
Author: Ryan Prichard
Date: 2021-02-22T16:54:05-08:00
New Revision: 729899f7b6bf6aff65988d895d7a639391a67608
URL:
https://github.com/llvm/llvm-project/commit/729899f7b6bf6aff65988d895d7a639391a67608
DIFF:
https://github.com/llvm/llvm-project/commit/729899f7b6bf6aff65988d895d7a639391a67608.diff
Author: Ryan Prichard
Date: 2021-02-22T16:54:05-08:00
New Revision: 729899f7b6bf6aff65988d895d7a639391a67608
URL:
https://github.com/llvm/llvm-project/commit/729899f7b6bf6aff65988d895d7a639391a67608
DIFF:
https://github.com/llvm/llvm-project/commit/729899f7b6bf6aff65988d895d7a639391a67608.diff
Author: Ryan Prichard
Date: 2021-01-13T16:38:36-08:00
New Revision: c82deed6764cbc63966374baf9721331901ca958
URL:
https://github.com/llvm/llvm-project/commit/c82deed6764cbc63966374baf9721331901ca958
DIFF:
https://github.com/llvm/llvm-project/commit/c82deed6764cbc63966374baf9721331901ca958.diff
Author: Ryan Prichard
Date: 2020-09-23T15:40:39-07:00
New Revision: 881aba7071c6e4cc2417e875ca5027ec7c0a92a3
URL:
https://github.com/llvm/llvm-project/commit/881aba7071c6e4cc2417e875ca5027ec7c0a92a3
DIFF:
https://github.com/llvm/llvm-project/commit/881aba7071c6e4cc2417e875ca5027ec7c0a92a3.diff
Author: Ryan Prichard
Date: 2020-09-23T15:40:39-07:00
New Revision: b16d6653c01cee37f51a98dd4092c4ef302c47a5
URL:
https://github.com/llvm/llvm-project/commit/b16d6653c01cee37f51a98dd4092c4ef302c47a5
DIFF:
https://github.com/llvm/llvm-project/commit/b16d6653c01cee37f51a98dd4092c4ef302c47a5.diff
Author: Ryan Prichard
Date: 2020-09-16T19:00:57-07:00
New Revision: fb1abe00635c1ec28e55921709904d5ca2e86a74
URL:
https://github.com/llvm/llvm-project/commit/fb1abe00635c1ec28e55921709904d5ca2e86a74
DIFF:
https://github.com/llvm/llvm-project/commit/fb1abe00635c1ec28e55921709904d5ca2e86a74.diff
Author: Ryan Prichard
Date: 2020-09-09T15:43:35-07:00
New Revision: 09d492902f178f60b3ab986360eadde9b5c8d359
URL:
https://github.com/llvm/llvm-project/commit/09d492902f178f60b3ab986360eadde9b5c8d359
DIFF:
https://github.com/llvm/llvm-project/commit/09d492902f178f60b3ab986360eadde9b5c8d359.diff
Author: Ryan Prichard
Date: 2020-09-08T15:49:35-07:00
New Revision: 88bf133c99c3124842c182a019306f83f2c1b856
URL:
https://github.com/llvm/llvm-project/commit/88bf133c99c3124842c182a019306f83f2c1b856
DIFF:
https://github.com/llvm/llvm-project/commit/88bf133c99c3124842c182a019306f83f2c1b856.diff
Author: Ryan Prichard
Date: 2020-09-03T15:59:45-07:00
New Revision: 673484b34189b1bccf73a2ec96968092bc8a26a7
URL:
https://github.com/llvm/llvm-project/commit/673484b34189b1bccf73a2ec96968092bc8a26a7
DIFF:
https://github.com/llvm/llvm-project/commit/673484b34189b1bccf73a2ec96968092bc8a26a7.diff
Author: Ryan Prichard
Date: 2020-08-26T18:22:06-07:00
New Revision: 3071d5ffba2337174f95f984bc1603a2be8b797d
URL:
https://github.com/llvm/llvm-project/commit/3071d5ffba2337174f95f984bc1603a2be8b797d
DIFF:
https://github.com/llvm/llvm-project/commit/3071d5ffba2337174f95f984bc1603a2be8b797d.diff
Author: Ryan Prichard
Date: 2020-08-26T18:22:03-07:00
New Revision: 7a457593efecc8f3e806cd3d022c480bc80d4fbb
URL:
https://github.com/llvm/llvm-project/commit/7a457593efecc8f3e806cd3d022c480bc80d4fbb
DIFF:
https://github.com/llvm/llvm-project/commit/7a457593efecc8f3e806cd3d022c480bc80d4fbb.diff
Author: Ryan Prichard
Date: 2020-08-24T14:07:20-07:00
New Revision: 9e32d7b6e7e6615dbc5049a53f8e2ba03ae0292f
URL:
https://github.com/llvm/llvm-project/commit/9e32d7b6e7e6615dbc5049a53f8e2ba03ae0292f
DIFF:
https://github.com/llvm/llvm-project/commit/9e32d7b6e7e6615dbc5049a53f8e2ba03ae0292f.diff
Author: Ryan Prichard
Date: 2020-08-22T17:12:52-07:00
New Revision: 3c1b2e338dfdf4f305b1cb40e2ebcb93a7e470c3
URL:
https://github.com/llvm/llvm-project/commit/3c1b2e338dfdf4f305b1cb40e2ebcb93a7e470c3
DIFF:
https://github.com/llvm/llvm-project/commit/3c1b2e338dfdf4f305b1cb40e2ebcb93a7e470c3.diff
Author: Ryan Prichard
Date: 2020-07-15T19:12:56-07:00
New Revision: fd802cc4dea4ed1a233ff725f98c686dc2836bf3
URL:
https://github.com/llvm/llvm-project/commit/fd802cc4dea4ed1a233ff725f98c686dc2836bf3
DIFF:
https://github.com/llvm/llvm-project/commit/fd802cc4dea4ed1a233ff725f98c686dc2836bf3.diff
Author: Ryan Prichard
Date: 2020-07-15T19:12:55-07:00
New Revision: 52d0a78b831584c46eda78b7cf349ab93ce13df0
URL:
https://github.com/llvm/llvm-project/commit/52d0a78b831584c46eda78b7cf349ab93ce13df0
DIFF:
https://github.com/llvm/llvm-project/commit/52d0a78b831584c46eda78b7cf349ab93ce13df0.diff
Author: Ryan Prichard
Date: 2020-06-17T16:17:37-07:00
New Revision: 6c4ce202267ee089e611b7bee1dc4f3eb07ba23d
URL:
https://github.com/llvm/llvm-project/commit/6c4ce202267ee089e611b7bee1dc4f3eb07ba23d
DIFF:
https://github.com/llvm/llvm-project/commit/6c4ce202267ee089e611b7bee1dc4f3eb07ba23d.diff
Author: rprichard
Date: Fri Oct 18 12:59:22 2019
New Revision: 375275
URL: http://llvm.org/viewvc/llvm-project?rev=375275&view=rev
Log:
[libunwind][Android] Fix findUnwindSections for ARM EHABI Bionic
Summary:
Fix the arm_section_length count. The meaning of the arm_section_length
field changed f
Author: rprichard
Date: Tue Oct 15 19:38:47 2019
New Revision: 374969
URL: http://llvm.org/viewvc/llvm-project?rev=374969&view=rev
Log:
[libunwind][Android] Improve workaround for PIE zero-dlpi_addr bug
Summary:
The workaround added in https://reviews.llvm.org/rL299575 appears to be
working aroun
32 matches
Mail list logo