[PATCH] D154893: [Clang] Fix some triviality computations

royjacobson added a comment. I, uh, got preoccupied by some recent events. Don't think I'll have the time for this unfortunately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154893/new/ https://reviews.llvm.org/D154893 _

[PATCH] D150075: Fix PR#62594 : static lambda call operator is not convertible to function pointer on win32

royjacobson added a comment. @shafik @aaron.ballman does any of you want to commandeer this diff? seems simple enough of a change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150075/new/ https://reviews.llvm.org/D150075 _

[PATCH] D154893: [Clang] Fix some triviality computations

royjacobson added a comment. In D154893#4646405 , @cor3ntin wrote: > @royjacobson ^ I did not have a lot of time for Clang the last few months unfortunately. I might take a look at this again next month when I'll have a bit more time. Repository: rG

[PATCH] D154893: [Clang] Fix some triviality computations

royjacobson updated this revision to Diff 543319. royjacobson added a comment. Update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154893/new/ https://reviews.llvm.org/D154893 Files: clang/docs/ReleaseNotes.rst clang/include/clan

[PATCH] D154893: [Clang] Fix some triviality computations

royjacobson added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1269 /// Determine whether this class has a non-trivial copy constructor /// (C++ [class.copy]p6, C++11 [class.copy]p12) bool hasNonTrivialCopyConstructor() const { shafik w

[PATCH] D154893: [Clang] Fix some triviality computations

royjacobson created this revision. royjacobson added a reviewer: shafik. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix #63352 and one other similar issue by slightly adjusting the computation

[PATCH] D151650: [clang-tidy] Update UnusedReturnValueCheck types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40af06ccc7bf: [clang-tidy] Update UnusedReturnValueCheck types (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D151650: [clang-tidy] Update UnusedReturnValueCheck types

royjacobson updated this revision to Diff 526468. royjacobson added a comment. Update docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151650/new/ https://reviews.llvm.org/D151650 Files: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueC

[PATCH] D151650: [clang-tidy] Update UnusedReturnValueCheck types

royjacobson updated this revision to Diff 526440. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151650/new/ https://reviews.llvm.org/D151650 Files: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp Index: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp

[PATCH] D151650: [clang-tidy] Update UnusedReturnValueCheck types

royjacobson created this revision. royjacobson added reviewers: chaitanyav, PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang-tools-extra. Herald

[PATCH] D149961: [Sema] Mark ineligibility of special member functions correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f59bee3d58f: [Sema] Mark ineligibility of special member functions correctly (authored by royjacobson). Changed prior to commit: https://reviews.llvm.org/D149961?vs=519857&id=523765#toc Repository:

[PATCH] D149961: [Sema] Mark ineligibility of special member functions correctly

royjacobson created this revision. royjacobson added reviewers: shafik, erichkeane. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I checked if the member function declaration was a copy constructor

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

royjacobson added a comment. In D141775#4255923 , @philnik wrote: > Is this essentially "is_trivial_for_the_purposes_of_abi"? I'd say so. Are you asking for a potential libc++ use case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147904: [Clang] Fix cast to BigIntType in hasUniqueObjectRepresentations

This revision was automatically updated to reflect the committed changes. Closed by commit rG016970d079c4: [Clang] Fix cast to BigIntType in hasUniqueObjectRepresentations (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14790

[PATCH] D147904: [Clang] Fix cast to BigIntType in hasUniqueObjectRepresentations

royjacobson created this revision. royjacobson added reviewers: shafik, cjdb. Herald added a subscriber: kristof.beyls. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A bad QualType cast caused us n

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

royjacobson added a comment. In D147655#4250056 , @rsmith wrote: > There has not been any stable ABI from any compiler targeting the Itanium C++ > ABI for constrained templates prior to this change. I don't think we need to > worry too much about people

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

royjacobson added a comment. I agree it doesn't affect too much code, but people do instantiate templates manually sometimes. IIUC, linking against shared libraries would break if that library does explicit instantiations of constrained functions. That concerns me a bit. Also, do you know if G

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d4d21e2e095: [Clang][AST] Fix __has_unique_object_representations computation for unnamed… (authored by royjacobson). Changed prior to commit: h

[PATCH] D147288: [clang][NFC] updates cxx_status for P2113R0

royjacobson added a comment. There was some discussion of this last year in this review: https://reviews.llvm.org/D128750 It's such an edge case that I don't think we should lose sleep about it until/unless the committee finds time to clarify the issue. Repository: rG LLVM Github Monorepo

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. royjacobson marked an inline comment as done. Closed by commit rG0eb06cb3aa27: [Sema] Stop stripping CV quals from *this captures in lambdas (authored by royjacobson).

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

royjacobson marked an inline comment as done. royjacobson added a comment. In D146168#4231457 , @aaron.ballman wrote: > LGTM aside from a minor nit, though I have some minor concerns that we may > silently break people's code by calling different overlo

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

royjacobson updated this revision to Diff 509436. royjacobson added a comment. fix unintended indentation & rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146168/new/ https://reviews.llvm.org/D146168 Files: clang/docs/ReleaseNotes.rst cl

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

royjacobson updated this revision to Diff 509298. royjacobson added a comment. Add some ((packed)) tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145852/new/ https://reviews.llvm.org/D145852 Files: clang/docs/ReleaseNotes.rst clang/lib/AS

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

royjacobson added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:2886-2889 +struct UnnamedEmptyBitfield { + int named; + int : 0; +}; royjacobson wrote: > shafik wrote: > > aaron.ballman wrote: > > > I think there's one more test to add: > > >

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

royjacobson added a comment. In D146329#4203174 , @shafik wrote: > I would have loved to test the case from > https://github.com/llvm/llvm-project/issues/61335 directly but I think in > order to do it nicely I need `__builtin_memset` to be usable in a c

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

royjacobson updated this revision to Diff 506295. royjacobson added a comment. Add the test case from the GH issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146168/new/ https://reviews.llvm.org/D146168 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

This revision was automatically updated to reflect the committed changes. Closed by commit rG765d8a192180: [Clang][Sema] Fix incorrect deletion of default constructors for some unions (authored by royjacobson). Changed prior to commit: https://reviews.llvm.org/D145851?vs=505620&id=505635#toc R

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

royjacobson updated this revision to Diff 505624. royjacobson added a comment. rebase + release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146168/new/ https://reviews.llvm.org/D146168 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema

[PATCH] D146168: [Sema] Stop stripping CV quals from *this captures in lambdas

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146168 Files: clang/lib/Sema/SemaExprCXX.cpp c

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson updated this revision to Diff 505620. royjacobson marked an inline comment as done. royjacobson added a comment. slimmer codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145851/new/ https://reviews.llvm.org/D145851 Files: c

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

royjacobson marked an inline comment as done. royjacobson added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:2886-2889 +struct UnnamedEmptyBitfield { + int named; + int : 0; +}; shafik wrote: > aaron.ballman wrote: > > I think there's one mor

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson marked 2 inline comments as done. royjacobson added inline comments. Comment at: clang/test/CodeGen/union-non-trivial-member.cpp:30 +// CHECK-NEXT: +// CHECK-NEXT: define linkonce_odr dso_local void @_ZN2UnionIntC2Ev(ptr noundef nonnull align 4 dereferenceable(4) %t

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson added a comment. Oops, sorry for the bad codegen test and thanks for the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145851/new/ https://reviews.llvm.org/D145851 ___ cfe-commits m

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson updated this revision to Diff 505216. royjacobson added a comment. Fix the codegen test, add a standard ref to the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145851/new/ https://reviews.llvm.org/D145851 Files: clang/docs/

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

royjacobson marked 2 inline comments as done. royjacobson added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2817 +// unique representation. +if (Field->isUnnamedBitfield() && BitfieldSize > 0) + return std::nullopt; aaron.ballman wrote:

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

royjacobson updated this revision to Diff 504736. royjacobson added a comment. Add a test case, slightly simpler modeling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145852/new/ https://reviews.llvm.org/D145852 Files: clang/docs/ReleaseNotes.

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson marked 2 inline comments as done. royjacobson added a comment. In D145851#4189158 , @erichkeane wrote: > Generally looks good to me. Do we do anything special if there are multiple > initializers? Also, can we have a codegen test that vali

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson updated this revision to Diff 504724. royjacobson added a comment. Add more tests, small nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145851/new/ https://reviews.llvm.org/D145851 Files: clang/docs/ReleaseNotes.rst clang/lib/S

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson updated this revision to Diff 504391. royjacobson added a comment. Small cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145851/new/ https://reviews.llvm.org/D145851 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclC

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

royjacobson updated this revision to Diff 504390. royjacobson added a comment. Handle 0-length unnamed bit fields as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145852/new/ https://reviews.llvm.org/D145852 Files: clang/docs/ReleaseNotes.

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

royjacobson updated this revision to Diff 504376. royjacobson added a comment. Change to a simpler fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145852/new/ https://reviews.llvm.org/D145852 Files: clang/docs/ReleaseNotes.rst clang/lib/AST

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As pointed out in https://github.com/llvm/llvm-project/issues/61336, objects with unnamed bitfields aren't be uniqu

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a union has explicit initializers for some members, we shouldn't delete its default constructor. Fixes https://gi

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

royjacobson added a comment. In D140996#4185795 , @bolshakov-a wrote: > @royjacobson, I've added some test cases for using the new NTTP arguments in > clang modules. It uses serialization, in principle. Or more specialized tests > are still needed? No

[PATCH] D145047: Fix broken link on Clang documentation page

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc10715f9bb3: Fix broken link on Clang documentation page (authored by tupaschoal, committed by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D145047: Fix broken link on Clang documentation page

royjacobson accepted this revision. royjacobson added a comment. Thanks! Do you need me to land this for you? If so, could you please provide name + email to sign the commit with? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145047/new/ https://r

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

royjacobson added a comment. In D143851#4153270 , @carlosgalvezp wrote: > LGTM, thanks for the contribution! Do you have commit rights or would you > like that we land it for you? If so, please provide name and email for > attribution. I have commit r

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa56e66bf752: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor… (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

royjacobson added a comment. There are no AST [de]serialization tests in this PR, right? Would be nice to add some. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 ___

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

royjacobson added a comment. friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143851/new/ https://reviews.llvm.org/D143851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D144572: [C++20] Stop claiming full support for consteval (for the moment!)

royjacobson added a comment. In D144572#4145614 , @cor3ntin wrote: > @aaron.ballman is the plan to backport that to clang 16? I think it probably > should. > We ought to try to improve the situation for clang 17 cxx_status.html is always updated from tr

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

This revision was automatically updated to reflect the committed changes. Closed by commit rG000ec50ef511: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases. (authored by royjacobson). Changed prior to commit: https://reviews.llvm.org/D143891?vs=496884&id=499635#to

[PATCH] D144572: [C++20] Stop claiming full support for consteval (for the moment!)

royjacobson accepted this revision. royjacobson added a comment. This revision is now accepted and ready to land. +1 from me, at least as long as we don't define the feature test macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144572/new/ http

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

royjacobson added a comment. It's an interesting discussion, I just want to remind that this change is for triviality rules from P0848 (conditionally trivial member functions) which is only going to ship in Clang 16 anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

royjacobson added a comment. In D143851#4126453 , @ClockMan wrote: > Thing is that same issue may happen with all other members, what about > copy/move constructors defaulted in .cpp (just to speed up compilation for > classes with many members). > Best

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson closed this revision. royjacobson added a comment. Landed in https://github.com/llvm/llvm-project/commit/be701ab08f12daf9437c2db6d08a1731cf1df34c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D14257

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

royjacobson added inline comments. Comment at: clang/lib/AST/Type.cpp:2495 + // FIXME: We should merge this definition of triviality into + // CXXRecordDecl::isTrivial. Currently it computes the wrong thing. + return ClassDecl->hasTrivialDefaultConstructor() && ---

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6259eca16f6: [Clang] Export CanPassInRegisters as a type trait (authored by royjacobson). Changed prior to commit: https://reviews.llvm.org/D1417

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

royjacobson updated this revision to Diff 496998. royjacobson added a comment. Address CR comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143851/new/ https://reviews.llvm.org/D143851 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

royjacobson added a comment. In D143891#4122660 , @aaron.ballman wrote: > This is an ABI breaking change, isn't it? (The type trait now returns > something different than it did before, which could change instantiations or > object layout.) Technicall

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

royjacobson created this revision. royjacobson added reviewers: erichkeane, cor3ntin. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Up to C++20, hasDefaultConstructor and !hasNonTrivialDefaultConst

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

royjacobson created this revision. royjacobson added reviewers: carlosgalvezp, njames93, aaron.ballman. Herald added subscribers: kbarton, xazax.hun, nemanjai. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subsc

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson added a subscriber: clang-language-wg. royjacobson marked 2 inline comments as done. royjacobson added a comment. friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578 _

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson updated this revision to Diff 496771. royjacobson added a comment. Rebase to include the RISC-V changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578 Files: clang/docs/ReleaseNotes.rst I

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson added inline comments. Comment at: clang/docs/ReleaseNotes.rst:16 Release notes for previous releases can be found on - `the Download Page `_. + `the Releases Page `_.

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson updated this revision to Diff 493360. royjacobson marked 2 inline comments as done. royjacobson added a comment. 15 -> Clang 15 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578 Files: clang/d

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson marked an inline comment as done. royjacobson added a comment. In D142578#4088011 , @tschuett wrote: > IDK. Clang 16 is fully is a fully conformant C++20 except for some DRs. Or > beginning with Clang 16, we start a long-term project to overh

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson marked 5 inline comments as done. royjacobson added inline comments. Comment at: clang/docs/ReleaseNotes.rst:452-454 + - Now diagnoses use of a member access expression or array subscript expression within ``__builtin_offsetof`` and ``offsetof`` as being a Clang e

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson updated this revision to Diff 493008. royjacobson added a comment. - Remove redundant paragraph from the intro - Remove outdated bug fix bullet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson added a comment. In D142578#4087974 , @tschuett wrote: > I am not the only one who has a different background. If the introduction > says this is the introduction of the release notes, I am not super motivated > to read on. I would prefer to

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson added a comment. Thanks Erich and Emilia! The html file is attached here, I think it's probably easier to proof read that way. (Took me a bit to figure out the CMake magic...) F26271094: ReleaseNotes.html Repository: rG LLVM Github Monorepo

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson updated this revision to Diff 492516. royjacobson added a comment. - Address comments from Erich and Emilia - Validate that the rst actually builds an html file - Fix some missing backticks and underscores Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson created this revision. Herald added subscribers: s.egerton, mstorsjo, simoncook, dschuff. Herald added a project: All. royjacobson requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead, sstefan1, aheejin. Herald added a reviewer: jdoerfert. Herald added

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

royjacobson updated this revision to Diff 491102. royjacobson added a comment. fix the test after diag change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141775/new/ https://reviews.llvm.org/D141775 Files: clang/docs/LanguageExtensions.rst c

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5387 + return RD->canPassInRegisters(); +return true; } shafik wrote: > erichkeane wrote: > > Is there good reason to return true for all non-record types? Should we > > i

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

royjacobson updated this revision to Diff 489934. royjacobson added a comment. Reject non class types, update doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141775/new/ https://reviews.llvm.org/D141775 Files: clang/docs/LanguageExtensions.rs

[PATCH] D141803: [Clang] Reject in-class defaulting of previously declared comparison operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a763343e29f: [Clang] Reject in-class defaulting of previously declared comparison operators (authored by royjacobson). Changed prior to commit: h

[PATCH] D141803: [Clang] Reject in-class defaulting of previously declared comparison operators

royjacobson updated this revision to Diff 489607. royjacobson added a comment. rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141803/new/ https://reviews.llvm.org/D141803 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Bas

[PATCH] D141803: [Clang] Reject in-class defaulting of previously declared comparison operators

royjacobson created this revision. royjacobson added a reviewer: clang-language-wg. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Comparison operators are not allowed to be defaulted if they were p

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

royjacobson created this revision. royjacobson added reviewers: erichkeane, aaron.ballman. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While working on D140664 ,

[PATCH] D140664: [Sema] Don't mark deleted special member functions as non-trivial

royjacobson reopened this revision. royjacobson added a comment. This revision is now accepted and ready to land. So, I had a quick look at this. Turns out this fix changed the argument passing ABI for those classes on the Sony PS4. This is probably not acceptable :) Putting this behind an ABI c

[PATCH] D140664: [Sema] Don't mark deleted special member functions as non-trivial

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5dd37ac139a: [Sema] Don't mark deleted special member functions as non-trivial (authored by royjacobson). Repository: rG LLVM Github Monorepo CH

[PATCH] D140664: [Sema] Don't mark deleted special member functions as non-trivial

royjacobson updated this revision to Diff 486347. royjacobson added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140664/new/ https://reviews.llvm.org/D140664 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D140664: [Sema] Don't mark deleted special member functions as non-trivial

royjacobson updated this revision to Diff 486105. royjacobson edited the summary of this revision. royjacobson added a comment. Rebase + remove extra class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140664/new/ https://reviews.llvm.org/D140664

[PATCH] D140876: [clang][C++20] Non-dependent access checks in requires expression.

royjacobson added a comment. In D140876#4023286 , @ilya-biryukov wrote: > Should access checks should happen in the context where `concept` is written > or where it's used? Is there a standard wording around it? Unfortunately, only a standard wording i

[PATCH] D140664: [Sema] Don't mark deleted special member functions as non-trivial

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As noted in https://github.com/llvm/llvm-project/issues/59624, we sometimes mark implicitly deleted special member

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

royjacobson added a comment. This seems to be stuck with no reviewers, is there any way to help here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137302/new/ https://reviews.llvm.org/D137302 ___ cfe-co

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

royjacobson added a comment. Thanks for picking this up! :) The (non-wording) paper makes a pretty convincing case to just apply this retroactively to any C++11 code (https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2644r1.pdf). I think we should apply this retroactively, maybe add a

[PATCH] D139038: [Clang] Don't consider default constructors ineligible if the more constrained constructor is a template

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d58c95635cc: [Clang] Don't consider default constructors ineligible if the more constrained… (authored by royjacobson). Repository: rG LLVM Githu

[PATCH] D139038: [Clang] Don't consider default constructors ineligible if the more constrained constructor is a template

royjacobson created this revision. Herald added a project: All. royjacobson updated this revision to Diff 479935. royjacobson added a comment. royjacobson retitled this revision from "Draft fix for 59206" to "[Clang] Don't consider default constructors ineligible if the more constrained constructo

[PATCH] D138603: [Clang] Implement LWG3823 for __is_aggregate

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13c32288354b: [Clang] Implement LWG3823 for __is_aggregate (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D138749: [clang] Compare constraints before diagnosing mismatched ref qualifiers (GH58962)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. royjacobson marked 2 inline comments as done. Closed by commit rG3c75feab3bbd: [clang] Compare constraints before diagnosing mismatched ref qualifiers… (authored by roy

[PATCH] D138749: [clang] Compare constraints before diagnosing mismatched ref qualifiers (GH58962)

royjacobson marked 3 inline comments as done. royjacobson added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:1324 +if ((NewRC != nullptr) != (OldRC != nullptr)) + // RC are most certainly different - these are overloads. + return true; --

[PATCH] D138749: [clang] Compare constraints before diagnosing mismatched ref qualifiers (GH58962)

royjacobson updated this revision to Diff 478502. royjacobson added a comment. Remove redundant comments, use Sema::AreConstraintExpressionsEqual instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138749/new/ https://reviews.llvm.org/D138749 F

[PATCH] D138603: [Clang] Implement LWG3823 for __is_aggregate

royjacobson updated this revision to Diff 478495. royjacobson edited the summary of this revision. royjacobson added a comment. rebase to retry CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138603/new/ https://reviews.llvm.org/D138603 Files:

[PATCH] D138387: [Clang] Implement static operator[]

This revision was automatically updated to reflect the committed changes. Closed by commit rG3faf1f17a5c3: [Clang] Implement static operator[] (authored by royjacobson). Changed prior to commit: https://reviews.llvm.org/D138387?vs=477550&id=478493#toc Repository: rG LLVM Github Monorepo CHA

[PATCH] D138603: [Clang] Implement LWG3823 for __is_aggregate

royjacobson marked an inline comment as done. royjacobson added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:556 static_assert(__is_aggregate(EmptyArMB), ""); static_assert(!__is_aggregate(void), ""); static_assert(!__is_aggregate(const volatile void),

[PATCH] D138749: [clang] Compare constraints before diagnosing mismatched ref qualifiers (GH58962)

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As noticed in GH58962, we should only diagnose illegal overloads of member functions when the ref qualifiers don't

[PATCH] D138603: [Clang] Implement LWG3823 for __is_aggregate

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LWG3823 says that arrays of incomplete types are aggregates. Fix the clang builtin to match that. Repository: r

[PATCH] D138387: [Clang] Implement static operator[]

royjacobson marked an inline comment as done. royjacobson added a comment. In D138387#3944211 , @cor3ntin wrote: > Beside the formatting nitpick this looks good Thanks! I'll wait until next week to let other people have a chance to take a look. Reposi

  1   2   3   4   >