royjacobson created this revision.
royjacobson added reviewers: chaitanyav, PiotrZSL.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
royjacobson requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Update the types for UnusedReturnValueCheck after D151383
<https://reviews.llvm.org/D151383>.
1. Add std::errc, std:error_condition
2. Remove `absl::Status` - it's marked as `[[nodiscard]]` anyway so it's
redundant (and might create double warnings) to check it.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D151650
Files:
clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp
Index: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp
===================================================================
--- clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp
+++ clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp
@@ -126,10 +126,12 @@
"::strsignal;"
"::ttyname")),
CheckedReturnTypes(utils::options::parseStringList(
- Options.get("CheckedReturnTypes", "::std::error_code;"
- "::std::expected;"
- "::boost::system::error_code;"
- "::abseil::Status"))) {}
+ Options.get("CheckedReturnTypes",
+ "::std::error_code;",
+ "::std::error_condition;",
+ "::std::errc;",
+ "::std::expected;",
+ "::boost::system::error_code"))) {}
void UnusedReturnValueCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
Options.store(Opts, "CheckedFunctions", CheckedFunctions);
Index: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp
===================================================================
--- clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp
+++ clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp
@@ -126,10 +126,12 @@
"::strsignal;"
"::ttyname")),
CheckedReturnTypes(utils::options::parseStringList(
- Options.get("CheckedReturnTypes", "::std::error_code;"
- "::std::expected;"
- "::boost::system::error_code;"
- "::abseil::Status"))) {}
+ Options.get("CheckedReturnTypes",
+ "::std::error_code;",
+ "::std::error_condition;",
+ "::std::errc;",
+ "::std::expected;",
+ "::boost::system::error_code"))) {}
void UnusedReturnValueCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
Options.store(Opts, "CheckedFunctions", CheckedFunctions);
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
