[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

lebedev.ri added a comment. In D142123#4066460 , @aaron.ballman wrote: > In D142123#4066447 , @lebedev.ri > wrote: > >> In D142123#4066351 , @njames93 >> wrote: >> >>>

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

lebedev.ri added a comment. In D142123#4066351 , @njames93 wrote: > Given the fact its non-standard, it has caveats and peoples eagerness to > blindly enable all checks (or all checks from a module). > I feel this check would likely cause more harm than

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

lebedev.ri added a comment. In D136651#4063818 , @friss wrote: > In D136651#4063632 , @lebedev.ri > wrote: > >> In D136651#4063597 , @friss wrote: >> >>> In D136651#40600

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

lebedev.ri added a comment. In D136651#4063597 , @friss wrote: > In D136651#4060071 , @lebedev.ri > wrote: > >> Docs still missing. > > Sorry @lebedev.ri I missed your earlier comment about this. What format of

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

lebedev.ri added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142033/new/ https://reviews.llvm.org/D142033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/test/CodeGenOpenCL/fdeclare-opencl-builtins.cl:20 // Test that Attr.Const from OpenCLBuiltins.td is lowered to a readnone attribute. +// FIXME: we don't, though. // CHECK-LABEL: @t

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added a comment. Ok, so. I looked really hard, and essentially i'm not sure we can just change those attributes from implying `readonly`/`readnone`. Things kinda just fall apart Comment at: clang/test/CodeGenOpenCL/fdeclare-opencl-builtins.cl:20 // Test that Attr.C

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri updated this revision to Diff 489975. lebedev.ri added subscribers: Anastasia, arsenm. lebedev.ri added a comment. Ok, if we must not unconditionally emit the memory attributes, then let's not. Please stamp? :) @Anastasia @venvh @arsenm This breaks opencl headers in a way i do not und

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

lebedev.ri added a comment. Docs still missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

lebedev.ri added a comment. In D141899#4058173 , @LuoYuanke wrote: > @zixuan-wu, changing x86_amx would break our internal code. May I know the > motivation to change the type? I just want to point out that generally "causes [too much] churn downstream"

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

lebedev.ri added a comment. Why is it not sufficient to link to `RISCVTargetParserTableGen`, but is sufficient to link to `LLVMTargetParser`? Does `RISCVTargetParserTableGen` itself not link to `LLVMTargetParser`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added a comment. @jdoerfert can you please clarify, do you believe we are fine as-is, or need to change attributes we emit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138958/new/ https://reviews.llvm.org/D138958

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added subscribers: nlopes, regehr. lebedev.ri added a comment. In D138958#4054903 , @jdoerfert wrote: > In D138958#4045567 , @efriedma > wrote: > >> From an IR semantics standpoint, I'm not sure the `m

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. What's the status here? Should this be abandoned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586

[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D431

[PATCH] D134588: [clang-tidy] Fix bugprone-exception-escape warn on noexcept calls

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D130209: [clang-tidy][NFC] Update tests to specify CheckOptions using new syntax

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D97204: [RFC] Clang 64-bit source locations

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: steakhal, StephenFan. Herald added a reviewer: NoQ. Herald added a reviewer: njames93. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to c

[PATCH] D105494: [clang] Introduce a union inside ProgramPoint.

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a reviewer: NoQ. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Gith

[PATCH] D121629: clang: also check alloc_alignment claims in return

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D115118: [clang-tidy] Assume that `noexcept` functions won't throw anything in `bugprone-exception-escape` check

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105495: [clang] Make negative getLocWithOffset widening-safe.

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: steakhal, StephenFan. Herald added a reviewer: NoQ. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHA

[PATCH] D105497: [clang] Serialize source locations as 64-bit in PCH.

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a reviewer: njames93. Herald added projects: clang-tools-extra, All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository:

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D78028: move shebangs from python2 to python3

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: cfe-commits, llvm-commits, Moerafaat, zero9178, Enna1, bzcheeseman, sdasgup3, carlosgalvezp, wenzhicui, wrengr, cota, StephenFan, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, stephenne

[PATCH] D125272: [clang] Add -fcheck-new support

lebedev.ri resigned from this revision. lebedev.ri added a comment. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D135658: demangle OptFunction trace names

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Reposit

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D115848: tidy-llvm

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review may be stuck/dead, consider abandoning if no longer relevant. Removin

[PATCH] D96223: [clang-tidy] Simplify static assert check

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG L

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monore

[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. CHANGES SINCE LAST ACTION https:/

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: Naghasan, StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer rel

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Mon

[PATCH] D63089: [clang] Warn on implicit boolean casts in more contexts (PR34180)

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monore

[PATCH] D59859: [clang-tidy] FIXIT for implicit bool conversion now obeys upper case suffixes if enforced.

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longe

[PATCH] D58811: [clang] Fix misuses of char width to char align

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rC Clang CHANGES SIN

[PATCH] D63929: [clang-tidy] - Introduce abseil-prefixed-thread-annotations check.

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Herald added subscribers: carlosgalvezp, StephenFan, mgehre. Herald added a reviewer: njames93. Herald added projects: clang-tools-extra, All. This review seems to be stuck/dead, co

[PATCH] D50852: [clang-tidy] abseil-auto-make-unique

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: StephenFan, mgehre. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relev

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added a comment. In D138958#4045567 , @efriedma wrote: > From an IR semantics standpoint, I'm not sure the `memory(none)` marking is > right if the function throws an exception. Then `memory(read)` would be wrong, either. A bit of a hot take:

[PATCH] D141561: [clang] True `noexcept` (`-fstrict-noexcept` language dialect)

lebedev.ri created this revision. lebedev.ri added reviewers: aaron.ballman, rjmccall, efriedma, jcranmer, jyknight, rsmith. lebedev.ri added a project: LLVM. Herald added subscribers: StephenFan, dschuff. Herald added a project: All. lebedev.ri requested review of this revision. Herald added subs

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri updated this revision to Diff 488343. lebedev.ri marked an inline comment as done. lebedev.ri edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138958/new/ https://reviews.llvm.org/D138958 Files: clang-t

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri marked 2 inline comments as done. lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4138 + "functions and statements">; + let SimpleHandler = 1; +} aaron.ballman wrote: > lebedev.ri wrote: > >

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri marked 2 inline comments as done. lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4138 + "functions and statements">; + let SimpleHandler = 1; +} aaron.ballman wrote: > lebedev.ri wrote: > >

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4133 +def NoUnwind : DeclOrStmtAttr { + let Spellings = [Clang<"nounwind", /*allowInC =*/0>]; + let Accessors = [Accessor<"isClangNoUnwind", [CXX11<"clang", "nounwind">]>]; aaron.ba

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri updated this revision to Diff 487933. lebedev.ri marked 10 inline comments as done. lebedev.ri added a comment. @aaron.ballman thank you for taking a look! Addressed all review notes other than the SEH question and the simplehandler one. (i'll deal with whitespace changes when committi

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:565 +returning a value. They can not write to memory, but may read memory that is +immutable between invocations of the function. + erichkeane wrote: > A quick sentence somewhere

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a comment. In D137381#4038716 , @MaskRay wrote: > I am unfamiliar with Clang codegen so I am just commenting about what a user > may feel about this feature. > > `compiler-rt/test/ubsan/TestCases/Misc/exception-escape.cpp` cannot > demo

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri updated this revision to Diff 487548. lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. In D138958#4037526 , @erichkeane wrote: > 2 quick nits, otherwise LFTM. @erichkeane thank you for the review! @aaron.ballman would

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137381/new/ https://reviews.llvm.org/D137381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added a comment. Herald added a subscriber: StephenFan. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138958/new/ https://reviews.llvm.org/D138958 ___ cfe-commits mailing list cfe-commits

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

lebedev.ri added a comment. As someone who has no idea what this does, this seems to be missing docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 ___ cfe-co

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

lebedev.ri requested changes to this revision. lebedev.ri added a comment. In D140467#4010675 , @pengfei wrote: >> If it exists it must be tested. >> Every piece of code generation needs to be tested. > > Let me show you the number: > > $ grep -rho '__b

[PATCH] D140281: [X86] Rename CMPCCXADD intrinsics.

lebedev.ri added a comment. In D140281#4006650 , @FreddyYe wrote: > In D140281#4004707 , @lebedev.ri > wrote: > >> This patch says what it does, but not why it does what it does. > > Sorry for not mention. This p

[PATCH] D140281: [X86] Rename CMPCCXADD intrinsics.

lebedev.ri added a comment. This patch says what it does, but not why it does what it does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140281/new/ https://reviews.llvm.org/D140281 ___ cfe-commits mail

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a comment. Last(?) ping of the year? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137381/new/ https://reviews.llvm.org/D137381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added a comment. Last(?) ping of the year? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138958/new/ https://reviews.llvm.org/D138958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

lebedev.ri added a comment. This is missing a test, like the original commit mentioned. Why can you not just use the the split variant, `-X clang ...`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139717/new/ https://reviews.llvm.org/D139717

[PATCH] D139647: [opt] Disincentivize new tests from using old pass syntax

lebedev.ri added a comment. @aeubanks Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139647/new/ https://reviews.llvm.org/D139647 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D139006: [UpdateTestChecks] Match define for labels

lebedev.ri added a subscriber: nikic. lebedev.ri added a comment. In D139006#3981326 , @sebastian-ne wrote: > I guess this is fine to merge. I’ll leave it for a day in case someone has > more comments. I guess, we could be pedantic and post an RFC to d

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/test/CodeGen/windows-seh-EHa-CppCondiTemps.cpp:3 +// FIXME: this check appears to be miscompiled? +// XFAIL: * tentzen wrote: > lebedev.ri wrote: > > efriedma wrote

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

lebedev.ri added a comment. In D139197#3977370 , @carlosgalvezp wrote: > @lebedev.ri If you are happy with the patch, would you mind approving it? Or > do you have additional comments that should be addressed? The patch does not > need to be approved b

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added a comment. (ping, maybe) In D138958#3968118 , @lebedev.ri wrote: > I've been thinking, and it seems to me that explicitly opting into > `__attribute__((nounwind))`-provided semantics should override > the `__attribute__((nothrow))`/`noe

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri marked 2 inline comments as done. lebedev.ri added inline comments. Comment at: clang/test/CodeGen/windows-seh-EHa-CppCondiTemps.cpp:3 +// FIXME: this check appears to be miscompiled? +// XFAIL: * efriedma wrote: > lebedev.ri wrote: > > tentzen wrote

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added inline comments. Comment at: clang/test/CodeGen/windows-seh-EHa-CppCondiTemps.cpp:3 +// FIXME: this check appears to be miscompiled? +// XFAIL: * tentzen wrote: > lebedev.ri wrote: > > This test broke once we always started adding (outermost) U

[PATCH] D139267: Supporting tbaa.struct metadata generation for bitfields

lebedev.ri added reviewers: wsmoses, jdoerfert. lebedev.ri added a comment. Certainly needs tests. I'm not sure if anyone actually knows this area of LLVM, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139267/new/ https://reviews.llvm.org/D

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a subscriber: tentzen. lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5402-5411 +if (SanOpts.has(SanitizerKind::ExceptionEscape) && +ExceptionEscapeUBLastInvokeSrcLoc) { + llvm::Constant *CheckSourceLocation = EmitChec

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri marked an inline comment as done. lebedev.ri added a comment. I've been thinking, and it seems to me that explicitly opting into `__attribute__((nounwind))`-provided semantics should override the `__attribute__((nothrow))`/`noexcept` semantics. So looks like i should look into exception

[PATCH] D135658: demangle OptFunction trace names

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. Old pass manager is dead. There is no point in making improvements to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135658/

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

lebedev.ri added a comment. > This shouldn't be a blocker for this patch though, it's just removing > functionality that belongs in another check. As said, the check is 1 day old > so it's unlikely anyone is relying on it yet :) SGTM in general. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D139197: Do not warn about redundant static in misc-use-anonymous-namespace

lebedev.ri added a comment. I was commenting because we already have a similar diagnostic in clang-tidy 15: namespace { static void foo(); static void bar(){} void foo() {} static int x; } $ clang-tidy-15 -checks=\*,-llvmlibc-* /tmp/test.cpp Error while trying to load a

[PATCH] D139197: Do not warn about redundant static in misc-use-anonymous-namespace

lebedev.ri added a comment. This patch should not land before that one does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139197/new/ https://reviews.llvm.org/D139197 ___ cfe-commits mailing list cfe-co

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2725 NoReturn = true; -if (FD->hasAttr()) +if (FD->hasAttr() || FD->hasAttr()) AddEHEdge = false; erichkeane wrote: > lebed

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri updated this revision to Diff 479413. lebedev.ri marked 5 inline comments as done. lebedev.ri added a comment. @erichkeane thank you for taking a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138958/new/ https://reviews.llvm.org/D1

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added inline comments. Comment at: clang/docs/ReleaseNotes.rst:841 operator. -- ``clang_Cursor_getNumTemplateArguments``, ``clang_Cursor_getTemplateArgumentKind``, - ``clang_Cursor_getTemplateArgumentType``, ``clang_Cursor_getTemplateArgumentValue`` and +- ``cl

[PATCH] D139017: Changed the intentional spelling errors back to the original, made more slight grammar corrections

lebedev.ri added a comment. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139017/new/ https://reviews.llvm.org/D139017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D139006: [UpdateTestChecks] Match define for labels

lebedev.ri added a comment. In D139006#3960466 , @mtrofin wrote: > LGTM, but I'd wait for Johannes to review it, too (because of > e67f6477fd1ed29acbeddf8482c25d8db826912f > . I for >

[PATCH] D139006: [UpdateTestChecks] Match define for labels

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LGTM. I do think this is an important fix, not the least because i've also just hit that, but i do want to explicitly call out that this will cause a massive test case churn, so i do w

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri created this revision. lebedev.ri added reviewers: aaron.ballman, erichkeane, rjmccall. lebedev.ri added a project: LLVM. Herald added subscribers: carlosgalvezp, jdoerfert. Herald added a reviewer: NoQ. Herald added a reviewer: njames93. Herald added a project: All. lebedev.ri requested

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5402-5411 +if (SanOpts.has(SanitizerKind::ExceptionEscape) && +ExceptionEscapeUBLastInvokeSrcLoc) { + llvm::Constant *CheckSourceLocation = EmitCheckSourceLocation(Loc); + Builder.Cre

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a reviewer: efriedma. lebedev.ri added a comment. @rjmccall thank you for taking a look! In D137381#3955100 , @rjmccall wrote: > In D137381#3953178 , @lebedev.ri > wrote: > >> ping. We need to g

[PATCH] D138836: [UpdateTestChecks] Fix `update_test_checks.py` to add "unused" prefixes

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Anyways, assuming you tested that this works, LG. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138836/new/ https://reviews.l

[PATCH] D138836: [UpdateTestChecks] Fix `update_test_checks.py` to add "unused" prefixes

lebedev.ri added a comment. In D138836#3954850 , @mtrofin wrote: > In D138836#3954782 , @lebedev.ri > wrote: > >> Thanks! >> There's also the one for MCA, but this situation basically never happens for >> those

[PATCH] D138836: [UpdateTestChecks] Fix `update_test_checks.py` to add "unused" prefixes

lebedev.ri added a comment. Thanks! There's also the one for MCA, but this situation basically never happens for those tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138836/new/ https://reviews.llvm.org/D138836 _

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a comment. ping. We need to get this going, reminder, this was caught because it caused a visible miscompilation. @rjmccall are you satisfied with the way we emit srcloc info? @aaron.ballman thoughts on the docs changes? One unanswered question i have, is if we can get the excep

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a comment. ping Comment at: clang/lib/CodeGen/CGCall.cpp:5402-5411 +if (SanOpts.has(SanitizerKind::ExceptionEscape) && +ExceptionEscapeUBLastInvokeSrcLoc) { + llvm::Constant *CheckSourceLocation = EmitCheckSourceLocation(Loc); + Builder.Cr

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8adfa29706e5: [Pipelines] Introduce SROA after (final, run-time) loop unrolling (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHA

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri added a comment. In D136806#3934445 , @asbirlea wrote: > Green light perf-wise. > I cannot comment on whether the position is "the right" one though. I'm > deferring to the other reviewers. Thank you! Repository: rG LLVM Github Monorepo

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri added a comment. In D136806#3932369 , @asbirlea wrote: > As far as performance, this looks fine. Not seeing measurable gains. Thank you for checking! Is the evaluation still ongoing, or is this the green light to go ahead? Repository: rG L

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri updated this revision to Diff 475925. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Herald added a subscriber: pcwang-thead. Adjust full LTO pipeline, for symmetry with non-full LTO pipeline. Looks like there is test coverage shortage. Repository: rG LLVM

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri added a comment. In D136806#3931860 , @spatel wrote: > LGTM based on the timing, results, and alternatives discussed Thank you for the review. > There's some testing in progress according to previous comments, so best to > wait for that to f

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5402-5411 +if (SanOpts.has(SanitizerKind::ExceptionEscape) && +ExceptionEscapeUBLastInvokeSrcLoc) { + llvm::Constant *CheckSourceLocation = Emi

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri updated this revision to Diff 475894. lebedev.ri added a comment. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137381/new/ https://reviews.llvm.org/D137381 Files: clang/docs/ReleaseNotes.rst clang/docs/UndefinedBehavi

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2028 +// FIXME: what about FuncletPads? +if (llvm::BasicBlock *InvokeBB = Builder.GetInsertBlock(); +SanOpts.has(SanitizerKind::Exception

  1   2   3   4   5   6   7   8   9   10   >