lebedev.ri added a comment.

In D139006#3960466 <https://reviews.llvm.org/D139006#3960466>, @mtrofin wrote:

> LGTM, but I'd wait for Johannes to review it, too (because of 
> e67f6477fd1ed29acbeddf8482c25d8db826912f 
> <https://reviews.llvm.org/rGe67f6477fd1ed29acbeddf8482c25d8db826912f>. I for 
> one don't quite follow the reasoning there wrt adding the `else`)

That commit explicitly links to https://reviews.llvm.org/D68819,
after reading that thread, it is obvious that 
rGe67f6477fd1ed29acbeddf8482c25d8db826912f 
<https://reviews.llvm.org/rGe67f6477fd1ed29acbeddf8482c25d8db826912f>
was made prevent the churn we are about to expirience.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139006/new/

https://reviews.llvm.org/D139006

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to