[clang] [clang] [Sema] Check argument range for prefetchi* intrinsics (PR #149745)

2025-07-22 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/149745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [Sema] Check argument range for prefetchi* intrinsics (PR #149745)

2025-07-22 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang approved this pull request. https://github.com/llvm/llvm-project/pull/149745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [Sema] Check argument range for prefetchi* intrinsics (PR #149745)

2025-07-21 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,11 @@ +// RUN: %clang_cc1 %s -ffreestanding -triple=i686-unknown-unknown -target-feature +sm3 -fsyntax-only -verify + +#include + +__m128i test_mm_sm3rnds2_epi32(__m128i __A, __m128i __B, __m128i __C) { + return _mm_sm3rnds2_epi32(__A, __B, __C, 256); // expected-er

[clang] [clang] [Sema] Check argument range for prefetchi* intrinsics (PR #149745)

2025-07-21 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang requested changes to this pull request. Please check test failures. https://github.com/llvm/llvm-project/pull/149745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [clang] [Sema] Check argument range for prefetchi* intrinsics (PR #149745)

2025-07-21 Thread Phoebe Wang via cfe-commits
@@ -14,3 +14,7 @@ void test_m_prefetch_it1(void *p) { // CHECK-LABEL: define{{.*}} void @test_m_prefetch_it1 // CHECK: call void @llvm.prefetch.p0(ptr {{.*}}, i32 0, i32 2, i32 0) } + +void test_invalid_prefetchi(void* p) { + return __builtin_ia32_prefetchi(p, 1); // expec

[clang] [clang] [Sema] Check argument range for prefetchi* intrinsics (PR #149745)

2025-07-21 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/149745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [Sema] Check argument range for prefetchi* intrinsics (PR #149745)

2025-07-21 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/149745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [Sema] Check argument range for prefetchi* intrinsics (PR #149745)

2025-07-20 Thread Phoebe Wang via cfe-commits
phoebewang wrote: Thanks for the patch! You can add a test case for it like `clang/test/CodeGen/X86/sm3-error.c` https://github.com/llvm/llvm-project/pull/149745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [llvm] [X86] Remove WIDEKL feature from Pantherlake and Clearwaterforest (PR #148184)

2025-07-18 Thread Phoebe Wang via cfe-commits
@@ -176,10 +176,10 @@ constexpr FeatureBitset FeaturesArrowlakeS = FeaturesArrowlake | FeatureAVXVNNIINT16 | FeatureSHA512 | FeatureSM3 | FeatureSM4; constexpr FeatureBitset FeaturesPantherlake = -FeaturesArrowlakeS | FeaturePREFETCHI; +FeaturesArrowlakeS ^ Feat

[clang] [NFC][Clang][FMV] Refactor sema checking of target_version/clones attributes. (PR #149067)

2025-07-16 Thread Phoebe Wang via cfe-commits
@@ -1056,4 +1056,62 @@ void SemaX86::handleForceAlignArgPointerAttr(Decl *D, const ParsedAttr &AL) { X86ForceAlignArgPointerAttr(getASTContext(), AL)); } +enum FirstParam { Unsupported, Duplicate, Unknown }; +enum SecondParam { None, CPU, Tune }; +enum ThirdP

[clang] [llvm] [X86][AVX10.2] Decouple AMX-AVX512 from AVX10.2 (PR #148633)

2025-07-14 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > TBH I'm not sure if we need to add `avx512f,evex512` to intrinsics attributes > and/or to `.td` as well. Yes, we need them for now. Otherwise, we cannot allocate ZMM registers. https://github.com/llvm/llvm-project/pull/148633 ___

[clang] [llvm] [X86][AVX10.2] Decouple AMX-AVX512 from AVX10.2 (PR #148633)

2025-07-14 Thread Phoebe Wang via cfe-commits
@@ -16,7 +16,15 @@ #define __DEFAULT_FN_ATTRS_AVX512 \ __attribute__((__always_inline__, __nodebug__, \ - __target__("amx-avx512,avx10.2-512"))) + __target__("amx-avx

[clang] [llvm] [X86] Remove WIDEKL feature from Pantherlake and Clearwaterforest (PR #148184)

2025-07-11 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/148184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Remove WIDEKL feature from Pantherlake and Clearwaterforest (PR #148184)

2025-07-11 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/148184 According to Intel [SDM088](https://cdrdv2.intel.com/v1/dl/getContent/671200) Volume 1, Chapter 2.4, Key Locker will be removed from 2025 onwards products. >From 9a8224c22535912a1fa95caa41f8fc2c3f7a76d0 Mon

[clang] [llvm] [X86] Remove CLDEMOTE from Arrowlake and later hybrid processors (PR #144833)

2025-06-19 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/144833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Remove CLDEMOTE from Arrowlake and later hybrid processors (PR #144833)

2025-06-18 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/144833 >From 8e218d9c4431b021231942e514f175164af35a51 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Thu, 19 Jun 2025 12:14:54 +0800 Subject: [PATCH 1/2] [X86] Remove CLDEMOTE from Arrowlake and later hybrid p

[clang] [llvm] [X86] Remove CLDEMOTE from Arrowlake and later hybrid processors (PR #144833)

2025-06-18 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/144833 Decouple Arrowlake from Sierraforest because the later has CLDEMOTE feature. >From 8e218d9c4431b021231942e514f175164af35a51 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Thu, 19 Jun 2025 12:14:54 +0800

[clang] [llvm] [X86] Remove CLDEMOTE from Alderlake and later hybrid processors (PR #144662)

2025-06-18 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/144662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Remove CLDEMOTE from Alderlake and later hybrid processors (PR #144662)

2025-06-18 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/144662 SDM doesn't list any hybrid processors in this feature. Besides, physical machine also reports not supported. >From 353fbfc93faa2c1bad26261b566d3f797b6d1a72 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Dat

[clang] [Driver][X86] Fix LIT test failure on Solaris OS + AMD64 CPU. (PR #141486)

2025-05-26 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/141486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (#115099)" (PR #138360)

2025-05-03 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang commented: The pre-checkin failures seem related. https://github.com/llvm/llvm-project/pull/138360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (#115099)" (PR #138360)

2025-05-03 Thread Phoebe Wang via cfe-commits
@@ -138,6 +138,12 @@ let Attributes = [Const, NoThrow, RequiredVectorWidth<256>], Features = "avx" in } } +// PRFCHW +let Features = "prfchw", Header = "intrin.h", Attributes = [NoThrow, Const] in { phoebewang wrote: Although they are in the same file, bo

[clang] Reapply "[Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (#115099)" (PR #138360)

2025-05-03 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/138360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [X86][APX] Suppress EGPR/NDD instructions for relocations (PR #136660)

2025-04-29 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/136660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [X86][APX] Suppress EGPR/NDD instructions for relocations (PR #136660)

2025-04-28 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,236 @@ +//===- X86SuppressAPXForReloc.cpp - Suppress APX features for relocations -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [lld] [llvm] [X86][APX] Suppress EGPR/NDD instructions for relocations (PR #136660)

2025-04-28 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,236 @@ +//===- X86SuppressAPXForReloc.cpp - Suppress APX features for relocations -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [lld] [llvm] [X86][APX] Suppress EGPR/NDD instructions for relocations (PR #136660)

2025-04-28 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,236 @@ +//===- X86SuppressAPXForReloc.cpp - Suppress APX features for relocations -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [lld] [llvm] [X86][APX] Suppress EGPR/NDD instructions for relocations (PR #136660)

2025-04-28 Thread Phoebe Wang via cfe-commits
@@ -254,11 +256,20 @@ static bool CompressEVEXImpl(MachineInstr &MI, const X86Subtarget &ST) { } } + bool IsWithReloc = false; + if (X86EnableAPXForRelocation) { +int MemOpNo = X86II::getMemoryOperandNo(MI.getDesc().TSFlags) + + X86II::getOperandB

[clang] [lld] [llvm] [X86][APX] Suppress EGPR/NDD instructions for relocations (PR #136660)

2025-04-28 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > This solution can not handle post-RA optimizations. Could we implement it in > MC stage for this workaround? We cannot change the register after RA. I don't see any problem for now expect NF optimizations, which we can skip them for now. https://github.com/llvm/llvm-projec

[clang] [lld] [llvm] [X86][APX] Suppress EGPR/NDD instructions for relocations (PR #136660)

2025-04-28 Thread Phoebe Wang via cfe-commits
@@ -127,6 +127,7 @@ ; CHECK-NEXT: X86 LEA Optimize ; CHECK-NEXT: X86 Optimize Call Frame ; CHECK-NEXT: X86 Avoid Store Forwarding Block +; CHECK-NEXT: X86 Suppress APX features for relocation phoebewang wrote: Ok, we don't need to move

[clang] [lld] [llvm] [X86][APX] Suppress EGPR/NDD instructions for relocations (PR #136660)

2025-04-28 Thread Phoebe Wang via cfe-commits
@@ -242,8 +244,18 @@ static EFLAGSClobber getClobberType(const MachineInstr &MI) { MI.findRegisterDefOperand(X86::EFLAGS, /*TRI=*/nullptr); if (!FlagDef) return NoClobber; - if (FlagDef->isDead() && X86::getNFVariant(MI.getOpcode())) + + if (FlagDef->isDead() &&

[clang] [llvm] [X86][AVX512FP16] Decouple AVX512VL and AVX512DQ from AVX512FP16 (PR #137450)

2025-04-26 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/137450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [X86] Implement disabling APX relocations and EPGR/NDD instrs for relocations (PR #136660)

2025-04-25 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > > Any comments? > > Still not understand the requirement... I'm confused by the test cases too. I understood the code as we replace the EGPR or NDD instructions with non-APX ones, which meets my expection. But the option and tests are in MC phase, which means instructions

[clang] [lld] [llvm] [X86] Implement disabling APX relocations and EPGR/NDD instrs for relocations (PR #136660)

2025-04-25 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,173 @@ +//===- X86SuppressAPXForReloc.cpp - Suppress APX features for relocations -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [lld] [llvm] [X86] Implement disabling APX relocations and EPGR/NDD instrs for relocations (PR #136660)

2025-04-25 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,173 @@ +//===- X86SuppressAPXForReloc.cpp - Suppress APX features for relocations -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [lld] [llvm] [X86] Implement disabling APX relocations and EPGR/NDD instrs for relocations (PR #136660)

2025-04-25 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,173 @@ +//===- X86SuppressAPXForReloc.cpp - Suppress APX features for relocations -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [lld] [llvm] [X86] Implement disabling APX relocations and EPGR/NDD instrs for relocations (PR #136660)

2025-04-25 Thread Phoebe Wang via cfe-commits
@@ -1,44 +1,84 @@ // REQUIRES: x86 -// RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o +// RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o -x86-apx-relax-relocations=true // RUN: ld.lld %t.o -o %t1 // RUN: llvm-readobj -r %t1 | FileCheck -

[clang] [lld] [llvm] [X86] Implement disabling APX relocations and EPGR/NDD instrs for relocations (PR #136660)

2025-04-25 Thread Phoebe Wang via cfe-commits
@@ -912,9 +912,9 @@ void X86_64::relocate(uint8_t *loc, const Relocation &rel, uint64_t val) const { case R_X86_64_CODE_4_GOTPC32_TLSDESC: case R_X86_64_TLSDESC_CALL: case R_X86_64_TLSGD: -if (rel.expr == R_RELAX_TLS_GD_TO_LE) { +if (rel.expr == R_RELAX_TLS_GD_TO

[clang] [lld] [llvm] [X86] Implement disabling APX relocations and EPGR/NDD instrs for relocations (PR #136660)

2025-04-25 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,173 @@ +//===- X86SuppressAPXForReloc.cpp - Suppress APX features for relocations -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [lld] [llvm] [X86] Implement disabling APX relocations and EPGR/NDD instrs for relocations (PR #136660)

2025-04-25 Thread Phoebe Wang via cfe-commits
@@ -89,6 +89,7 @@ set(sources GISel/X86InstructionSelector.cpp GISel/X86LegalizerInfo.cpp GISel/X86RegisterBankInfo.cpp + X86SuppressAPXForReloc.cpp phoebewang wrote: Put it in alphabetic order? https://github.com/llvm/llvm-project/pull/136660

[clang] [lld] [llvm] [X86] Implement disabling APX relocations and EPGR/NDD instrs for relocations (PR #136660)

2025-04-25 Thread Phoebe Wang via cfe-commits
@@ -912,9 +912,9 @@ void X86_64::relocate(uint8_t *loc, const Relocation &rel, uint64_t val) const { case R_X86_64_CODE_4_GOTPC32_TLSDESC: case R_X86_64_TLSDESC_CALL: case R_X86_64_TLSGD: -if (rel.expr == R_RELAX_TLS_GD_TO_LE) { +if (rel.expr == R_RELAX_TLS_GD_TO

[clang] [lld] [llvm] [X86] Implement disabling APX relocations and EPGR/NDD instrs for relocations (PR #136660)

2025-04-25 Thread Phoebe Wang via cfe-commits
@@ -1,44 +1,84 @@ // REQUIRES: x86 -// RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o +// RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o -x86-apx-relax-relocations=true // RUN: ld.lld %t.o -o %t1 // RUN: llvm-readobj -r %t1 | FileCheck -

[clang] [llvm] [X86][AVX10] Remove VAES and VPCLMULQDQ feature from AVX10.1 (PR #135489)

2025-04-15 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/135489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AVX10] Remove VAES and VPCLMULQDQ feature from AVX10.1 (PR #135489)

2025-04-13 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang milestoned https://github.com/llvm/llvm-project/pull/135489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AVX10] Remove VAES and VPCLMULQDQ feature from AVX10.1 (PR #135489)

2025-04-13 Thread Phoebe Wang via cfe-commits
phoebewang wrote: /cherry-pick https://github.com/llvm/llvm-project/commit/ebba554a3211b0b98d3ae33ba70f9d6ceaab6ad4 https://github.com/llvm/llvm-project/pull/135489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [llvm] [X86][AVX10] Remove VAES and VPCLMULQDQ feature from AVX10.1 (PR #135489)

2025-04-12 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/135489 According to SDM, they require both VAES/VPCLMULQDQ and AVX10.1 CPUID bits. Fixes: #135394 >From f6c06c613a8b862307e643edb8f010cf2f666350 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Sat, 12 Apr 2025

[clang] [X86][AVX10] Make warning message more informative, NFCI (PR #134528)

2025-04-06 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/134528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][AVX10] Make warning message more informative, NFCI (PR #134528)

2025-04-06 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/134528 None >From 04852072c016e6df3c9b6d834ba34c443593aa04 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Sun, 6 Apr 2025 18:22:22 +0800 Subject: [PATCH] [X86][AVX10] Make warning message more informative, NFC

[clang] [X86][AVX10.2] Use 's_' for saturate-convert intrinsics (PR #131592)

2025-04-05 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/131592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VCVT2PS2PHX (PR #132397)

2025-04-05 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/132397 Ref: https://cdrdv2.intel.com/v1/dl/getContent/784343 >From a8353b285f99b57a3d4ce28add512debc8761d5a Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Fri, 21 Mar 2025 20:54:06 +0800 Subject: [PATCH] [X86]

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VCVTTP.*QS (PR #132414)

2025-04-05 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/132414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][AMX] Add missing __inline__ for AMXCOMPLEX intrinsics, NFCI (PR #134484)

2025-04-05 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/134484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][AMX] Add missing __inline__ for AMXCOMPLEX intrinsics, NFCI (PR #134484)

2025-04-05 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/134484 Found by #64779. >From b04e443d3569ec2ed352e127bf6fbfe0902b1ee1 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Sat, 5 Apr 2025 15:03:17 +0800 Subject: [PATCH] [X86][AMX] Add missing __inline__ for AMXCO

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VCVT2PS2PHX (PR #132397)

2025-04-04 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/132397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][AVX10.2] Replace nepbh with bf16 to match with others, NFCI (PR #134240)

2025-04-03 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/134240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][AVX10.2] Replace nepbh with bf16 to match with others, NFCI (PR #134240)

2025-04-03 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > are we missing clang codegen tests for these? No, we don't generate these intrinsics. They will be transformed to llvm.fma ones. https://github.com/llvm/llvm-project/pull/134240 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [X86][AVX10.2] Replace nepbh with bf16 to match with others, NFCI (PR #134240)

2025-04-03 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/134240 None >From cf4be7b5e130593f54752066b1ab569da9cc12fa Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Thu, 3 Apr 2025 20:23:08 +0800 Subject: [PATCH] [X86][AVX10.2] Replace nepbh with bf16 to match with ot

[clang] [X86][AVX10] Re-target mavx10.1 and emit warning for mavx10.x-256/512 and m[no-]evex512 (PR #132542)

2025-03-31 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/132542 >From 9a8d9b7d5d3f07685579c3d1336e146755bb7efa Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Sat, 22 Mar 2025 19:15:01 +0800 Subject: [PATCH 1/3] [X86][AVX10] Re-target mavx10.1 and emit warning for ma

[clang] [X86][AVX10] Re-target mavx10.1 and emit warning for mavx10.x-256/512 and m[no-]evex512 (PR #132542)

2025-03-31 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/132542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][AVX10] Re-target mavx10.1 and emit warning for mavx10.x-256/512 and m[no-]evex512 (PR #132542)

2025-03-31 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > LGTM - but we need to add a full explanation to the clang/llvm release notes > explaining the avx10 changes/deprecations (and future removal). Good reminder! Done. https://github.com/llvm/llvm-project/pull/132542 ___ cfe-commits m

[clang] [X86][AVX10] Re-target mavx10.1 and emit warning for mavx10.x-256/512 and m[no-]evex512 (PR #132542)

2025-03-30 Thread Phoebe Wang via cfe-commits
phoebewang wrote: Ping? https://github.com/llvm/llvm-project/pull/132542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][AVX10] Re-target mavx10.1 and emit warning for mavx10.x-256/512 (PR #132542)

2025-03-26 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/132542 >From 9a8d9b7d5d3f07685579c3d1336e146755bb7efa Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Sat, 22 Mar 2025 19:15:01 +0800 Subject: [PATCH 1/2] [X86][AVX10] Re-target mavx10.1 and emit warning for ma

[clang] [X86][AVX10] Re-target mavx10.1 and emit warning for mavx10.x-256/512 (PR #132542)

2025-03-22 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/132542 The 256-bit maximum vector register size control was removed from AVX10 whitepaper, ref: https://cdrdv2.intel.com/v1/dl/getContent/784343 - Re-target m[no-]avx10.1 to enable AVX10.1 with 512-bit maximum vect

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VCVT[,T]PS2I[,U]BS (PR #132426)

2025-03-21 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > LGTM. Clang format changes look valid. I think the `(__mmask8) - 1` doesn't make sense. Seems clang-format takes `__mmask8` as a variable rather than a type. It appares since some version and really annoying. https://github.com/llvm/llvm-project/pull/132426 ___

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VMINMAXP[H,S,D] (PR #132405)

2025-03-21 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/132405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VCVT[,T]PS2I[,U]BS (PR #132426)

2025-03-21 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/132426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[X86][AVX10.2] Support YMM rounding new instructions (#101825)" (PR #132362)

2025-03-21 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/132362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VCVTTP.*QS (PR #132414)

2025-03-21 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/132414 Ref: https://cdrdv2.intel.com/v1/dl/getContent/784343 >From 096e0b112724176f3d4893657580588a021d2224 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Fri, 21 Mar 2025 23:53:15 +0800 Subject: [PATCH] [X86]

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VMINMAXP[H,S,D] (PR #132405)

2025-03-21 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/132405 >From 4da792e1397d893b4be997039d24cf933d9702b9 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Fri, 21 Mar 2025 22:42:10 +0800 Subject: [PATCH 1/2] [X86][AVX10.2] Remove YMM rounding from VMINMAXP[H,S,D]

[clang] [llvm] [X86][AVX10.2] Remove YMM rounding from VMINMAXP[H,S,D] (PR #132405)

2025-03-21 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/132405 Ref: https://cdrdv2.intel.com/v1/dl/getContent/784343 >From 4da792e1397d893b4be997039d24cf933d9702b9 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Fri, 21 Mar 2025 22:42:10 +0800 Subject: [PATCH] [X86]

[clang] [llvm] Revert "[X86][AVX10.2] Support YMM rounding new instructions (#101825)" (PR #132362)

2025-03-21 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > LGTM - do we have to remove avx10-256 as well (and just use prefer vector > width) or will that remain in some form? Yes, we will remove avx10-256 and evex512 finally. https://github.com/llvm/llvm-project/pull/132362 ___ cfe-commi

[clang] [X86][AVX10.2] Use 's_' for saturate-convert intrinsics (PR #131592)

2025-03-20 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > should be cvts_biasph_hf8 :) Good catch! Proves moving the s ahead is wisdom :) https://github.com/llvm/llvm-project/pull/131592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [X86][AVX10.2] Use 's_' for saturate-convert intrinsics (PR #131592)

2025-03-20 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > > > > Went through the patch with my eyes, I'm not sure how useful it was but > > > > wasn't able to spot anything. > > > > > Here is GCC patch: > > > > > https://gcc.gnu.org/pipermail/gcc-patches/2025-March/678227.html > > > > > > > > > > > > I haven't found any changes r

[clang] [X86][AVX10.2] Use 's_' for saturate-convert intrinsics (PR #131592)

2025-03-19 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > Went through the patch with my eyes, I'm not sure how useful it was but > wasn't able to spot anything. > > > Here is GCC patch: > > https://gcc.gnu.org/pipermail/gcc-patches/2025-March/678227.html > > I haven't found any changes regarding `vcvt2ph2` and no other similar

[clang] [X86][AVX10.2] Use 's_' for saturate-convert intrinsics (PR #131592)

2025-03-19 Thread Phoebe Wang via cfe-commits
phoebewang wrote: Here is GCC patch: https://gcc.gnu.org/pipermail/gcc-patches/2025-March/678227.html https://github.com/llvm/llvm-project/pull/131592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [X86][AVX10.2] Use 's_' for saturate-convert intrinsics (PR #131592)

2025-03-18 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang ready_for_review https://github.com/llvm/llvm-project/pull/131592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Pass fp128 indirectly and return in xmm0 on Windows (PR #115052)

2025-03-06 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/115052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][CodeGen] - Use shift operators instead of built-ins for SSE emulation of MMX intrinsics. (PR #129197)

2025-02-28 Thread Phoebe Wang via cfe-commits
@@ -880,11 +880,11 @@ _mm_sll_si64(__m64 __m, __m64 __count) ///A 32-bit integer value. /// \returns A 64-bit integer vector containing the left-shifted value. If /// \a __count is greater or equal to 64, the result is set to 0. -static __inline__ __m64 __DEFAULT_FN_ATT

[clang] [llvm] [X86][CodeGen] - Use shift operators instead of built-ins for SSE emulation of MMX intrinsics. (PR #129197)

2025-02-28 Thread Phoebe Wang via cfe-commits
@@ -880,11 +880,11 @@ _mm_sll_si64(__m64 __m, __m64 __count) ///A 32-bit integer value. /// \returns A 64-bit integer vector containing the left-shifted value. If /// \a __count is greater or equal to 64, the result is set to 0. -static __inline__ __m64 __DEFAULT_FN_ATT

[clang] [X86][AVX10.2] Add comments for the avx10_2convertintrin.h file (PR #120766)

2025-02-27 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/120766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Allow using the lzcnt intrinsics for non-LZCNT targets (PR #128284)

2025-02-22 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/128284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Allow using the lzcnt intrinsics for non-LZCNT targets (PR #128284)

2025-02-22 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/128284 >From eef9ec3ca38a2ba1dd12c8a8f8bfcacf38ab7926 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Sat, 22 Feb 2025 12:20:09 +0800 Subject: [PATCH 1/2] [X86] Allow using the lzcnt intrinsics for non-LZCNT ta

[clang] [X86] Allow using the lzcnt intrinsics for non-LZCNT targets (PR #128284)

2025-02-22 Thread Phoebe Wang via cfe-commits
@@ -1,5 +1,5 @@ -// RUN: %clang_cc1 -x c -ffreestanding %s -triple=x86_64-apple-darwin -target-feature +lzcnt -emit-llvm -o - | FileCheck %s -// RUN: %clang_cc1 -x c++ -std=c++11 -ffreestanding %s -triple=x86_64-apple-darwin -target-feature +lzcnt -emit-llvm -o - | FileCheck %s

[clang] Remove xbegin and _xend (PR #126952)

2025-02-22 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/126952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Allow using the lzcnt intrinsics for non-LZCNT targets (PR #128284)

2025-02-21 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/128284 Similar to D14748, we can relax lzcnt intrinsics too, especially with improved BSR lowering by #123623 >From eef9ec3ca38a2ba1dd12c8a8f8bfcacf38ab7926 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Sat,

[clang] [X86] Add missing explicit conversion for AMXAVX512 and SHA (PR #127385)

2025-02-16 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/127385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Add missing explicit conversion for AMXAVX512 and SHA (PR #127385)

2025-02-16 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/127385 Address the X86 part of #126491 >From 80e85d3a44657df64fd9136156d36b096003b58e Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Sun, 16 Feb 2025 18:17:39 +0800 Subject: [PATCH] [X86] Add missing explicit

[clang] [clang][x86] Support -masm=intel in cpuid.h (PR #127331)

2025-02-15 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/127331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][x86] Support -masm=intel in cpuid.h (PR #127331)

2025-02-15 Thread Phoebe Wang via cfe-commits
phoebewang wrote: Please update test in clang\test\Headers\cpuid.c https://github.com/llvm/llvm-project/pull/127331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AVX10.2] Fix wrong mask casting in some convert intrinsics (PR #126627)

2025-02-10 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang milestoned https://github.com/llvm/llvm-project/pull/126627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AVX10.2] Fix wrong mask casting in some convert intrinsics (PR #126627)

2025-02-10 Thread Phoebe Wang via cfe-commits
phoebewang wrote: /cherry-pick af522c5dd3a38cc5e11e8e62009d7dbe2cde2d86 https://github.com/llvm/llvm-project/pull/126627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AVX10.2] Fix wrong mask casting in some convert intrinsics (PR #126627)

2025-02-10 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/126627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AVX10.2] Fix wrong intrinsic names after rename (PR #126390)

2025-02-09 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/126390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AVX10.2] Fix wrong intrinsic names after rename (PR #126390)

2025-02-08 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > ⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️ > > You can test this locally with the following command: > View the diff from clang-format here. > ```diff > diff --git a/clang/lib/Headers/avx10_2convertintrin.h > b/clang/lib/Headers/avx10_2convertintrin.

[clang] [AVX10.2] Fix wrong intrinsic names after rename (PR #126390)

2025-02-08 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang approved this pull request. Good catch! https://github.com/llvm/llvm-project/pull/126390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2025-02-05 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/121070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2025-02-04 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > @lvwr @maurer @rcvalle A gentle reminder to please review this PR. @scottconstable You don't need explicit approvals from all reviewers. Let's wait for 24 hours and land it if no objections. https://github.com/llvm/llvm-project/pull/121070 __

[clang] Patch series to reapply #118734 and substantially improve it (PR #120534)

2025-02-04 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > I proposed this at one point, and someone from Intel assured me that these > long repetitive instructions and intrinsics are hand-maintained. It must be > true at some level. I believe it's not me, though I don't like the changes at the beginning either. Anyway, with @chan

[clang] [Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (PR #115099)

2025-02-04 Thread Phoebe Wang via cfe-commits
@@ -138,6 +142,12 @@ let Attributes = [Const, NoThrow, RequiredVectorWidth<256>], Features = "avx" in } } +// PRFCHW +let Features = "prfchw", Header = "x86intrin.h", Attributes = [NoThrow, Const] in { + def _m_prefetch : X86LibBuiltin<"void(void *)">; ph

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2025-02-04 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/121070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   7   8   9   10   >