[clang] f98718c - Remove leftover unused variable from #128711

Author: Mats Jun Larsen Date: 2025-03-03T23:32:03+01:00 New Revision: f98718c9a169d90e676f877c5b6761b22f424b73 URL: https://github.com/llvm/llvm-project/commit/f98718c9a169d90e676f877c5b6761b22f424b73 DIFF: https://github.com/llvm/llvm-project/commit/f98718c9a169d90e676f877c5b6761b22f424b73.dif

[clang] [CodeGen][ObjCGNU] Replace PointerType::getUnqual(Type) with opaque pointer version (NFC) (PR #128715)

@@ -3270,9 +3263,7 @@ CGObjCGNU::GenerateProtocolList(ArrayRef Protocols) { llvm::Value *CGObjCGNU::GenerateProtocolRef(CodeGenFunction &CGF, const ObjCProtocolDecl *PD) { auto protocol = GenerateProtocolRef(PD); - llvm::Type *T =

[clang] [CodeGen] Replace PointerType::getUnqual(Type) with opaque pointer version (NFC) (PR #128711)

https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/128711 >From 22a07820dee329ed68ea2a2cd3b619f980047de9 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Tue, 25 Feb 2025 14:09:39 +0100 Subject: [PATCH] [CodeGen] Replace PointerType::getUnqual(Type) with opaque

[clang] [CodeGen][ObjCGNU] Replace PointerType::getUnqual(Type) with opaque pointer version (NFC) (PR #128715)

@@ -2284,10 +2284,12 @@ CGObjCGNU::CGObjCGNU(CodeGenModule &cgm, unsigned runtimeABIVersion, BoolTy = CGM.getTypes().ConvertType(CGM.getContext().BoolTy); Int8Ty = llvm::Type::getInt8Ty(VMContext); + + PtrTy = llvm::PointerType::getUnqual(cgm.getLLVMContext()); -

[clang] [CodeGen][ObjCGNU] Replace PointerType::getUnqual(Type) with opaque pointer version (NFC) (PR #128715)

https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/128715 >From e993b0d23cbb018a090f49f1f4f63c0dd0a89a66 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Tue, 25 Feb 2025 14:40:11 +0100 Subject: [PATCH] [CodeGen][ObjCGNU] Replace PointerType::getUnqual(Type) with

[clang] [CodeGen][ObjCGNU] Replace PointerType::getUnqual(Type) with opaque pointer version (NFC) (PR #128715)

https://github.com/junlarsen edited https://github.com/llvm/llvm-project/pull/128715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Replace PointerType::getUnqual(Type) with opaque pointer version (NFC) (PR #128711)

junlarsen wrote: * **#128711** https://app.graphite.dev/github/pr/llvm/llvm-project/128711?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/12

[clang] [CodeGen] Replace PointerType::getUnqual(Type) with opaque pointer version (NFC) (PR #128711)

https://github.com/junlarsen created https://github.com/llvm/llvm-project/pull/128711 pointer version (NFC) Follow-up to #123569 >From 22a07820dee329ed68ea2a2cd3b619f980047de9 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Tue, 25 Feb 2025 14:09:39 +0100 Subject: [PATCH] [CodeGen] Repla

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

https://github.com/junlarsen closed https://github.com/llvm/llvm-project/pull/124771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen][Hexagon] Replace PointerType::getUnqual(Type) with opaque version (NFC) (PR #126274)

https://github.com/junlarsen closed https://github.com/llvm/llvm-project/pull/126274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen][Hexagon] Replace PointerType::getUnqual(Type) with opaque version (NFC) (PR #126274)

https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/126274 >From d0613ac62099faefab887605422cba95116ce12a Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Sat, 8 Feb 2025 02:35:31 +0900 Subject: [PATCH 1/3] [CodeGen][Hexagon] Replace of PointerType::get(Type) with

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124771 >From 13d65a0cc95fe53f959db343e5be07773ee53f28 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 00:31:32 +0900 Subject: [PATCH 1/5] [CodeGen] Replace of PointerType::get(Type) with opaque

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124771 >From 13d65a0cc95fe53f959db343e5be07773ee53f28 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 00:31:32 +0900 Subject: [PATCH 1/5] [CodeGen] Replace of PointerType::get(Type) with opaque

[clang] [CodeGen][Hexagon] Replace PointerType::getUnqual(Type) with opaque version (NFC) (PR #126274)

@@ -8,6 +8,7 @@ #include "ABIInfoImpl.h" #include "TargetInfo.h" +#include "llvm/IR/DerivedTypes.h" junlarsen wrote: Likely not, I think my LSP automatically inserts them when it completes stuff like PointerType::get. I'll remove it and the ones in the other

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124771 >From 13d65a0cc95fe53f959db343e5be07773ee53f28 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 00:31:32 +0900 Subject: [PATCH 1/4] [CodeGen] Replace of PointerType::get(Type) with opaque

[clang] [CodeGen][AArch64] Replace PointerType::getUnqual(Type) with opaque version (NFC) (PR #126278)

https://github.com/junlarsen closed https://github.com/llvm/llvm-project/pull/126278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen][SystemZ] Replace PointerType::getUnqual(Type) with opaque version (NFC) (PR #126280)

https://github.com/junlarsen closed https://github.com/llvm/llvm-project/pull/126280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen][XCore] Replace PointerType::getUnqual(Type) with opaque version (NFC) (PR #126279)

https://github.com/junlarsen closed https://github.com/llvm/llvm-project/pull/126279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen][Hexagon] Replace PointerType::getUnqual(Type) with opaque version (NFC) (PR #126274)

https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/126274 >From d0613ac62099faefab887605422cba95116ce12a Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Sat, 8 Feb 2025 02:35:31 +0900 Subject: [PATCH 1/2] [CodeGen][Hexagon] Replace of PointerType::get(Type) with

[clang] [CodeGen][Hexagon] Replace PointerType::getUnqual(Type) with opaque version (NFC) (PR #126274)

@@ -388,22 +385,16 @@ Address HexagonABIInfo::EmitVAArgForHexagonLinux(CodeGenFunction &CGF, CGF.Builder.CreateStore(__new_overflow_area_pointer, __current_saved_reg_area_pointer_p); - // Bitcast the overflow area pointer to the type of argument.

[clang] [CodeGen][SystemZ] Replace PointerType::getUnqual(Type) with opaque version (NFC) (PR #126280)

https://github.com/junlarsen created https://github.com/llvm/llvm-project/pull/126280 Follow-up to #126278 >From 31586f0db70c1d7da7decb0fef3473930fe17c7b Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Sat, 8 Feb 2025 02:59:34 +0900 Subject: [PATCH] [CodeGen][SystemZ] Replace PointerType:

[clang] [CodeGen][XCore] Replace PointerType::getUnqual(Type) with opaque version (NFC) (PR #126279)

https://github.com/junlarsen created https://github.com/llvm/llvm-project/pull/126279 Follow-up to #123569 >From 507705cff12ac89e1f23c0b7233cfd5a13e882d6 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Sat, 8 Feb 2025 02:57:46 +0900 Subject: [PATCH] [CodeGen][XCore] Replace PointerType::g

[clang] [CodeGen][AArch64] Replace PointerType::getUnqual(Type) with opaque version (NFC) (PR #126278)

https://github.com/junlarsen created https://github.com/llvm/llvm-project/pull/126278 Follow-up to #123569 >From aa2545fd0122ffb194a92dc42ef94055248aeb20 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Sat, 8 Feb 2025 02:44:25 +0900 Subject: [PATCH] [CodeGen][AArch64] Replace PointerType:

[clang] [CodeGen][Hexagon] Replace PointerType::getUnqual(Type) with opaque version (NFC) (PR #126274)

https://github.com/junlarsen edited https://github.com/llvm/llvm-project/pull/126274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen][Hexagon] Replace of PointerType::getUnqual(Type) with opaque version (NFC) (PR #126274)

https://github.com/junlarsen edited https://github.com/llvm/llvm-project/pull/126274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

https://github.com/junlarsen closed https://github.com/llvm/llvm-project/pull/124782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

junlarsen wrote: Test failures seem unrelated. https://github.com/llvm/llvm-project/pull/124782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen][Hexagon] Replace of PointerType::get(Type) with opaque version (NFC) (PR #126274)

https://github.com/junlarsen created https://github.com/llvm/llvm-project/pull/126274 Follow-up to https://github.com/llvm/llvm-project/issues/123569 The obsolete bitcasts on the LoadInsts are also removed. >From d0613ac62099faefab887605422cba95116ce12a Mon Sep 17 00:00:00 2001 From: Mats Jun

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

https://github.com/junlarsen edited https://github.com/llvm/llvm-project/pull/124771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

@@ -3054,7 +3054,7 @@ LValue CodeGenFunction::EmitDeclRefLValue(const DeclRefExpr *E) { getContext().getDeclAlign(VD)); llvm::Type *VarTy = getTypes().ConvertTypeForMem(VD->getType()); auto *PTy = llvm::PointerType::ge

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

https://github.com/junlarsen ready_for_review https://github.com/llvm/llvm-project/pull/124771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124771 >From 13d65a0cc95fe53f959db343e5be07773ee53f28 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 00:31:32 +0900 Subject: [PATCH 1/3] [CodeGen] Replace of PointerType::get(Type) with opaque

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

https://github.com/junlarsen edited https://github.com/llvm/llvm-project/pull/124771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124782 >From bc77542fe58bdc94566a9a589039856de50617b0 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 01:29:01 +0900 Subject: [PATCH 1/4] [Clang][TableGen] Use PointerType::get(Context) in MVE

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124771 >From 13d65a0cc95fe53f959db343e5be07773ee53f28 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 00:31:32 +0900 Subject: [PATCH 1/2] [CodeGen] Replace of PointerType::get(Type) with opaque

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124782 >From bc77542fe58bdc94566a9a589039856de50617b0 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 01:29:01 +0900 Subject: [PATCH 1/3] [Clang][TableGen] Use PointerType::get(Context) in MVE

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

@@ -210,7 +210,7 @@ class PointerType : public Type { return Name + " *"; } std::string llvmName() const override { -return "llvm::PointerType::getUnqual(" + Pointee->llvmName() + ")"; +return "llvm::PointerType::getUnqual(Builder.getPtrTy())";

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124782 >From bc77542fe58bdc94566a9a589039856de50617b0 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 01:29:01 +0900 Subject: [PATCH 1/2] [Clang][TableGen] Use PointerType::get(Context) in MVE

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124771 >From f3bbd6f0db4109016d98fe15a2b086b491df2d93 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 00:31:32 +0900 Subject: [PATCH 1/2] [CodeGen] Replace of PointerType::get(Type) with opaque

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

junlarsen wrote: I think I'll do that instead. Sounds a lot more reasonable in my opinion https://github.com/llvm/llvm-project/pull/124782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124771 >From f3bbd6f0db4109016d98fe15a2b086b491df2d93 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 00:31:32 +0900 Subject: [PATCH 1/2] [CodeGen] Replace of PointerType::get(Type) with opaque

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124782 >From bc77542fe58bdc94566a9a589039856de50617b0 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 01:29:01 +0900 Subject: [PATCH] [Clang][TableGen] Use PointerType::get(Context) in MVE Tabl

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

https://github.com/junlarsen commented: Each file should have license headers, ref https://llvm.org/docs/CodingStandards.html#file-headers https://github.com/llvm/llvm-project/pull/125045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

https://github.com/junlarsen updated https://github.com/llvm/llvm-project/pull/124782 >From bc77542fe58bdc94566a9a589039856de50617b0 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 01:29:01 +0900 Subject: [PATCH] [Clang][TableGen] Use PointerType::get(Context) in MVE Tabl

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (PR #124782)

https://github.com/junlarsen created https://github.com/llvm/llvm-project/pull/124782 Follow-up to #123569 I don't know if directly using the CodeGenModule here is the best solution. Let me know if there's something better to use. >From bc77542fe58bdc94566a9a589039856de50617b0 Mon Sep 17 00:0

[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

https://github.com/junlarsen edited https://github.com/llvm/llvm-project/pull/124782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

https://github.com/junlarsen converted_to_draft https://github.com/llvm/llvm-project/pull/124771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

https://github.com/junlarsen ready_for_review https://github.com/llvm/llvm-project/pull/124771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

@@ -1097,31 +1097,10 @@ llvm::Type *CodeGenModule::getBlockDescriptorType() { if (BlockDescriptorType) return BlockDescriptorType; - llvm::Type *UnsignedLongTy = -getTypes().ConvertType(getContext().UnsignedLongTy); - - // struct __block_descriptor { - // unsign

[clang] [CodeGen] Replace of PointerType::get(Type) with opaque version (NFC) (PR #124771)

https://github.com/junlarsen created https://github.com/llvm/llvm-project/pull/124771 Follow-up to https://github.com/llvm/llvm-project/issues/123569 >From f3bbd6f0db4109016d98fe15a2b086b491df2d93 Mon Sep 17 00:00:00 2001 From: Mats Jun Larsen Date: Wed, 29 Jan 2025 00:31:32 +0900 Subject: [PA

[clang] [llvm] [clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this` (PR #122928)

junlarsen wrote: I wasn't aware of that exception either, so my apologies there. I still think it's fair policy to keep things as compatible if easily possible though. https://github.com/llvm/llvm-project/pull/122928 ___ cfe-commits mailing list cfe-c

[clang] [llvm] [clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this` (PR #122928)

junlarsen wrote: Thanks, I'm not very opinionated on it, but since a lot of libraries in various languages rely on the C API I think it's fair to keep comparible if it makes sense https://github.com/llvm/llvm-project/pull/122928 ___ cfe-commits maili

[clang] [llvm] [clang][DebugInfo] Emit DW_AT_object_pointer on function declarations with explicit `this` (PR #122928)

junlarsen wrote: This causes a breaking change in the C-API which I believe can easily be avoided. I've submitted https://github.com/llvm/llvm-project/pull/124144 as a suggestion to keep compatability https://github.com/llvm/llvm-project/pull/122928