[clang] [Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC) (PR #124782)

[Mats Jun Larsen via cfe-commits]

https://github.com/junlarsen updated 
https://github.com/llvm/llvm-project/pull/124782

>From bc77542fe58bdc94566a9a589039856de50617b0 Mon Sep 17 00:00:00 2001
From: Mats Jun Larsen <mats@jun.codes>
Date: Wed, 29 Jan 2025 01:29:01 +0900
Subject: [PATCH 1/4] [Clang][TableGen] Use PointerType::get(Context) in MVE
 TableGen emitter

Follow-up to #123569
---
 clang/utils/TableGen/MveEmitter.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/utils/TableGen/MveEmitter.cpp 
b/clang/utils/TableGen/MveEmitter.cpp
index 58a4d3c22ac3660..334aedbb8592b5c 100644
--- a/clang/utils/TableGen/MveEmitter.cpp
+++ b/clang/utils/TableGen/MveEmitter.cpp
@@ -210,7 +210,7 @@ class PointerType : public Type {
     return Name + " *";
   }
   std::string llvmName() const override {
-    return "llvm::PointerType::getUnqual(" + Pointee->llvmName() + ")";
+    return "llvm::PointerType::getUnqual(CGM.getLLVMContext())";
   }
   const Type *getPointeeType() const { return Pointee; }
 

>From 2bca97745a46f77ed89379d2e02796940e2bf570 Mon Sep 17 00:00:00 2001
From: Mats Jun Larsen <mats@jun.codes>
Date: Sat, 8 Feb 2025 01:37:11 +0900
Subject: [PATCH 2/4] [Clang][TableGen] Switch to Builder.getPtrTy()

---
 clang/utils/TableGen/MveEmitter.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/utils/TableGen/MveEmitter.cpp 
b/clang/utils/TableGen/MveEmitter.cpp
index 334aedbb8592b5c..10ec6e49eb28f98 100644
--- a/clang/utils/TableGen/MveEmitter.cpp
+++ b/clang/utils/TableGen/MveEmitter.cpp
@@ -210,7 +210,7 @@ class PointerType : public Type {
     return Name + " *";
   }
   std::string llvmName() const override {
-    return "llvm::PointerType::getUnqual(CGM.getLLVMContext())";
+    return "llvm::PointerType::getUnqual(Builder.getPtrTy())";
   }
   const Type *getPointeeType() const { return Pointee; }
 

>From 09bb424d081fb1f5ef13e4a5f55371f0eb3afaea Mon Sep 17 00:00:00 2001
From: Mats Jun Larsen <mats@jun.codes>
Date: Fri, 7 Feb 2025 16:42:06 +0000
Subject: [PATCH 3/4] Update clang/utils/TableGen/MveEmitter.cpp

Co-authored-by: Nikita Popov <git...@npopov.com>
---
 clang/utils/TableGen/MveEmitter.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/utils/TableGen/MveEmitter.cpp 
b/clang/utils/TableGen/MveEmitter.cpp
index 10ec6e49eb28f98..dc1377952a2b62b 100644
--- a/clang/utils/TableGen/MveEmitter.cpp
+++ b/clang/utils/TableGen/MveEmitter.cpp
@@ -210,7 +210,7 @@ class PointerType : public Type {
     return Name + " *";
   }
   std::string llvmName() const override {
-    return "llvm::PointerType::getUnqual(Builder.getPtrTy())";
+    return "Builder.getPtrTy()";
   }
   const Type *getPointeeType() const { return Pointee; }
 

>From c320336eef890cab115ccd3054d970bb99531862 Mon Sep 17 00:00:00 2001
From: Mats Jun Larsen <mats@jun.codes>
Date: Sat, 8 Feb 2025 01:46:57 +0900
Subject: [PATCH 4/4] Run clang format

---
 clang/utils/TableGen/MveEmitter.cpp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/clang/utils/TableGen/MveEmitter.cpp 
b/clang/utils/TableGen/MveEmitter.cpp
index dc1377952a2b62b..39b6e837ed4b71e 100644
--- a/clang/utils/TableGen/MveEmitter.cpp
+++ b/clang/utils/TableGen/MveEmitter.cpp
@@ -209,9 +209,7 @@ class PointerType : public Type {
       Name = "const " + Name;
     return Name + " *";
   }
-  std::string llvmName() const override {
-    return "Builder.getPtrTy()";
-  }
+  std::string llvmName() const override { return "Builder.getPtrTy()"; }
   const Type *getPointeeType() const { return Pointee; }
 
   static bool classof(const Type *T) {

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits