frutiger abandoned this revision.
frutiger added a comment.
Fixed by r317986.
https://reviews.llvm.org/D39161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frutiger added a comment.
Thanks for the note, I'll wait.
https://reviews.llvm.org/D39161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frutiger added a comment.
@jklaehn do you know why the referenced cursor would point to line 2?
https://reviews.llvm.org/D39217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frutiger added a comment.
Friendly poke @rsmith @compnerd
https://reviews.llvm.org/D39161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frutiger closed this revision.
frutiger added a comment.
Ah missed your last note. Committed as `r317706`.
Repository:
rL LLVM
https://reviews.llvm.org/D39804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
frutiger added a comment.
I will commit this shortly.
@mgorny I have a fix for the `unique_external` issue here:
https://reviews.llvm.org/D39161
Repository:
rL LLVM
https://reviews.llvm.org/D39804
___
cfe-commits mailing list
cfe-commits@lists.
frutiger added a comment.
Thanks for posting this on Phabricator, I had sent it to the mailing list last
month.
Repository:
rL LLVM
https://reviews.llvm.org/D39804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
frutiger added a comment.
It looks like the `my_var:2:1` refers to the result from
`clang_getCursorReferenced`:
https://github.com/llvm-mirror/clang/blob/d454549fce04dfedda6cc2825b66efca94effe3f/tools/c-index-test/c-index-test.c#L709-L711.
I'm not sure what a referenced cursor is in this conte
frutiger added inline comments.
Comment at: test/Index/c-index-getCursor-test.m:167
// CHECK: [57:1 - 57:10] FunctionDecl=f:57:6 (Definition)
-// CHECK: [58:4 - 58:8] VarDecl=my_var:58:8 (Definition)
+// CHECK: [58:4 - 58:8] VarDecl=my_var:2:1 (Definition)
// CHECK: [58:8 - 58:
frutiger added a comment.
I would very much appreciate some guidance on whether or not this kind of a
change in behaviour for `clang_getSpellingLocation` is an acceptable thing to
do.
https://reviews.llvm.org/D39217
___
cfe-commits mailing list
cf
frutiger updated this revision to Diff 119971.
frutiger added a comment.
Add context to the patch.
https://reviews.llvm.org/D39217
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_location.py
test/Index/annotate-tokens.c
test/Index/blocks.c
test/Index/c-index-a
frutiger created this revision.
- Add a 'Location' class that represents the four properties of a physical
location
- Enhance 'SourceLocation' to provide 'expansion' and 'spelling' locations,
maintaining backwards compatibility with existing code by forwarding the four
properties to 'expansion'
frutiger abandoned this revision.
frutiger added a comment.
@AlisdairM maybe you want to commandeer this revision? I don't think this is
going anywhere...
https://reviews.llvm.org/D16970
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
frutiger abandoned this revision.
frutiger added a subscriber: AlisdairM.
frutiger added a comment.
@AlisdairM maybe you want to commandeer this? This revision is probably not
going anywhere any time soon...
https://reviews.llvm.org/D16967
___
cfe
frutiger added a comment.
I was unable to produce a simple test case that would still result in a cursor
with 'unique external' linkage. @rsmith I would appreciate if you can think of
a symbol that may still have this kind of linkage. Thanks!
https://reviews.llvm.org/D39161
__
frutiger created this revision.
In SVN r314037, linkage determination of a symbol was significantly
refactored. This resulted in extern anonymous namespace declarations to
no longer be considered 'unique_external'. This ultimately broke a test
in the Python bindings.
This commit removes the 'un
frutiger closed this revision.
frutiger added a comment.
@compnerd I do now. Landed in https://reviews.llvm.org/rL316278.
https://reviews.llvm.org/D37905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
frutiger closed this revision.
frutiger added a comment.
Landed in https://reviews.llvm.org/rL316264.
https://reviews.llvm.org/D37855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frutiger updated this revision to Diff 119191.
frutiger added a comment.
Added 'Location' to '__all__'.
https://reviews.llvm.org/D37905
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_location.py
tools/libclang/CXSourceLocation.cpp
Index: tools/libclang/CXSourceL
frutiger updated this revision to Diff 117041.
frutiger added a comment.
Updated as per review.
https://reviews.llvm.org/D37905
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_location.py
tools/libclang/CXSourceLocation.cpp
Index: tools/libclang/CXSourceLocation.
frutiger added inline comments.
Comment at: bindings/python/clang/cindex.py:320
+return self._get_spelling()['offset']
def __eq__(self, other):
compnerd wrote:
> Does it make sense to introduce two new properties `expansion` and `spelling`
> and h
frutiger added a comment.
//Friendly poke!//
https://reviews.llvm.org/D37905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frutiger added a comment.
//Friendly poke!//
https://reviews.llvm.org/D37855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frutiger added a comment.
**Please note**:
- this change means that versions of `libclang` built prior to the introduction
of `clang_getExpansionLocation` will not work.
- this change alters the behavior of `clang_getSpellingLocation` to return the
spelling location
I would appreciate advice o
frutiger created this revision.
o) Enhance 'CursorLocation' with four additional properties that can
retrieve spelling location information.
o) Update the implementation to use 'clang_getExpansionLocation'
instead of the deprecated 'clang_getInstantiationLocation', which
has been present
frutiger created this revision.
Some API calls accept 'NULL' instead of a char array (e.g. the second
argument to 'clang_ParseTranslationUnit'). For Python 3 compatibility,
all strings are passed through 'c_interop_string' which expects to
receive only 'bytes' or 'str' objects. This change exten
frutiger added a comment.
@compnerd if nothing else remains here, I would also appreciate it if you could
merge this. Thanks!
https://reviews.llvm.org/D37573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
frutiger updated this revision to Diff 115246.
frutiger added a comment.
Rebased on top of the latest master.
https://reviews.llvm.org/D37573
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_linkage.py
Index: bindings/python/tests/cindex/test_linkage.py
===
frutiger added a comment.
I do not have commit rights - please commit this yourself, thanks!
https://reviews.llvm.org/D37577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frutiger updated this revision to Diff 114818.
frutiger added a comment.
Expand the acronym 'TLS' to 'thread-local storage' in documentation.
https://reviews.llvm.org/D37577
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_tls_kind.py
include/clang-c/Index.h
tool
frutiger updated this revision to Diff 114701.
frutiger added a comment.
Use more specific target platform.
https://reviews.llvm.org/D37577
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_tls_kind.py
include/clang-c/Index.h
tools/libclang/CIndex.cpp
tools/libc
frutiger updated this revision to Diff 114640.
frutiger added a comment.
Add test cases for `__declspec(thread)` and static TLS. Clean up formatting to
adhere to the project style.
https://reviews.llvm.org/D37577
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_tls
frutiger added inline comments.
Comment at: bindings/python/tests/cindex/test_tls_kind.py:14
+int tls_none;
+thread_local tls_dynamic;
+""", lang = 'cpp')
frutiger wrote:
> compnerd wrote:
> > Can we add a test case for static TLS as well please? Also, I think t
frutiger added inline comments.
Comment at: bindings/python/tests/cindex/test_tls_kind.py:14
+int tls_none;
+thread_local tls_dynamic;
+""", lang = 'cpp')
compnerd wrote:
> Can we add a test case for static TLS as well please? Also, I think that we
> should add
frutiger updated this revision to Diff 114256.
frutiger added a comment.
Exports 'TLSKind' in the '__all__' array.
https://reviews.llvm.org/D37577
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_tls_kind.py
include/clang-c/Index.h
tools/libclang/CIndex.cpp
too
frutiger updated this revision to Diff 114257.
frutiger added a comment.
Export 'LinkageKind' in '__all__'. Use consistent quotes in test drivers.
https://reviews.llvm.org/D37573
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_linkage.py
Index: bindings/python/te
frutiger created this revision.
Introduce the 'TLS Kind' property of variable declarations through
libclang. Additionally, provide a Python accessor for it, and test that
functionality.
https://reviews.llvm.org/D37577
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test
37 matches
Mail list logo
