[clang] [verify] Improve the error messages with multiple active prefixes (PR #126068)

https://github.com/Maetveis closed https://github.com/llvm/llvm-project/pull/126068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [verify] Improve the error messages with multiple active prefixes (PR #126068)

Maetveis wrote: Ping @MaskRay @AaronBallman I thought you might be interested in reviewing since you reviewed https://reviews.llvm.org/D154688. https://github.com/llvm/llvm-project/pull/126068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

https://github.com/Maetveis edited https://github.com/llvm/llvm-project/pull/120900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

https://github.com/Maetveis requested changes to this pull request. Thanks, this is starting to look right. I'm sorry for the long response time, I could not justify spending work time on the review this time, and my weekends have been somewhat busy. I'll try to get some other reviewers to loo

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,472 @@ +#!/usr/bin/env python3 + +"""generate_unsupported_in_drivermode.py + +This script generates Lit regression test files that validate that options are only exposed to intended driver modes. + +The options and driver modes are parsed from Options.td, whose path sh

[clang] [verify] Improve the error messages with multiple active prefixes (PR #126068)

https://github.com/Maetveis updated https://github.com/llvm/llvm-project/pull/126068 From 105e5467662248ea2eb41edcfe0ce9a0cc97d044 Mon Sep 17 00:00:00 2001 From: Gergely Meszaros Date: Thu, 6 Feb 2025 02:55:43 -0800 Subject: [PATCH 1/2] [verify] Improve the error messages with multiple active

[clang] [verify] Improve the error messages with multiple active prefixes (PR #126068)

https://github.com/Maetveis edited https://github.com/llvm/llvm-project/pull/126068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

https://github.com/Maetveis requested changes to this pull request. Phew, first round in. Please don't take the number of suggestions as a negative, the basic structure looks good there's just many small tweaks to be made :). https://github.com/llvm/llvm-project/pull/120900 ___

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

https://github.com/Maetveis edited https://github.com/llvm/llvm-project/pull/120900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

Maetveis wrote: > Hi @Maetveis . This is ready for review. > > There are a few things that I came across while making the script that I > should highlight : > > 1. clang -cc1 test directory > > > [test/Driver/lit.local.cfg](https://github.com/llvm/llvm-project/blob/e10d551aa482ee185a8021

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

Maetveis wrote: Sorry I was caught up with work, and didn't find the time to look at this until now. > @Maetveis Do you have any thoughts on the following two groups of options > that are unexpectedly succeeding? I'll note that I did come across some > options for which the driver appears to

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

Maetveis wrote: > @Maetveis > > All of the Visibility fields appear to be not null, but that's a good check > to add anyway. Thanks. After adding it though, the same failures occur. > Here's an example. Maybe there's a gap in my understanding: > > The script generates tests for both flang & c

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

Maetveis wrote: Hi,Thanks for working on this issue. I wanted to preface this by feel free to ignore this during the holidays, zero pressure. I like to interact with the community in my free time, but that obviously does not need to extend to everyone :). What kind of failures are you seeing

[clang] [Clang-CL][DXC] Expose -fdiagnostic-color= to clang-cl and clang-dxc (PR #120644)

https://github.com/Maetveis closed https://github.com/llvm/llvm-project/pull/120644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang-CL][DXC] Expose -fdiagnostic-color= to clang-cl and clang-dxc (PR #120644)

https://github.com/Maetveis approved this pull request. Great work, Thank you very much! https://github.com/llvm/llvm-project/pull/120644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [Clang-CL][DXC] Expose -fdiagnostic-color= to clang-cl and clang-dxc (PR #120644)

@@ -664,6 +664,15 @@ // RUN: not %clang_cl /guard:foo -### -- %s 2>&1 | FileCheck -check-prefix=CFGUARDINVALID %s // CFGUARDINVALID: invalid value 'foo' in '/guard:' +// The test doesn't run in a PTY, so "auto" defaults to off. +// RUN: %clang_cl -fdiagnostics-color=auto -###

[clang] [Clang-CL][DXC] Expose -fdiagnostic-color= to clang-cl and clang-dxc (PR #120644)

@@ -0,0 +1,8 @@ +// The test doesn't run in a PTY, so "auto" defaults to off. Maetveis wrote: Similarly here I think its enough to check that the option is accepted, no real need to verify what it does. ```c // RUN: %clang_dxc \ // RUN: -fcolor-diagnostics \ //

[clang] [Clang-CL][DXC] Expose -fdiagnostic-color= to clang-cl and clang-dxc (PR #120644)

https://github.com/Maetveis edited https://github.com/llvm/llvm-project/pull/120644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang-CL][DXC] Expose -fdiagnostic-color= to clang-cl and clang-dxc (PR #120644)

https://github.com/Maetveis requested changes to this pull request. Thank you, mostly looks good, I think the tests can be made simpler. And I think adding release notes would benefit users. You can add a new point to "New Compiler Flags" in the clang release notes that clang-cl and clang-dxc n

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

https://github.com/Maetveis closed https://github.com/llvm/llvm-project/pull/118640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

Maetveis wrote: ping @MaskRay https://github.com/llvm/llvm-project/pull/118640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

https://github.com/Maetveis updated https://github.com/llvm/llvm-project/pull/118640 From c2efb475c557dd4ad1018e261a9659b1c4f16b83 Mon Sep 17 00:00:00 2001 From: Gergely Meszaros Date: Wed, 4 Dec 2024 05:44:19 -0800 Subject: [PATCH 1/4] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc b

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

Maetveis wrote: @HaohaiWen can you review and approve if it looks good now for clang-cl? I'll try pinging discord and waiting a little bit for HLSL people before merging. Gentle ping @bob80905. https://github.com/llvm/llvm-project/pull/118640 ___ cf

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

Maetveis wrote: > Can we keep this flag for CL in this PR and open an issue to discuss whether > it should be disabled for CL? Sure, see latest commit and https://github.com/llvm/llvm-project/issues/119179. https://github.com/llvm/llvm-project/pull/118640 __

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

https://github.com/Maetveis updated https://github.com/llvm/llvm-project/pull/118640 From c2efb475c557dd4ad1018e261a9659b1c4f16b83 Mon Sep 17 00:00:00 2001 From: Gergely Meszaros Date: Wed, 4 Dec 2024 05:44:19 -0800 Subject: [PATCH 1/3] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc b

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

https://github.com/Maetveis ready_for_review https://github.com/llvm/llvm-project/pull/118640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

https://github.com/Maetveis updated https://github.com/llvm/llvm-project/pull/118640 From c2efb475c557dd4ad1018e261a9659b1c4f16b83 Mon Sep 17 00:00:00 2001 From: Gergely Meszaros Date: Wed, 4 Dec 2024 05:44:19 -0800 Subject: [PATCH 1/2] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc b

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

Maetveis wrote: > I checked and I don't think there are any others that have been accidentally > enabled. Thanks. > Are there any tests that check to these options produce warnings? If not, it > might be worth adding them. What do you think? No there aren't any, and yes I agree, I will add t

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

Maetveis wrote: > Better to double check with author who specified those CLOption. Do you mean the person that added `CLOption` to these flags? That was @tarunprabhu, but IIUC that was by mistake; his intention was to extend these flags only to Flang. Otherwise `-Xlinker` has been around for

[clang] [Clang] Fix -Wunused-private-field false negative with defaulted comparison operators (PR #116871)

https://github.com/Maetveis closed https://github.com/llvm/llvm-project/pull/116871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix -Wunused-private-field false negative with defaulted comparison operators (PR #116871)

Maetveis wrote: @whiteio You seem to have the [Keep my email addresses private](https://github.com/settings/emails) setting enabled in your account. This will make the merged commit reference `84482442+whit...@users.noreply.github.com` if you'd like to use your actual address please disable t

[clang] [Clang] Fix -Wunused-private-field false negative with defaulted comparison operators (PR #116871)

Maetveis wrote: > Hey @Maetveis, I've addressed the conflicts 👍 Thanks, ping @AaronBallman or @erichkeane I would appreciate a second look from someone closer to frontend. https://github.com/llvm/llvm-project/pull/116871 ___ cfe-commits mailing lis

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

Maetveis wrote: @HaohaiWen can you check if this makes sense for clang-cl? @bob80905 same for DXC please. https://github.com/llvm/llvm-project/pull/118640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [flang] [flang][Driver] Support -nostdlib and -nodefaultlibs (PR #108868)

@@ -5572,7 +5572,8 @@ def : Flag<["-"], "nocudalib">, Alias; def gpulibc : Flag<["-"], "gpulibc">, Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>, HelpText<"Link the LLVM C Library for GPUs">; def nogpulibc : Flag<["-"], "nogpulibc">, Visibility<[ClangOption, C

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

Maetveis wrote: @tarunprabhu Continuing [our discussion on #108868](https://github.com/llvm/llvm-project/pull/108868/files/612b93eda5695306293bb8ca6e27a810b06adf3d#r1867949328) here. These are what I found, by searching for commits that added both `FlangOption` and `CLOption` to Options.td and

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

@@ -1989,7 +1989,7 @@ def : Flag<["-"], "fno-diagnostics-color">, Group, Visibility<[ClangOption, CLOption, DXCOption, FlangOption]>, Alias; def fdiagnostics_color_EQ : Joined<["-"], "fdiagnostics-color=">, Group, - Visibility<[ClangOption, CLOption, DXCOption, FlangOpti

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

@@ -1055,11 +1055,11 @@ def z : Separate<["-"], "z">, Flags<[LinkerInput]>, def offload_link : Flag<["--"], "offload-link">, Group, HelpText<"Use the new offloading linker to perform the link job.">; def Xlinker : Separate<["-"], "Xlinker">, Flags<[LinkerInput, RenderAsInput]

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

https://github.com/Maetveis created https://github.com/llvm/llvm-project/pull/118640 When these options were enabled for flang the visibility was also extended to clang-cl and dxc. I believe this was due to a misunderstanding of the default value for `Visibility`. This is marked as draft beca

[clang] [flang] [flang][Driver] Support -nostdlib and -nodefaultlibs (PR #108868)

@@ -5572,7 +5572,8 @@ def : Flag<["-"], "nocudalib">, Alias; def gpulibc : Flag<["-"], "gpulibc">, Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>, HelpText<"Link the LLVM C Library for GPUs">; def nogpulibc : Flag<["-"], "nogpulibc">, Visibility<[ClangOption, C

[clang] [clang-repl][CMake][MSVC] Use LINKER: instead of `-Wl` (PR #118518)

Maetveis wrote: > LGTM! Thanks! https://github.com/llvm/llvm-project/pull/118518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl][CMake][MSVC] Use LINKER: instead of `-Wl` (PR #118518)

https://github.com/Maetveis closed https://github.com/llvm/llvm-project/pull/118518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][Driver] Support -nostdlib and -nodefaultlibs (PR #108868)

https://github.com/Maetveis edited https://github.com/llvm/llvm-project/pull/108868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][Driver] Support -nostdlib and -nodefaultlibs (PR #108868)

@@ -5572,7 +5572,8 @@ def : Flag<["-"], "nocudalib">, Alias; def gpulibc : Flag<["-"], "gpulibc">, Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>, HelpText<"Link the LLVM C Library for GPUs">; def nogpulibc : Flag<["-"], "nogpulibc">, Visibility<[ClangOption, C

[clang] [Clang] Fix -Wunused-private-field false negative with defaulted comparison operators (PR #116871)

Maetveis wrote: Hey, @whiteio I'm sorry the review is taking long, Aaron was off for the holidays. In the meantime it looks like some conflicts came up, are you comfortable resolving those or do you need help? I'll ping Aaron or find some other front-end reviewer once the conflicts are resolv

[clang] [clang-repl][CMake][MSVC] Use LINKER: instead of `-Wl` (PR #118518)

https://github.com/Maetveis edited https://github.com/llvm/llvm-project/pull/118518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl][CMake][MSVC] Use LINKER: instead of `-Wl` (PR #118518)

https://github.com/Maetveis created https://github.com/llvm/llvm-project/pull/118518 This is supported since CMake 3.12, it should be more portable too. This also avoids passing the option to `clang-cl` when linking, because `clang-cl` accepts any `-W` flags (normally warning flags) during lin

[clang] [flang] [flang][Driver] Support -nostdlib and -nodefaultlibs (PR #108868)

@@ -5572,7 +5572,8 @@ def : Flag<["-"], "nocudalib">, Alias; def gpulibc : Flag<["-"], "gpulibc">, Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>, HelpText<"Link the LLVM C Library for GPUs">; def nogpulibc : Flag<["-"], "nogpulibc">, Visibility<[ClangOption, C

[clang] [clang-repl]: Print stack-trace on crash (PR #117896)

https://github.com/Maetveis closed https://github.com/llvm/llvm-project/pull/117896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl]: Print stack-trace on crash (PR #117896)

https://github.com/Maetveis edited https://github.com/llvm/llvm-project/pull/117896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl]: Print stack-trace on crash (PR #117896)

Maetveis wrote: > LGTM! Do you have commit access or shall I land this change for you? Thanks that was extremely quick. I have access, but I'll wait for the CI to finish to be sure. https://github.com/llvm/llvm-project/pull/117896 ___ cfe-commits ma

[clang] [clang-repl]: Print stack-trace on crash (PR #117896)

https://github.com/Maetveis created https://github.com/llvm/llvm-project/pull/117896 Call `llvm::sys::PrintStackTraceOnErrorSignal` at the start of main to 1. Print a strack trace on crash 2. Disable the assertion failed popup in Windows Debug Builds Other tools (for example clang-check or clan

  1   2   >