https://github.com/Maetveis created
https://github.com/llvm/llvm-project/pull/118518
This is supported since CMake 3.12, it should be more portable too. This also
avoids passing the option to `clang-cl` when linking, because `clang-cl`
accepts any `-W` flags (normally warning flags) during linking (#118516).
From 58dd694d883aa69a331171dc19baf18bc9ec7f47 Mon Sep 17 00:00:00 2001
From: Gergely Meszaros <gergely.mesza...@intel.com>
Date: Tue, 3 Dec 2024 09:16:52 -0800
Subject: [PATCH] [clang-repl][CMake][MSVC] Use LINKER: instead of `-Wl`
This is supported since CMake 3.12, it should be more portable too.
This also avoids passing the option to `clang-cl` when linking,
because `clang-cl` accepts any `-W` flags (normally warning flags)
during linking (#118516).
---
clang/tools/clang-repl/CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang/tools/clang-repl/CMakeLists.txt
b/clang/tools/clang-repl/CMakeLists.txt
index 7aebbe7a19436a..f9a911b0ae8e24 100644
--- a/clang/tools/clang-repl/CMakeLists.txt
+++ b/clang/tools/clang-repl/CMakeLists.txt
@@ -66,7 +66,7 @@ clang_target_link_libraries(clang-repl PRIVATE
# start to exceed this limit, e.g. when linking for arm-linux-gnueabihf with
# gold. This flag tells the linker to build a PLT for the full address range.
# Linkers without this flag are assumed to support proper PLTs by default.
-set(flag_long_plt "-Wl,--long-plt")
+set(flag_long_plt "LINKER:--long-plt")
check_linker_flag(CXX ${flag_long_plt} HAVE_LINKER_FLAG_LONG_PLT)
if(HAVE_LINKER_FLAG_LONG_PLT)
target_link_options(clang-repl PRIVATE ${flag_long_plt})
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
