[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added a comment. In D152405#4645719 , @dyung wrote: > Hi @leonardchan your change was still causing a failure on the PS4 linux bot, > so I reverted it in 070493ddbd9473499d6f00ca62bc6aa92808ed79 >

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added inline comments. Comment at: clang/include/clang/Driver/Options.td:2250 +def fexperimental_omit_rtti_component : + Flag<["-"], "fexperimental-omit-rtti-component">, + Group, Flags<[CC1Option]>, phosek wrote: > I think the name should signal th

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6385c1df919f: [clang] Add experimental option to omit the RTTI component from the vtable when… (authored by leonardchan). Changed prior to commit:

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan updated this revision to Diff 556724. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152405/new/ https://reviews.llvm.org/D152405 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added a comment. In D152405#4404742 , @mcgrathr wrote: > In D152405#4404616 , @leonardchan > wrote: > >> Oh this is completely independent from relative vtables. I'll update the >> wording. > > Great

[PATCH] D72959: Relative VTables ABI on Fuchsia

leonardchan abandoned this revision. leonardchan marked an inline comment as done. leonardchan added a comment. Herald added a subscriber: bd1976llvm. This was landed in various other smaller changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D729

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

leonardchan added a comment. Hi. I think this caused the override-layout.cpp test to fail on our windows builder (https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8778279637538184401/+/u/clang/test/stdout?format=raw): FAIL: Clang :: CodeGenCXX/override-layout.cpp (7816 of 187

[PATCH] D132275: [clang] Create alloca to pass into static lambda

leonardchan added a comment. Ok here's some of my findings. So there's a step in the attributor where it replaces some instructions with `unreachable`. One step is: *** IR Dump Before AttributorPass on [module] *** ; Function Attrs: inlinehint minsize nounwind optsize define linkonce_odr d

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added a comment. > Can we extend the test cases to exercise both with and without > relative-vtables also enabled? Yup, the cases here already test with the regular itanium c++ abi and relative vtables abi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added a comment. In D152405#4404596 , @mcgrathr wrote: > It's not clear from the change description if this can be enabled > orthogonally to relative-vtables. I think it should be possible to choose > each switch independently, thus generati

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a project: All. leonardchan requested review of this revision. Herald added a subscriber: MaskRay. For programs that don't use RTTI, the rtti component is just replace

[PATCH] D132275: [clang] Create alloca to pass into static lambda

leonardchan added subscribers: jdoerfert, leonardchan. leonardchan added a comment. Hi. For an embedded device, prior to this patch, we used to be able to see a significant savings of 28kB when we enabled the attributor. But with this patch, we don't see these savings anymore when enabling the a

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

leonardchan added a comment. In D147209#4245229 , @fpetrogalli wrote: > In D147209#4244615 , @leonardchan > wrote: > >> Hi. I think this led to some test failures on our builder at >> https://luci-milo.appspot.

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

leonardchan added a comment. Hi. I think this led to some test failures on our builder at https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8784708268307261009/overview: Script: -- : 'RUN: at line 4'; rm -rf /b/s/w/ir/x/w/staging/llvm_build/tools/clang/te

[PATCH] D144291: [clang-format-diff] Correctly parse start-of-file diffs

This revision was automatically updated to reflect the committed changes. Closed by commit rG50563944ab96: [clang-format-diff] Correctly parse start-of-file diffs (authored by tamird, committed by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D139589: [clang][Fuchsia] Re-enable hwasan global instrumentation on hwasan multilibs

leonardchan abandoned this revision. leonardchan added a comment. This was landed in https://reviews.llvm.org/rG4308166403b4c28b6db7094a4e202e42da6e28a8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139589/new/ https://reviews.llvm.org/D139589 __

[PATCH] D144035: [SCEV] Ensure SCEV does not replace aliases with their aliasees

leonardchan added a subscriber: reames. leonardchan added a comment. @reames let's continue the discussion here. What specific bits with the optimizer does this break? I'm not too familiar with SVEC. Prior to this, one thing I tried was instead just doing `Ops.push_back(GA)` and `getSCEV(GA)` bu

[PATCH] D144035: [SCEV] Ensure SCEV does not replace aliases with their aliasees

This revision was automatically updated to reflect the committed changes. Closed by commit rG608ee703e530: [SCEV] Ensure SCEV does not replace aliases with their aliasees (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035

[PATCH] D144035: [SCEV] Ensure SCEV does not replace aliases with their aliasees

leonardchan added a comment. @pcc does this lgty? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035/new/ https://reviews.llvm.org/D144035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

leonardchan added a comment. In D144035#4145662 , @MaskRay wrote: >> Full context at https://github.com/llvm/llvm-project/issues/60668. > > Best to leave a simplified description in the summary so that a reader > doesn't have to go to the external link a

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

leonardchan updated this revision to Diff 499668. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035/new/ https://reviews.llvm.org/D144035 Files: llvm/lib/Analysis/ScalarEvolution.cpp llvm/test/Ana

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

leonardchan added a comment. In D144035#4143030 , @pcc wrote: > Passes shouldn't be replacing aliases with aliasees in general, see D66606 > . The right fix is to fix SCEV to not do > that. Updated Repository: rG LL

[PATCH] D144035: [hwasan] Ensure SCEV does not replace aliases with their aliasees

leonardchan updated this revision to Diff 499349. leonardchan retitled this revision from "[hwasan] Ensure hwasan aliases do not have ODR linkage" to "[hwasan] Ensure SCEV does not replace aliases with their aliasees". leonardchan edited the summary of this revision. Repository: rG LLVM Github

[PATCH] D144035: [hwasan] Ensure hwasan aliases do not have ODR linkage

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035/new/ https://reviews.llvm.org/D144035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D144035: [hwasan] Ensure hwasan aliases do not have ODR linkage

leonardchan added a comment. Lemme know if the clang regression test isn't necessary or should be in its own commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035/new/ https://reviews.llvm.org/D144035 __

[PATCH] D144035: [hwasan] Ensure hwasan aliases do not have ODR linkage

leonardchan created this revision. leonardchan added reviewers: pcc, eugenis, vitalybuka. leonardchan added a project: Sanitizers. Herald added subscribers: Enna1, jeroen.dobbelaere, hiraditya. Herald added a project: All. leonardchan requested review of this revision. Herald added projects: clang,

[PATCH] D143533: [clang] Allow gnu::aligned attribute to work with templated type alias declarations

leonardchan created this revision. leonardchan added reviewers: rsmith, rnk, echristo. leonardchan added a project: clang. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. leonardchan requested review of this revision. Prior to this, the following would fail: template

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG003b6033e1b2: [clang] Ensure correct metadata for relative vtables (authored by leonardchan). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D139589: [clang][Fuchsia] Re-enable hwasan global instrumentation on hwasan multilibs

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: abrachet. Herald added a project: All. leonardchan requested review of this revision. We can land this once we assert global instrumentation is enabled f

[PATCH] D138855: [clang][Fuchsia] Allow for setting the default build type

leonardchan created this revision. leonardchan added a reviewer: phosek. leonardchan added a project: clang. Herald added a subscriber: abrachet. Herald added a project: All. leonardchan requested review of this revision. Prior to this, `CMAKE_BUILD_TYPE` would unconditionally be `Release`. This

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134687/new/ https://reviews.llvm.org/D134687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

leonardchan updated this revision to Diff 468701. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134687/new/ https://reviews.llvm.org/D134687 Files: clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/C

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. > Naive question, but what does it mean to target Fuschia but be > gnu-compatible? (how would that be different than using whatever gnu OS > (linux, etc) the other code was built for) (Probably poor wording on my part.) When I mention gnu-compatible here, I don't m

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. In D85802#3858760 , @rjmccall wrote: > Does Fuchsia still need this? If those experiments have stabilized, maybe we > can just remove it. Also, it should probably have been a -cc1 flag in the > first place. We still use th

[PATCH] D135713: [cmake][Fuchsia] Add -ftrivial-auto-var-init=zero to runtimes build

leonardchan added a comment. In D135713#3850730 , @mcgrathr wrote: > I had imagined making lsan always do this since there's a specific > lsan-related rationale for it that applies to everybody. > I'm not clear on how cmake structures things and whether

[PATCH] D135713: [cmake][Fuchsia] Add -ftrivial-auto-var-init=zero to runtimes build

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: abrachet. Herald added a project: All. leonardchan requested review of this revision. This might allow lsan to find more leaks that would have gone undet

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, tejohnson, pcc. leonardchan added a project: clang. Herald added a subscriber: Prazek. Herald added a project: All. leonardchan requested review of this revision. Prior to this, metadata pertaining to the size or add

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21b03bf97061: [llvm] Handle dso_local_equivalent in FunctionComparator (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

leonardchan added a comment. Will wait until EOD before committing this unless others have more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134300/new/ https://reviews.llvm.org/D134300 ___ cf

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

leonardchan added inline comments. Comment at: llvm/test/Transforms/MergeFunc/dso_local_equivalent_merged.ll:1 +;; Check the cases involving dso_local_equivalent where we do expect functions to be merged. +; RUN: opt -S -mergefunc < %s | FileCheck %s nikic wrote

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

leonardchan updated this revision to Diff 461686. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134300/new/ https://reviews.llvm.org/D134300 Files: llvm/lib/Transforms/Utils/FunctionComparator.cpp llvm/test/Transforms/MergeFunc/dso_local_equival

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

leonardchan added a comment. @phosek feel free to add who you think is appropriate for reviewing this. This is a conservative comparison of dso_local_equivalents where two are the same only if they point to the same underlying function. It could be argued that a `dso_local_equivalent @func` cou

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

leonardchan created this revision. leonardchan added a reviewer: phosek. leonardchan added a project: LLVM. Herald added subscribers: abrachet, hiraditya. Herald added a project: All. leonardchan requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

leonardchan added a comment. In D132425#3752468 , @hctim wrote: > Glad to see that refactoring the sanitizer metadata made someone's life > easier ;) (now allowing for disabling hwasanificiation of globals) > > Patch looks reasonable to me. Can you pleas

[PATCH] D132691: [clang] Do not instrument the rtti_proxies under hwasan

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdb30f7a2635: [clang] Do not instrument the rtti_proxies under hwasan (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

This revision was automatically updated to reflect the committed changes. Closed by commit rG93e5cf6b9c08: [clang] Do not instrument relative vtables under hwasan (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132425/new/ h

[PATCH] D132691: [clang] Do not instrument the rtti_proxies under hwasan

leonardchan created this revision. leonardchan added reviewers: mcgrathr, phosek. leonardchan added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. leonardchan requested review of this revision. We run into a duplicate symbol error when instrumenting the rt

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

leonardchan added a comment. In D132425#3743276 , @mcgrathr wrote: > lgtm. > You might add some comments in CGVTables.cpp about why this is done and what > the alternatives might be in the future. Done. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

leonardchan updated this revision to Diff 455423. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132425/new/ https://reviews.llvm.org/D132425 Files: clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/CGVTables.h clang/lib/CodeGen/ItaniumCXXABI.c

[PATCH] D132620: [WIP][llvm] Extend aarch64 and x86_64 elf targets to use gotpcrel relocations

leonardchan created this revision. Herald added subscribers: pengfei, hiraditya, kristof.beyls. Herald added a project: All. leonardchan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

leonardchan created this revision. leonardchan added reviewers: mcgrathr, eugenis, phosek, vitalybuka. leonardchan added a project: clang. Herald added subscribers: abrachet, kristof.beyls. Herald added a project: All. leonardchan requested review of this revision. Full context in https://bugs.fuc

[PATCH] D131274: [clang][Darwin] Re-apply "Always set the default C++ Standard Library to libc++"

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Asserted locally the test passes. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131274/new/ https://reviews.

[PATCH] D130516: [llvm] compression classes

leonardchan added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:255-256 +} else + return error("Compressed string table, but " + + (CompressionScheme->Name + " is unavailable").str()); + } nit: I think `

[PATCH] D130516: [llvm] compression classes

leonardchan added inline comments. Comment at: llvm/lib/Support/Compression.cpp:30-32 +ZStdCompressionAlgorithm +*llvm::compression::ZStdCompressionAlgorithm::Instance = +new ZStdCompressionAlgorithm(); Perhaps for each of these, you could instead hav

[PATCH] D130516: [llvm] compression classes

leonardchan added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:193-194 } -if (llvm::compression::zlib::isAvailable()) { +llvm::compression::CompressionAlgorithm *CompressionScheme = +new llvm::compression::ZlibCompressionAlgor

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

leonardchan accepted this revision. leonardchan added a comment. LGTM tested on mac on my end Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ cfe-commits ma

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM although I think I'd be more comfortable with Petr's +2 for cmake changes. Would it be better instead to expose `LLVM_ENABLE_ZSTD` to subrepos like clangd or flang until they're

[PATCH] D128754: Refactor LLVM compression namespaces (Part 1: remove crc32)

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Should probably add `[llvm]` to the subject also. Generally it's helpful for immediately knowing which subrepo you're touching. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D128953: refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain.

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Should also probably add `[NFC]` to the start of the subject Comment at: lld/ELF/InputSection.cpp:77 +if (!compression::zlib::isAvailable()) + error(

[PATCH] D128754: Refactor LLVM compression namespaces

leonardchan added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:183-191 +* Refactor compression namespaces across the project, making way for a possible + introduction of alternatives to zlib compression in the llvm toolchain. + Changes are as follows: + * Remove crc

[PATCH] D128754: Refactor LLVM compression namespaces

leonardchan added a comment. > Feedback needed on: > this namespace approach will result in tooling compression methods being set > at compile time, however we may want to aim for a runtime configurable > approach in the future, likely a new revision of the compressed data formats > that llvm i

[PATCH] D108469: Improve handling of static assert messages.

leonardchan added a comment. I think this might be the cause of the many libc++ static_assert failures we're seeing on our builders: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8810079977358640657/overview Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run

leonardchan added a comment. In D128567#3609635 , @leonardchan wrote: > Won't be landing this until I'm sure any new tests that will be running from > this won't fail locally. Or given https://reviews.llvm.org/D126936 and this could just pass magically

[PATCH] D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run

leonardchan added a comment. An alternative approach to this is update this bit of cmake in compiler-rt/CMakeLists.txt: set(COMPILER_RT_LLD_PATH ${LLVM_MAIN_SRC_DIR}/tools/lld) if(EXISTS ${COMPILER_RT_LLD_PATH}/ AND LLVM_TOOL_LLD_BUILD) set(COMPILER_RT_HAS_LLD TRUE) else() set(COMP

[PATCH] D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run

leonardchan added a comment. Won't be landing this until I'm sure any new tests that will be running from this won't fail locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128567/new/ https://reviews.llvm.org/D128567

[PATCH] D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run

leonardchan created this revision. leonardchan added a reviewer: phosek. leonardchan added a project: clang. Herald added subscribers: abrachet, kristof.beyls, mgorny. Herald added a project: All. leonardchan requested review of this revision. Herald added a subscriber: cfe-commits. `LLVM_TOOL_LLD

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. leonardchan marked an inline comment as done. Closed by commit rG4ac58b61022d: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the… (authored by

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

leonardchan marked an inline comment as done. leonardchan added a comment. In D119201#3303275 , @phosek wrote: > Have you checked if all the tests are still passing? All the clang tests seem to be passing, but I'll run the llvm and runtimes tests also.

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

leonardchan updated this revision to Diff 406871. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119201/new/ https://reviews.llvm.org/D119201 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/Fuchsia.cpp Index: clang

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

leonardchan updated this revision to Diff 406664. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119201/new/ https://reviews.llvm.org/D119201 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/li

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added projects: clang, Sanitizers. Herald added a subscriber: abrachet. leonardchan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119201 Files: cla

[PATCH] D113143: [clang][asan] Add test for ensuring PR52382 is fixed

This revision was automatically updated to reflect the committed changes. Closed by commit rG456a7e52310d: [clang][asan] Add test for ensuring PR52382 is fixed (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113143/new/ http

[PATCH] D113143: [clang][asan] Add test for ensuring PR52382 is fixed

leonardchan created this revision. leonardchan added reviewers: aeubanks, vitalybuka. leonardchan added a project: Sanitizers. leonardchan requested review of this revision. Herald added a project: clang. The fix for PR52382 was already introduced in D112732 whi

[PATCH] D110451: [IR] Increase max alignment to 4GB

leonardchan added a comment. Finally got the stacktrace: leonardchan@cp-snakewater:~/llvm-monorepo/llvm-build-1-clang-only-debug$ bin/clang++ "-cc1" "-triple" "x86_64-unknown-linux-gnu" "-emit-obj" "--mrelax-relocations" "-disable-free" "-main-file-name" "AArch64SpeculationHardening.cpp" "-m

[PATCH] D110451: [IR] Increase max alignment to 4GB

leonardchan added a comment. Hi. It seems the reland caused an assertion to fail on our clang builders (https://luci-milo.appspot.com/ui/p/fuchsia/builders/prod/clang-linux-x64/b8834065059600721665/overview): [194/194] Building CXX object lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/A

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

leonardchan added a comment. Hi. I think our clang builders are failing from this after the reland (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8833962834812688769/overview): Script: -- /b/s/w/ir/x/w/staging/llvm_build/tools/clang/unittests/Interprete

[PATCH] D110778: [clang][Fuchsia] Re-enable compiler-rt tests in runtimes build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8480063f25b8: [clang][Fuchsia] Re-enable compiler-rt tests in runtimes build (authored by leonardchan). Herald added a subscriber: abrachet. Reposit

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan added a comment. Hmm. Just found out about this, but for future reference, I think this will only work for `ninja check-runtimes` and `ninja check-runtimes-{target}`, but not necessarily `ninja -C runtimes/runtimes-{target} check-runtimes/check-compilter-rt`. Repository: rG LLVM

[PATCH] D110889: [clang][Fuchsia] Add -DSCUDO_DISABLE_TBI to test flags

leonardchan abandoned this revision. leonardchan added a comment. Herald added a subscriber: abrachet. In D110889#3035597 , @phosek wrote: > Is this needed even with D110888 ? Nope, at least after the updated patch this

[PATCH] D110889: [clang][Fuchsia] Add -DSCUDO_DISABLE_TBI to test flags

leonardchan created this revision. leonardchan added a reviewer: phosek. Herald added subscribers: cryptoad, kristof.beyls, mgorny. leonardchan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After D110888

[PATCH] D110778: [clang][Fuchsia] Re-enable compiler-rt tests in runtimes build

leonardchan created this revision. leonardchan added a reviewer: phosek. Herald added subscribers: mgorny, dberris. leonardchan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79b422080612: [runtimes] Ensure required deps for tests targets are actually built (authored by leonardchan). Repository: rG LLVM Github Monorepo

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan updated this revision to Diff 376042. leonardchan edited the summary of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109625/new/ https://reviews.llvm.o

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan added a comment. In D109625#3029581 , @phosek wrote: > I'm still unsure if this is the right strategy because it creates a > dependency cycle. Specifically, you have the LLVM build trigger the build of > runtimes, and that build would invoke

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan updated this revision to Diff 375713. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109625/new/ https://reviews.llvm.org/D109625 Files: compiler-rt/test/CMakeLists.txt Index: compiler-rt/test/CMakeLists.txt ==

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan added a comment. Updated to exclude readelf. We also don't need any of the other tools added in the `NOT COMPILER_RT_STANDALONE_BUILD` case, so I just added them to `LIT_ONLY_TOOLS` in the `COMPILER_RT_STANDALONE_BUILD` case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan updated this revision to Diff 374984. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109625/new/ https://reviews.llvm.org/D109625 Files: compiler-rt/cmake/Modules/AddCompilerRT.cmake compiler-rt/test/CMakeLists.txt Index: compiler-r

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan added inline comments. Comment at: compiler-rt/test/CMakeLists.txt:48 + if (NOT TARGET ${dep}) +llvm_ExternalProject_BuildCmd(build_${dep} ${dep} ${BINARY_DIR}) +add_custom_target(${dep} leonardchan wrote: > phosek wrote: > > This

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan updated this revision to Diff 374396. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109625/new/ https://reviews.llvm.org/D109625 Files: compiler-rt/test/CMakeLists.txt Index: compiler-rt/test/CMakeLists.txt ==

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan added inline comments. Comment at: compiler-rt/test/CMakeLists.txt:48 + if (NOT TARGET ${dep}) +llvm_ExternalProject_BuildCmd(build_${dep} ${dep} ${BINARY_DIR}) +add_custom_target(${dep} phosek wrote: > This is going to run Ninja

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan updated this revision to Diff 374393. leonardchan retitled this revision from "[compiler-rt] Ensure LIT_TEST_DEP targets are actually built" to "[compiler-rt] Ensure required deps for tests targets are actually built". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109625: [compiler-rt] Ensure LIT_TEST_DEP targets are actually built

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109625/new/ https://reviews.llvm.org/D109625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D109625: [compiler-rt] Ensure LIT_TEST_DEP targets are actually built

leonardchan created this revision. leonardchan added a reviewer: phosek. Herald added subscribers: mgorny, dberris. leonardchan requested review of this revision. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. When building compiler-rt via runtimes, many tests fail beca

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5673564a06b: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on… (authored by leonardchan). Repository: rG LLVM Github Monore

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

leonardchan added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:123 set(RUNTIMES_${target}_COMPILER_RT_USE_BUILTINS_LIBRARY ON CACHE BOOL "") +set(RUNTIMES_${target}_COMPILER_RT_BUILD_BUILTINS ON CACHE BOOL "") +set(RUNTIMES_${target}_COMPILER_

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

leonardchan updated this revision to Diff 371163. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109199/new/ https://reviews.llvm.org/D109199 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake ==

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

leonardchan added a comment. Split also into https://reviews.llvm.org/D109207 and https://reviews.llvm.org/D109208 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109199/new/ https://reviews.llvm.org/D109199

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

leonardchan updated this revision to Diff 370447. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109199/new/ https://reviews.llvm.org/D109199 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake ==

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

leonardchan added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:141 +set(RUNTIMES_${target}_SANITIZER_COMMON_TEST_TARGET_CFLAGS "--unwindlib=libunwind -static-libgcc" CACHE STRING "") +set(RUNTIMES_${target}_TSAN_TEST_TARGET_CFLAGS "--unwindlib=lib

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

leonardchan added a comment. In D109199#2981174 , @phosek wrote: > @leonardchan would it be possible to break this up into 3 changes? Can do. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:123 set(RUNTIMES_${target}_COMPILER

  1   2   3   4   5   6   7   8   9   >