leonardchan added a comment.
Hi. I think this caused the override-layout.cpp test to fail on our windows
builder
(https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8778279637538184401/+/u/clang/test/stdout?format=raw):
FAIL: Clang :: CodeGenCXX/override-layout.cpp (7816 of 18732)
******************** TEST 'Clang :: CodeGenCXX/override-layout.cpp' FAILED
********************
Script:
--
: 'RUN: at line 1'; c:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe -cc1
-internal-isystem c:\b\s\w\ir\x\w\staging\llvm_build\lib\clang\17\include
-nostdsysteminc -std=c++14 -w -fdump-record-layouts-simple
C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\CodeGenCXX\override-layout.cpp >
C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.layouts
: 'RUN: at line 2'; c:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe -cc1
-internal-isystem c:\b\s\w\ir\x\w\staging\llvm_build\lib\clang\17\include
-nostdsysteminc -std=c++14 -w -fdump-record-layouts-simple
C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\CodeGenCXX\override-layout.cpp >
C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.before
: 'RUN: at line 3'; c:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe -cc1
-internal-isystem c:\b\s\w\ir\x\w\staging\llvm_build\lib\clang\17\include
-nostdsysteminc -std=c++14 -w -DPACKED= -DALIGNED16=
-fdump-record-layouts-simple
-foverride-record-layout=C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.layouts
C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\CodeGenCXX\override-layout.cpp >
C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.after
: 'RUN: at line 4'; diff -u
C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.before
C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.after
: 'RUN: at line 5'; c:\b\s\w\ir\x\w\staging\llvm_build\bin\filecheck.exe
--check-prefixes=CHECK,PRE17
C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\CodeGenCXX\override-layout.cpp <
C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.after
: 'RUN: at line 7'; c:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe -cc1
-internal-isystem c:\b\s\w\ir\x\w\staging\llvm_build\lib\clang\17\include
-nostdsysteminc -std=c++17 -w -fdump-record-layouts-simple
C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\CodeGenCXX\override-layout.cpp >
C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.layouts
: 'RUN: at line 8'; c:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe -cc1
-internal-isystem c:\b\s\w\ir\x\w\staging\llvm_build\lib\clang\17\include
-nostdsysteminc -std=c++17 -w -fdump-record-layouts-simple
C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\CodeGenCXX\override-layout.cpp >
C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.before
: 'RUN: at line 9'; c:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe -cc1
-internal-isystem c:\b\s\w\ir\x\w\staging\llvm_build\lib\clang\17\include
-nostdsysteminc -std=c++17 -w -DPACKED= -DALIGNED16=
-fdump-record-layouts-simple
-foverride-record-layout=C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.layouts
C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\CodeGenCXX\override-layout.cpp >
C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.after
: 'RUN: at line 10'; diff -u
C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.before
C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.after
: 'RUN: at line 11'; c:\b\s\w\ir\x\w\staging\llvm_build\bin\filecheck.exe
--check-prefixes=CHECK,CXX17
C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\CodeGenCXX\override-layout.cpp <
C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.after
--
Exit Code: 1
Command Output (stdout):
--
$ ":" "RUN: at line 1"
$ "c:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe" "-cc1"
"-internal-isystem" "c:\b\s\w\ir\x\w\staging\llvm_build\lib\clang\17\include"
"-nostdsysteminc" "-std=c++14" "-w" "-fdump-record-layouts-simple"
"C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\CodeGenCXX\override-layout.cpp"
$ ":" "RUN: at line 2"
$ "c:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe" "-cc1"
"-internal-isystem" "c:\b\s\w\ir\x\w\staging\llvm_build\lib\clang\17\include"
"-nostdsysteminc" "-std=c++14" "-w" "-fdump-record-layouts-simple"
"C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\CodeGenCXX\override-layout.cpp"
$ ":" "RUN: at line 3"
$ "c:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe" "-cc1"
"-internal-isystem" "c:\b\s\w\ir\x\w\staging\llvm_build\lib\clang\17\include"
"-nostdsysteminc" "-std=c++14" "-w" "-DPACKED=" "-DALIGNED16="
"-fdump-record-layouts-simple"
"-foverride-record-layout=C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.layouts"
"C:\b\s\w\ir\x\w\llvm-llvm-project\clang\test\CodeGenCXX\override-layout.cpp"
$ ":" "RUN: at line 4"
$ "diff" "-u"
"C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.before"
"C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.after"
# command output:
---
C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.before
+++
C:\b\s\w\ir\x\w\staging\llvm_build\tools\clang\test\CodeGenCXX\Output\override-layout.cpp.tmp.after
@@ -116,5 +116,5 @@
Size:512
Alignment:128
BaseOffsets: [0]>
- VBaseOffsets: [48]>
+ VBaseOffsets: [33]>
FieldOffsets: [256]>
error: command failed with exit status: 1
--
Would you be able to send out a fix or revert? Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152472/new/
https://reviews.llvm.org/D152472
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
