https://github.com/bob80905 approved this pull request.
https://github.com/llvm/llvm-project/pull/122357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -871,6 +871,34 @@ float3 degrees(float3);
_HLSL_BUILTIN_ALIAS(__builtin_hlsl_elementwise_degrees)
float4 degrees(float4);
+//===--===//
+// distance builtins
+//===--
@@ -871,6 +871,34 @@ float3 degrees(float3);
_HLSL_BUILTIN_ALIAS(__builtin_hlsl_elementwise_degrees)
float4 degrees(float4);
+//===--===//
+// distance builtins
+//===--
https://github.com/bob80905 approved this pull request.
https://github.com/llvm/llvm-project/pull/121989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4721,9 +4721,9 @@ def HLSLPackOffset: HLSLAnnotationAttr {
let Args = [IntArgument<"Subcomponent">, IntArgument<"Component">];
let Documentation = [HLSLPackOffsetDocs];
let AdditionalMembers = [{
- unsigned getOffset() {
-return subcomponent * 4 + compone
@@ -194,17 +196,19 @@ static unsigned calculateLegacyCbufferSize(const
ASTContext &Context,
calculateLegacyCbufferSize(Context, VT->getElementType());
Size = ElementSize * ElementCount;
} else {
-Size = Context.getTypeSize(T);
+Size = Context.getTypeSize(
@@ -219,33 +223,41 @@ void SemaHLSL::ActOnFinishBuffer(Decl *Dcl,
SourceLocation RBrace) {
}
}
- if (HasPackOffset && HasNonPackOffset)
-Diag(BufDecl->getLocation(), diag::warn_hlsl_packoffset_mix);
-
- if (HasPackOffset) {
-ASTContext &Context = getASTContext
https://github.com/bob80905 approved this pull request.
https://github.com/llvm/llvm-project/pull/121842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 closed
https://github.com/llvm/llvm-project/pull/119643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 edited
https://github.com/llvm/llvm-project/pull/119643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,15 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-library -x hlsl -ast-dump
-ast-dump-filter=__is_structured_resource_element_compatible %s | FileCheck %s
+
+// CHECK: ConceptDecl 0x{{[0-9a-f]+}} <>
__is_structured_resource_element_compatible
+// CHECK: |-Temp
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/119643
>From cbcdcd37ec82e7bbb5fdd1cf83b093778d4fcf9f Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Wed, 11 Dec 2024 17:02:02 -0800
Subject: [PATCH 1/7] add concepts for raw buffers
---
clang/lib/Sema/HLSLExte
https://github.com/bob80905 approved this pull request.
https://github.com/llvm/llvm-project/pull/120466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 edited
https://github.com/llvm/llvm-project/pull/119643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 edited
https://github.com/llvm/llvm-project/pull/119643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/119643
>From cbcdcd37ec82e7bbb5fdd1cf83b093778d4fcf9f Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Wed, 11 Dec 2024 17:02:02 -0800
Subject: [PATCH 1/5] add concepts for raw buffers
---
clang/lib/Sema/HLSLExte
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/119643
>From cbcdcd37ec82e7bbb5fdd1cf83b093778d4fcf9f Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Wed, 11 Dec 2024 17:02:02 -0800
Subject: [PATCH 1/4] add concepts for raw buffers
---
clang/lib/Sema/HLSLExte
https://github.com/bob80905 edited
https://github.com/llvm/llvm-project/pull/119643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/119643
>From cbcdcd37ec82e7bbb5fdd1cf83b093778d4fcf9f Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Wed, 11 Dec 2024 17:02:02 -0800
Subject: [PATCH 1/3] add concepts for raw buffers
---
clang/lib/Sema/HLSLExte
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/119643
>From cbcdcd37ec82e7bbb5fdd1cf83b093778d4fcf9f Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Wed, 11 Dec 2024 17:02:02 -0800
Subject: [PATCH 1/2] add concepts for raw buffers
---
clang/lib/Sema/HLSLExte
https://github.com/bob80905 created
https://github.com/llvm/llvm-project/pull/119643
This PR adds concept validation to raw buffers like Structured buffers, in the
same way that it was done for typed buffers in
https://github.com/llvm/llvm-project/pull/116413.
This PR should also be responsib
https://github.com/bob80905 closed
https://github.com/llvm/llvm-project/pull/119444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 created
https://github.com/llvm/llvm-project/pull/119444
Cleaning up some comments that @bogner pointed out were unpolished.
>From 3a09b73239a4b14b8704d71ad5683abdf5ff8b08 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 10 Dec 2024 11:45:56 -0800
Subject: [
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/119444
>From 3a09b73239a4b14b8704d71ad5683abdf5ff8b08 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 10 Dec 2024 11:45:56 -0800
Subject: [PATCH 1/2] cleanup comments NFC
---
clang/lib/Sema/HLSLExternalSema
@@ -5720,8 +5720,7 @@ static bool EvaluateUnaryTypeTrait(Sema &Self, TypeTrait
UTT,
case UTT_IsTypedResourceElementCompatible:
assert(Self.getLangOpts().HLSL &&
"typed resource element compatible types are an HLSL-only feature");
-if (Self.RequireCompleteT
https://github.com/bob80905 closed
https://github.com/llvm/llvm-project/pull/115971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115971
>From 7413ceb21a6e0ac9212ef6317763ee0eff559612 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 12 Nov 2024 16:44:00 -0800
Subject: [PATCH 01/15] print struct body within target ext ty context
---
...
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115971
>From 7413ceb21a6e0ac9212ef6317763ee0eff559612 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 12 Nov 2024 16:44:00 -0800
Subject: [PATCH 01/14] print struct body within target ext ty context
---
...
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115971
>From 7413ceb21a6e0ac9212ef6317763ee0eff559612 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 12 Nov 2024 16:44:00 -0800
Subject: [PATCH 01/13] print struct body within target ext ty context
---
...
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115971
>From 7413ceb21a6e0ac9212ef6317763ee0eff559612 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 12 Nov 2024 16:44:00 -0800
Subject: [PATCH 01/12] print struct body within target ext ty context
---
...
https://github.com/bob80905 edited
https://github.com/llvm/llvm-project/pull/115971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 edited
https://github.com/llvm/llvm-project/pull/115971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115971
>From 7413ceb21a6e0ac9212ef6317763ee0eff559612 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 12 Nov 2024 16:44:00 -0800
Subject: [PATCH 01/11] print struct body within target ext ty context
---
...
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115971
>From 7413ceb21a6e0ac9212ef6317763ee0eff559612 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 12 Nov 2024 16:44:00 -0800
Subject: [PATCH 01/10] print struct body within target ext ty context
---
...
https://github.com/bob80905 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/118640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115971
>From 7413ceb21a6e0ac9212ef6317763ee0eff559612 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 12 Nov 2024 16:44:00 -0800
Subject: [PATCH 01/10] print struct body within target ext ty context
---
...
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115971
>From 7413ceb21a6e0ac9212ef6317763ee0eff559612 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 12 Nov 2024 16:44:00 -0800
Subject: [PATCH 1/9] print struct body within target ext ty context
---
.../t
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115971
>From 7413ceb21a6e0ac9212ef6317763ee0eff559612 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 12 Nov 2024 16:44:00 -0800
Subject: [PATCH 1/8] print struct body within target ext ty context
---
.../t
@@ -0,0 +1,25 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-library -x hlsl -ast-dump
-DEMPTY %s | FileCheck -check-prefix=EMPTY %s
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-library -x hlsl -ast-dump %s
| FileCheck %s
+
+
+// EMPTY: CXXRecordDecl 0x{{[0-9A-Fa-f]
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115971
>From 7413ceb21a6e0ac9212ef6317763ee0eff559612 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 12 Nov 2024 16:44:00 -0800
Subject: [PATCH 1/7] print struct body within target ext ty context
---
.../t
https://github.com/bob80905 closed
https://github.com/llvm/llvm-project/pull/116413
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/116413
>From 92ccbe72ca95ad2df5a81b76244a8a8d7cedef40 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Fri, 15 Nov 2024 09:00:15 -0800
Subject: [PATCH 1/7] update new tests
---
clang/lib/Sema/HLSLExternalSemaSour
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115971
>From 7413ceb21a6e0ac9212ef6317763ee0eff559612 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 12 Nov 2024 16:44:00 -0800
Subject: [PATCH 1/6] print struct body within target ext ty context
---
.../t
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115971
>From 7413ceb21a6e0ac9212ef6317763ee0eff559612 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 12 Nov 2024 16:44:00 -0800
Subject: [PATCH 1/4] print struct body within target ext ty context
---
.../t
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115971
>From 7413ceb21a6e0ac9212ef6317763ee0eff559612 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 12 Nov 2024 16:44:00 -0800
Subject: [PATCH 1/5] print struct body within target ext ty context
---
.../t
https://github.com/bob80905 edited
https://github.com/llvm/llvm-project/pull/115971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 edited
https://github.com/llvm/llvm-project/pull/115971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/116413
>From 92ccbe72ca95ad2df5a81b76244a8a8d7cedef40 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Fri, 15 Nov 2024 09:00:15 -0800
Subject: [PATCH 1/6] update new tests
---
clang/lib/Sema/HLSLExternalSemaSour
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/116413
>From 92ccbe72ca95ad2df5a81b76244a8a8d7cedef40 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Fri, 15 Nov 2024 09:00:15 -0800
Subject: [PATCH 1/5] update new tests
---
clang/lib/Sema/HLSLExternalSemaSour
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/116413
>From 92ccbe72ca95ad2df5a81b76244a8a8d7cedef40 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Fri, 15 Nov 2024 09:00:15 -0800
Subject: [PATCH 1/4] update new tests
---
clang/lib/Sema/HLSLExternalSemaSour
@@ -323,19 +325,114 @@ struct TemplateParameterListBuilder {
return *this;
}
- BuiltinTypeDeclBuilder &finalizeTemplateArgs() {
+ // The concept specialization expression (CSE) constructed in
+ // constructConceptSpecializationExpr is constructed so that it
+ // matc
@@ -323,19 +325,114 @@ struct TemplateParameterListBuilder {
return *this;
}
- BuiltinTypeDeclBuilder &finalizeTemplateArgs() {
+ // The concept specialization expression (CSE) constructed in
+ // constructConceptSpecializationExpr is constructed so that it
+ // matc
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/116413
>From 92ccbe72ca95ad2df5a81b76244a8a8d7cedef40 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Fri, 15 Nov 2024 09:00:15 -0800
Subject: [PATCH 1/3] update new tests
---
clang/lib/Sema/HLSLExternalSemaSour
https://github.com/bob80905 edited
https://github.com/llvm/llvm-project/pull/116413
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 closed
https://github.com/llvm/llvm-project/pull/116407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/116413
>From 92ccbe72ca95ad2df5a81b76244a8a8d7cedef40 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Fri, 15 Nov 2024 09:00:15 -0800
Subject: [PATCH 1/2] update new tests
---
clang/lib/Sema/HLSLExternalSemaSour
https://github.com/bob80905 created
https://github.com/llvm/llvm-project/pull/116413
This PR is step one on the journey to implement resource element type
validation via C++20 concepts. The PR sets up the infrastructure for injecting
implicit concept decls / concept specialization expressions
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/116407
>From 68985e64694b0f6e0e779d4711bbff8afb3fe6b2 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 10 Oct 2024 14:31:25 -0700
Subject: [PATCH 01/19] ConceptSpecializationExpr shows up in AST!!!
---
clang
https://github.com/bob80905 created
https://github.com/llvm/llvm-project/pull/116407
None
>From 68985e64694b0f6e0e779d4711bbff8afb3fe6b2 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 10 Oct 2024 14:31:25 -0700
Subject: [PATCH 01/19] ConceptSpecializationExpr shows up in AST!!!
---
https://github.com/bob80905 created
https://github.com/llvm/llvm-project/pull/116305
Reverts llvm/llvm-project#112600
>From 110599f1ada1999c5c33c41928cec0ea6e438992 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Nov 2024 17:08:30 -0800
Subject: [PATCH] Revert "[HLSL] Add implicit
https://github.com/bob80905 closed
https://github.com/llvm/llvm-project/pull/116305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 closed
https://github.com/llvm/llvm-project/pull/115045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 closed
https://github.com/llvm/llvm-project/pull/112600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115045
>From ef4a7eea3eacce4f77b628aebe7f2838733971d0 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 5 Nov 2024 10:35:59 -0800
Subject: [PATCH 1/7] add empty struct test cases
---
.../SemaHLSL/Types/Traits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115045
>From ef4a7eea3eacce4f77b628aebe7f2838733971d0 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 5 Nov 2024 10:35:59 -0800
Subject: [PATCH 1/6] add empty struct test cases
---
.../SemaHLSL/Types/Traits
@@ -1,109 +1,28 @@
// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.6-library
-finclude-default-header -fnative-half-type -verify %s
// expected-no-diagnostics
-struct oneInt {
-int i;
-};
-
-struct twoInt {
- int aa;
- int ab;
-};
-
-struct threeInts {
- oneInt o;
-
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115971
>From 7413ceb21a6e0ac9212ef6317763ee0eff559612 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 12 Nov 2024 16:44:00 -0800
Subject: [PATCH 1/2] print struct body within target ext ty context
---
.../t
@@ -27,3 +27,25 @@ struct ST2 {
static uint X : SV_DispatchThreadID;
uint s : SV_DispatchThreadID;
};
+
+[numthreads(8,8,1)]
+// expected-error@+1 {{attribute 'SV_GroupID' only applies to a field or
parameter of type 'uint/uint2/uint3'}}
+void CSMain_GID(float ID : SV_
https://github.com/bob80905 created
https://github.com/llvm/llvm-project/pull/115971
This PR changes the way that final DXIL is printed by adjusting the way the
type definition section of the DXIL output is printed.
Specifically, when defining a target extension type, if the RHS involves a
str
@@ -323,30 +324,127 @@ struct TemplateParameterListBuilder {
S.Context, Builder.Record->getDeclContext(), SourceLocation(),
SourceLocation(), /* TemplateDepth */ 0, Position,
&S.Context.Idents.get(Name, tok::TokenKind::identifier),
-/* Typename *
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115045
>From ef4a7eea3eacce4f77b628aebe7f2838733971d0 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 5 Nov 2024 10:35:59 -0800
Subject: [PATCH 1/5] add empty struct test cases
---
.../SemaHLSL/Types/Traits
@@ -2200,47 +2200,43 @@ static void BuildFlattenedTypeList(QualType BaseTy,
}
bool SemaHLSL::IsTypedResourceElementCompatible(clang::QualType QT) {
- if (QT.isNull())
+ // null and array types are not allowed.
+ if (QT.isNull() || QT->isArrayType())
return false;
-
@@ -1,109 +1,28 @@
// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.6-library
-finclude-default-header -fnative-half-type -verify %s
// expected-no-diagnostics
-struct oneInt {
-int i;
-};
-
-struct twoInt {
- int aa;
- int ab;
-};
-
-struct threeInts {
- oneInt o;
-
@@ -323,30 +324,127 @@ struct TemplateParameterListBuilder {
S.Context, Builder.Record->getDeclContext(), SourceLocation(),
SourceLocation(), /* TemplateDepth */ 0, Position,
&S.Context.Idents.get(Name, tok::TokenKind::identifier),
-/* Typename *
@@ -323,30 +324,127 @@ struct TemplateParameterListBuilder {
S.Context, Builder.Record->getDeclContext(), SourceLocation(),
SourceLocation(), /* TemplateDepth */ 0, Position,
&S.Context.Idents.get(Name, tok::TokenKind::identifier),
-/* Typename *
@@ -323,30 +324,127 @@ struct TemplateParameterListBuilder {
S.Context, Builder.Record->getDeclContext(), SourceLocation(),
SourceLocation(), /* TemplateDepth */ 0, Position,
&S.Context.Idents.get(Name, tok::TokenKind::identifier),
-/* Typename *
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115045
>From ef4a7eea3eacce4f77b628aebe7f2838733971d0 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 5 Nov 2024 10:35:59 -0800
Subject: [PATCH 1/4] add empty struct test cases
---
.../SemaHLSL/Types/Traits
@@ -323,30 +324,127 @@ struct TemplateParameterListBuilder {
S.Context, Builder.Record->getDeclContext(), SourceLocation(),
SourceLocation(), /* TemplateDepth */ 0, Position,
&S.Context.Idents.get(Name, tok::TokenKind::identifier),
-/* Typename *
https://github.com/bob80905 approved this pull request.
https://github.com/llvm/llvm-project/pull/113648
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5,17 +5,22 @@
StructuredBuffer Buf : register(t10);
RWStructuredBuffer Buf2 : register(u5, space1);
+RasterizerOrderedStructuredBuffer Buf5 : register(u1, space2);
// CHECK: %"class.hlsl::StructuredBuffer" = type { target("dx.RawBuffer",
float, 0, 0), float }
// CHECK
https://github.com/bob80905 approved this pull request.
My other comment is just a nit, I can approve this as it is.
https://github.com/llvm/llvm-project/pull/113643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
@@ -5,17 +5,27 @@
StructuredBuffer Buf : register(t10);
RWStructuredBuffer Buf2 : register(u5, space1);
+AppendStructuredBuffer Buf3 : register(u3);
+ConsumeStructuredBuffer Buf4 : register(u4);
-// CHECK: %"class.hlsl::StructuredBuffer" = type { target("dx.RawBuffer",
floa
@@ -5,17 +5,22 @@
StructuredBuffer Buf : register(t10);
RWStructuredBuffer Buf2 : register(u5, space1);
+RasterizerOrderedStructuredBuffer Buf5 : register(u1, space2);
// CHECK: %"class.hlsl::StructuredBuffer" = type { target("dx.RawBuffer",
float, 0, 0), float }
// CHECK
@@ -5,17 +5,22 @@
StructuredBuffer Buf : register(t10);
RWStructuredBuffer Buf2 : register(u5, space1);
+RasterizerOrderedStructuredBuffer Buf5 : register(u1, space2);
// CHECK: %"class.hlsl::StructuredBuffer" = type { target("dx.RawBuffer",
float, 0, 0), float }
// CHECK
bob80905 wrote:
> Since your PR that adds `__builtin_hlsl_is_typed_resource_element_compatible`
> is merged do you want to incorporate here?
I'd prefer not to, because this PR is already pretty big and I have a separate
task that is singularly dedicated to finalizing the constraint expression,
https://github.com/bob80905 edited
https://github.com/llvm/llvm-project/pull/112600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/115045
>From ef4a7eea3eacce4f77b628aebe7f2838733971d0 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 5 Nov 2024 10:35:59 -0800
Subject: [PATCH 1/2] add empty struct test cases
---
.../SemaHLSL/Types/Traits
@@ -2163,6 +2163,50 @@ static void BuildFlattenedTypeList(QualType BaseTy,
}
}
+bool SemaHLSL::IsTypedResourceElementCompatible(clang::QualType QT) {
+ if (QT.isNull())
+return false;
+
+ // check if the outer type was an array type
+ if (QT->isArrayType())
+retur
https://github.com/bob80905 created
https://github.com/llvm/llvm-project/pull/115045
This PR adds empty struct cases to the test file for the builtin.
>From ef4a7eea3eacce4f77b628aebe7f2838733971d0 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 5 Nov 2024 10:35:59 -0800
Subject: [PAT
https://github.com/bob80905 closed
https://github.com/llvm/llvm-project/pull/114864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 edited
https://github.com/llvm/llvm-project/pull/114864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 created
https://github.com/llvm/llvm-project/pull/114864
This PR implements a new type trait as a builtin,
__builtin_hlsl_is_typed_resource_element_compatible
This type traits verifies that the given input type is suitable as a typed
resource element type.
It checks
https://github.com/bob80905 created
https://github.com/llvm/llvm-project/pull/114853
Reverts llvm/llvm-project#113730
>From c110aaa2eb7862657df58c5f76e4231f27110450 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Mon, 4 Nov 2024 11:11:46 -0800
Subject: [PATCH] Revert "[HLSL] add IsTypedRes
https://github.com/bob80905 closed
https://github.com/llvm/llvm-project/pull/114853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 edited
https://github.com/llvm/llvm-project/pull/114853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 closed
https://github.com/llvm/llvm-project/pull/114852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 created
https://github.com/llvm/llvm-project/pull/114852
Reverts https://github.com/llvm/llvm-project/pull/113730
>From a31199224c19c1087b114de29d864125b720e6d8 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Fri, 25 Oct 2024 12:33:05 -0700
Subject: [PATCH 1/7]
https://github.com/bob80905 closed
https://github.com/llvm/llvm-project/pull/113730
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/113730
>From a31199224c19c1087b114de29d864125b720e6d8 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Fri, 25 Oct 2024 12:33:05 -0700
Subject: [PATCH 1/6] add type trait
---
.../clang/AST/CXXRecordDeclDefinition
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/113730
>From a31199224c19c1087b114de29d864125b720e6d8 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Fri, 25 Oct 2024 12:33:05 -0700
Subject: [PATCH 1/5] add type trait
---
.../clang/AST/CXXRecordDeclDefinition
1 - 100 of 533 matches
Mail list logo
