https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/119444
>From 3a09b73239a4b14b8704d71ad5683abdf5ff8b08 Mon Sep 17 00:00:00 2001
From: Joshua Batista <jbati...@microsoft.com>
Date: Tue, 10 Dec 2024 11:45:56 -0800
Subject: [PATCH 1/2] cleanup comments NFC
---
clang/lib/Sema/HLSLExternalSemaSource.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang/lib/Sema/HLSLExternalSemaSource.cpp
b/clang/lib/Sema/HLSLExternalSemaSource.cpp
index 29672658525403..9eda5e59053e7a 100644
--- a/clang/lib/Sema/HLSLExternalSemaSource.cpp
+++ b/clang/lib/Sema/HLSLExternalSemaSource.cpp
@@ -851,7 +851,7 @@ static Expr *constructTypedBufferConstraintExpr(Sema &S,
SourceLocation NameLoc,
TemplateTypeParmDecl *T) {
ASTContext &Context = S.getASTContext();
- // Obtain the QualType for 'unsigned long'
+ // Obtain the QualType for 'bool'
QualType BoolTy = Context.BoolTy;
// Create a QualType that points to this TemplateTypeParmDecl
>From 8296aa1a3b6d70e1e473b446187b0ae251e3ea69 Mon Sep 17 00:00:00 2001
From: Joshua Batista <jbati...@microsoft.com>
Date: Tue, 10 Dec 2024 11:47:33 -0800
Subject: [PATCH 2/2] more comments
---
clang/lib/Sema/HLSLExternalSemaSource.cpp | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/clang/lib/Sema/HLSLExternalSemaSource.cpp
b/clang/lib/Sema/HLSLExternalSemaSource.cpp
index 9eda5e59053e7a..79fc2751b73812 100644
--- a/clang/lib/Sema/HLSLExternalSemaSource.cpp
+++ b/clang/lib/Sema/HLSLExternalSemaSource.cpp
@@ -325,9 +325,9 @@ struct TemplateParameterListBuilder {
Context, // AST context
Builder.Record->getDeclContext(), // DeclContext
SourceLocation(), SourceLocation(),
- /*depth=*/0, // Depth in the template parameter list
- /*position=*/0, // Position in the template parameter list
- /*id=*/nullptr, // Identifier for 'T'
+ /*D=*/0, // Depth in the template parameter list
+ /*P=*/0, // Position in the template parameter list
+ /*Id=*/nullptr, // Identifier for 'T'
/*Typename=*/true, // Indicates this is a 'typename' or
'class'
/*ParameterPack=*/false, // Not a parameter pack
/*HasTypeConstraint=*/false // Has no type constraint
@@ -877,9 +877,9 @@ static ConceptDecl *constructTypedBufferConceptDecl(Sema &S,
IdentifierInfo &ElementTypeII = Context.Idents.get("element_type");
TemplateTypeParmDecl *T = TemplateTypeParmDecl::Create(
Context, NSD->getDeclContext(), DeclLoc, DeclLoc,
- /*depth=*/0,
- /*position=*/0,
- /*id=*/&ElementTypeII,
+ /*D=*/0,
+ /*P=*/0,
+ /*Id=*/&ElementTypeII,
/*Typename=*/true,
/*ParameterPack=*/false);
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
